[jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread Karan Mehta (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283157#comment-16283157
 ] 

Karan Mehta commented on PHOENIX-4442:
--

bq. Hbase in itself does not replicate unless it's hdfs level

https://hbase.apache.org/0.94/replication.html
HBase does ship WAL edits directly to the DR or any other replica. Zookeeper is 
used to track the global state. [~vincentpoon], this is managed by HBase, right?

> Rename system catalog INDEX_STATE to STATE
> --
>
> Key: PHOENIX-4442
> URL: https://issues.apache.org/jira/browse/PHOENIX-4442
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Ethan Wang
>
> Rename system catalog INDEX_STATE to STATE so that this column can be used 
> for table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4408) Figure out Hadoop version compatibility

2017-12-07 Thread Karan Mehta (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283147#comment-16283147
 ] 

Karan Mehta commented on PHOENIX-4408:
--

PHOENIX-3752 removed the PhoenixMetricsSink. I think further cleanup is 
required to remove all the classes and complete dependency on MetricsSink.

> Figure out Hadoop version compatibility
> ---
>
> Key: PHOENIX-4408
> URL: https://issues.apache.org/jira/browse/PHOENIX-4408
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: Josh Elser
>Priority: Blocker
> Fix For: 5.0.0
>
>
> The 5.x-HBase-2.0 branch is presently incompatible with both Hadoop 2.7 and 
> Hadoop 3.0.
> This stems from PhoenixMetricsSink and LoggingSink both of which extend 
> MetricsSink from Hadoop. Hadoop leaks a commons-configuration class into a 
> method signature and changes the dependency across versions.
> This makes it extremely annoying to work around downstream (we would have to 
> create multiple maven modules to shim around this). We should figure out what 
> compatibility we want to have.  Post PHOENIX-4405, it's only Hadoop3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4372) Distribution of Apache Phoenix 4.13 for CDH 5.11.2

2017-12-07 Thread Flavio Pompermaier (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283136#comment-16283136
 ] 

Flavio Pompermaier commented on PHOENIX-4372:
-

One last request: when releasing the parcel is it a problem to release all the 
CDH jars also on maven central?


> Distribution of Apache Phoenix 4.13 for CDH 5.11.2
> --
>
> Key: PHOENIX-4372
> URL: https://issues.apache.org/jira/browse/PHOENIX-4372
> Project: Phoenix
>  Issue Type: Task
>Affects Versions: 4.13.0
>Reporter: Pedro Boado
>Assignee: Pedro Boado
>Priority: Minor
>  Labels: cdh
> Attachments: PHOENIX-4372-B-v1.patch, PHOENIX-4372-B-v2.patch, 
> PHOENIX-4372-v2.patch, PHOENIX-4372-v3.patch, PHOENIX-4372-v4.patch, 
> PHOENIX-4372-v5.patch, PHOENIX-4372-v6.patch, PHOENIX-4372-v7.patch, 
> PHOENIX-4372.patch
>
>
> Changes required on top of branch 4.13-HBase-1.2 for creating a parcel of 
> Apache Phoenix 4.13.0 for CDH 5.11.2 . 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4415) Ignore CURRENT_SCN property if set in Pig Storer

2017-12-07 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283070#comment-16283070
 ] 

Hudson commented on PHOENIX-4415:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1890 (See 
[https://builds.apache.org/job/Phoenix-master/1890/])
PHOENIX-4415 Ignore CURRENT_SCN property if set in Pig Storer (jtaylor: rev 
d6e61af807f7a4e605c61217bac556ffe00ea237)
* (edit) phoenix-pig/src/it/java/org/apache/phoenix/pig/BasePigIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixOutputFormat.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/util/PropertiesUtil.java
* (edit) 
phoenix-pig/src/main/java/org/apache/phoenix/pig/PhoenixHBaseStorage.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/ConnectionUtil.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixRecordWriter.java


> Ignore CURRENT_SCN property if set in Pig Storer
> 
>
> Key: PHOENIX-4415
> URL: https://issues.apache.org/jira/browse/PHOENIX-4415
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4415.patch, PHOENIX-4415_v2.patch, 
> PHOENIX-4415_v3.patch
>
>
> Phoenix does not support back-in-time writes, so to guard against that we'll 
> remove the CURRENT_SCN property if it's set in the job configuration in 
> PhoenixHBaseStorage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[ANNOUNCE] Apache Phoenix 4.13.1 released

2017-12-07 Thread James Taylor 
The Apache Phoenix team is pleased to announce the immediate availability
of the 4.13.1 release. Apache Phoenix enables SQL-based OLTP and
operational analytics for Apache Hadoop using Apache HBase as its backing
store and providing integration with other projects in the Apache ecosystem
such as Spark, Hive, Pig, Flume, and MapReduce. This releases is compatible
with HBase 0.98, 1.1, 1.2 and 1.3.

Highlights of the release include:

* Support again for HBase 1.1 and 1.2 due to community ask
* Inclusion of required server-side jars for new COLLATION_KEY function [1]

Source and binary downloads are available here [2]. Note that in the
future, releases will be done separately for each branches by dedicated
release managers. I'll send out an email on this soon.

Thanks,
James (on behalf of the Apache Phoenix team)

[1] https://issues.apache.org/jira/browse/PHOENIX-4384
[2] http://phoenix.apache.org/download.html

[jira] [Commented] (PHOENIX-4372) Distribution of Apache Phoenix 4.13 for CDH 5.11.2

2017-12-07 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282959#comment-16282959
 ] 

James Taylor commented on PHOENIX-4372:
---

I've committed your PHOENIX-4372-B-v2.patch to 4.x-cdh5.11.2 branch, but on a 
sub JIRA PHOENIX-. Let's create sub JIRAs for any additional work.

> Distribution of Apache Phoenix 4.13 for CDH 5.11.2
> --
>
> Key: PHOENIX-4372
> URL: https://issues.apache.org/jira/browse/PHOENIX-4372
> Project: Phoenix
>  Issue Type: Task
>Affects Versions: 4.13.0
>Reporter: Pedro Boado
>Assignee: Pedro Boado
>Priority: Minor
>  Labels: cdh
> Attachments: PHOENIX-4372-B-v1.patch, PHOENIX-4372-B-v2.patch, 
> PHOENIX-4372-v2.patch, PHOENIX-4372-v3.patch, PHOENIX-4372-v4.patch, 
> PHOENIX-4372-v5.patch, PHOENIX-4372-v6.patch, PHOENIX-4372-v7.patch, 
> PHOENIX-4372.patch
>
>
> Changes required on top of branch 4.13-HBase-1.2 for creating a parcel of 
> Apache Phoenix 4.13.0 for CDH 5.11.2 . 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (PHOENIX-4444) Build parcels in make_rc.sh

2017-12-07 Thread James Taylor (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PHOENIX-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor resolved PHOENIX-.
---
Resolution: Fixed

Pushed to 4.x-cdh5.11.2 branch

> Build parcels in make_rc.sh
> ---
>
> Key: PHOENIX-
> URL: https://issues.apache.org/jira/browse/PHOENIX-
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Pedro Boado
> Fix For: 4.13.2-cdh5.11.2
>
> Attachments: PHOENIX-_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PHOENIX-4444) Build parcels in make_rc.sh

2017-12-07 Thread James Taylor (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PHOENIX-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-:
--
Attachment: PHOENIX-_v2.patch

> Build parcels in make_rc.sh
> ---
>
> Key: PHOENIX-
> URL: https://issues.apache.org/jira/browse/PHOENIX-
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Pedro Boado
> Fix For: 4.13.2-cdh5.11.2
>
> Attachments: PHOENIX-_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (PHOENIX-4444) Build parcels in make_rc.sh

2017-12-07 Thread James Taylor (JIRA) 
James Taylor created PHOENIX-:
-

 Summary: Build parcels in make_rc.sh
 Key: PHOENIX-
 URL: https://issues.apache.org/jira/browse/PHOENIX-
 Project: Phoenix
  Issue Type: Sub-task
Reporter: James Taylor
Assignee: Pedro Boado
 Fix For: 4.13.2-cdh5.11.2






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4372) Distribution of Apache Phoenix 4.13 for CDH 5.11.2

2017-12-07 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282950#comment-16282950
 ] 

James Taylor commented on PHOENIX-4372:
---

Thanks, [~pboado]. As the RM for CDH releases, *you* get to decide what is a 
showstopper or not (with input from the community, of course). You also get to 
decide on the timing of the release. So really, it's up to you. If you decide 
it's a Windows only issue, you might decide the first CDH release doesn't need 
to work Windows. It seems that CDH doesn't support Windows in general [1], but 
perhaps the client can run on Windows?

FWIW, 4.13.1 has been released - I'll announce it shortly.

[1] 
https://www.cloudera.com/documentation/enterprise/release-notes/topics/rn_consolidated_pcm.html#concept_dcw_m5v_jz

> Distribution of Apache Phoenix 4.13 for CDH 5.11.2
> --
>
> Key: PHOENIX-4372
> URL: https://issues.apache.org/jira/browse/PHOENIX-4372
> Project: Phoenix
>  Issue Type: Task
>Affects Versions: 4.13.0
>Reporter: Pedro Boado
>Assignee: Pedro Boado
>Priority: Minor
>  Labels: cdh
> Attachments: PHOENIX-4372-B-v1.patch, PHOENIX-4372-B-v2.patch, 
> PHOENIX-4372-v2.patch, PHOENIX-4372-v3.patch, PHOENIX-4372-v4.patch, 
> PHOENIX-4372-v5.patch, PHOENIX-4372-v6.patch, PHOENIX-4372-v7.patch, 
> PHOENIX-4372.patch
>
>
> Changes required on top of branch 4.13-HBase-1.2 for creating a parcel of 
> Apache Phoenix 4.13.0 for CDH 5.11.2 . 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4434) UpgradeUtil.upgradeTable does not upgrade view index physical table of multi-tenant tables if there are no view indexes currently

2017-12-07 Thread Karan Mehta (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282838#comment-16282838
 ] 

Karan Mehta commented on PHOENIX-4434:
--

In particular, 2 cases need to be handled for multi-tenant tables
1. There are views but no view indexes present
2. There are no views.

We need to migrate the view Index table to corresponding namespace in both the 
cases.

> UpgradeUtil.upgradeTable does not upgrade view index physical table of 
> multi-tenant tables if there are no view indexes currently
> -
>
> Key: PHOENIX-4434
> URL: https://issues.apache.org/jira/browse/PHOENIX-4434
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Thomas D'Silva
>
> We pre-create the physical view index table for multi-tenant tables at 
> creation time. 
> The following code does not handle this case
> {code}
>// check whether table is properly upgraded before upgrading indexes
> if (table.isNamespaceMapped()) {
> for (PTable index : table.getIndexes()) {
> String srcTableName = index.getPhysicalName().getString();
> String destTableName = null;
> String phoenixTableName = index.getName().getString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4424) Allow users to create "DEFAULT" and "HBASE" Schema (Uppercase Schema Names)

2017-12-07 Thread Thomas D'Silva (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282769#comment-16282769
 ] 

Thomas D'Silva commented on PHOENIX-4424:
-

+1 LGTM

> Allow users to create "DEFAULT" and "HBASE" Schema (Uppercase Schema Names)
> ---
>
> Key: PHOENIX-4424
> URL: https://issues.apache.org/jira/browse/PHOENIX-4424
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Karan Mehta
>Assignee: Karan Mehta
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4424.001.patch, PHOENIX-4424.002.patch
>
>
> We currently block users to create "DEFAULT" and "HBASE" schema, however it 
> should be actually "default" and "hbase" since hbase namespace is case 
> sensitive. Hence we should update it and allow is users want to create 
> schema's with those names.
> If user wants to access the schema names with capital letters, they can pass 
> it in directly (Phoenix will automatically upper-case it) or pass it in 
> uppercase letters with double-quotes.
> FYI.
> [~twdsi...@gmail.com]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PHOENIX-4424) Allow users to create "DEFAULT" and "HBASE" Schema (Uppercase Schema Names)

2017-12-07 Thread Thomas D'Silva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PHOENIX-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas D'Silva updated PHOENIX-4424:

Fix Version/s: 4.14.0

> Allow users to create "DEFAULT" and "HBASE" Schema (Uppercase Schema Names)
> ---
>
> Key: PHOENIX-4424
> URL: https://issues.apache.org/jira/browse/PHOENIX-4424
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Karan Mehta
>Assignee: Karan Mehta
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4424.001.patch, PHOENIX-4424.002.patch
>
>
> We currently block users to create "DEFAULT" and "HBASE" schema, however it 
> should be actually "default" and "hbase" since hbase namespace is case 
> sensitive. Hence we should update it and allow is users want to create 
> schema's with those names.
> If user wants to access the schema names with capital letters, they can pass 
> it in directly (Phoenix will automatically upper-case it) or pass it in 
> uppercase letters with double-quotes.
> FYI.
> [~twdsi...@gmail.com]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread Ethan Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282766#comment-16282766
 ] 

Ethan Wang commented on PHOENIX-4442:
-

[~vincentpoon]  I see. So this replication process is it like a back up 
replication?(master master replication?) Hbase in itself does not replicate 
unless it's hdfs level.

> Rename system catalog INDEX_STATE to STATE
> --
>
> Key: PHOENIX-4442
> URL: https://issues.apache.org/jira/browse/PHOENIX-4442
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Ethan Wang
>
> Rename system catalog INDEX_STATE to STATE so that this column can be used 
> for table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread Ethan Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282690#comment-16282690
 ] 

Ethan Wang commented on PHOENIX-4442:
-

[~vincentpoon] I see. 
bq. That way queued replication edits could continue to drain at the HBase 
level on the destination, after which the table could be dropped.

regarding that, I think we may also use hbase pre-disable table hook. Actually, 
if I understand right, even you immediately drop a table from HBase, it still 
has to go through "this draining process", which will slowly replay the 
remaining WAL(since already ack-ed) and flush them. Is that already the case?

> Rename system catalog INDEX_STATE to STATE
> --
>
> Key: PHOENIX-4442
> URL: https://issues.apache.org/jira/browse/PHOENIX-4442
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Ethan Wang
>
> Rename system catalog INDEX_STATE to STATE so that this column can be used 
> for table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282705#comment-16282705
 ] 

Vincent Poon commented on PHOENIX-4442:
---

[~aertoria] I think the concern is with the destination, not the source.  If we 
drop the table at the destination, the source will get an exception when trying 
to replicate to the destination.  Without HBASE-12091, the queue on the source 
will just stay undrained because it will keep retrying indefinitely.

> Rename system catalog INDEX_STATE to STATE
> --
>
> Key: PHOENIX-4442
> URL: https://issues.apache.org/jira/browse/PHOENIX-4442
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Ethan Wang
>
> Rename system catalog INDEX_STATE to STATE so that this column can be used 
> for table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282662#comment-16282662
 ] 

Vincent Poon commented on PHOENIX-4442:
---

If we have HBASE-12091 , then I don't think having a column is as important.  I 
think the original motivation for this feature was to have a column value 
represent a table being disabled at the Phoenix level, but still be active at 
the HBase level.  That way queued replication edits could continue to drain at 
the HBase level on the destination, after which the table could be dropped.  
With HBASE-12091, the queued replication edits don't matter anymore if the 
table is dropped on the destination.

If we don't want to wait for HBASE-12091 and need something now, then I say we 
just add a new column.  The existing INDEX_STATE relies on some delicate state 
transitions and we made a lot of improvements to ensure the state is always 
correct.  Adding in new states would potentially throw a monkey wrench into all 
of that.

> Rename system catalog INDEX_STATE to STATE
> --
>
> Key: PHOENIX-4442
> URL: https://issues.apache.org/jira/browse/PHOENIX-4442
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Ethan Wang
>
> Rename system catalog INDEX_STATE to STATE so that this column can be used 
> for table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282539#comment-16282539
 ] 

James Taylor commented on PHOENIX-4442:
---

That's a fair comment, [~vincentpoon]. Do you think we should represent in 
SYSTEM.CATALOG that a table is disabled? An alternative would be to just have 
the Phoenix API disable the HBase table and let any subsequent queries/DML 
operations fail.

> Rename system catalog INDEX_STATE to STATE
> --
>
> Key: PHOENIX-4442
> URL: https://issues.apache.org/jira/browse/PHOENIX-4442
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Ethan Wang
>
> Rename system catalog INDEX_STATE to STATE so that this column can be used 
> for table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-3837) Unable to set property on an index with Alter statement

2017-12-07 Thread Ethan Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282440#comment-16282440
 ] 

Ethan Wang commented on PHOENIX-3837:
-

Patch has been committed to 
4.x-0.98 (PHOENIX-3837.patch)
master (PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch)

[~tdsilva]

> Unable to set property on an index with Alter statement
> ---
>
> Key: PHOENIX-3837
> URL: https://issues.apache.org/jira/browse/PHOENIX-3837
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.10.0
>Reporter: Mujtaba Chohan
>Assignee: Ethan Wang
> Fix For: 4.14.0
>
> Attachments: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch, 
> PHOENIX-3837.patch
>
>
> {{ALTER INDEX IDX_T ON T SET GUIDE_POSTS_WIDTH=1}}
> {noformat}
> Error: ERROR 601 (42P00): Syntax error. Encountered "SET" at line 1, column 
> 102. (state=42P00,code=601)
> org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00): 
> Syntax error. Encountered "SET" at line 1, column 102.
> at 
> org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
> at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111)
> at 
> org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (PHOENIX-3837) Unable to set property on an index with Alter statement

2017-12-07 Thread Ethan Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1628#comment-1628
 ] 

Ethan Wang edited comment on PHOENIX-3837 at 12/7/17 8:02 PM:
--

PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch

Fetched and merged the latest changes so that it is appliable on master branch.


was (Author: aertoria):
PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch

Fetched and merged the latest changes so that it is appliable on 5.x-2.0 and 
master branch. 

> Unable to set property on an index with Alter statement
> ---
>
> Key: PHOENIX-3837
> URL: https://issues.apache.org/jira/browse/PHOENIX-3837
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.10.0
>Reporter: Mujtaba Chohan
>Assignee: Ethan Wang
> Fix For: 4.14.0
>
> Attachments: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch, 
> PHOENIX-3837.patch
>
>
> {{ALTER INDEX IDX_T ON T SET GUIDE_POSTS_WIDTH=1}}
> {noformat}
> Error: ERROR 601 (42P00): Syntax error. Encountered "SET" at line 1, column 
> 102. (state=42P00,code=601)
> org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00): 
> Syntax error. Encountered "SET" at line 1, column 102.
> at 
> org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
> at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111)
> at 
> org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-3837) Unable to set property on an index with Alter statement

2017-12-07 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282425#comment-16282425
 ] 

Hudson commented on PHOENIX-3837:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1889 (See 
[https://builds.apache.org/job/Phoenix-master/1889/])
PHOENIX-3837 Feature enabling to set property on an index with Alter (castives: 
rev 1c3387d0eb2fcec2423dda029aa65ca66f547416)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/parse/AlterIndexStatement.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/parse/AddColumnStatement.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) phoenix-core/src/main/antlr3/PhoenixSQL.g
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServices.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java


> Unable to set property on an index with Alter statement
> ---
>
> Key: PHOENIX-3837
> URL: https://issues.apache.org/jira/browse/PHOENIX-3837
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.10.0
>Reporter: Mujtaba Chohan
>Assignee: Ethan Wang
> Fix For: 4.14.0
>
> Attachments: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch, 
> PHOENIX-3837.patch
>
>
> {{ALTER INDEX IDX_T ON T SET GUIDE_POSTS_WIDTH=1}}
> {noformat}
> Error: ERROR 601 (42P00): Syntax error. Encountered "SET" at line 1, column 
> 102. (state=42P00,code=601)
> org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00): 
> Syntax error. Encountered "SET" at line 1, column 102.
> at 
> org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
> at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111)
> at 
> org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-3837) Unable to set property on an index with Alter statement

2017-12-07 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282420#comment-16282420
 ] 

Hadoop QA commented on PHOENIX-3837:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12901107/PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch
  against master branch at commit ee728a4d19c004ad456b24cd228fb2351362472d.
  ATTACHMENT ID: 12901107

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET GUIDE_POSTS_WIDTH = 10");
+"select GUIDE_POSTS_WIDTH from SYSTEM.\"CATALOG\" where 
TABLE_NAME='" + indexName + "'");assertTrue(rs.next());
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET GUIDE_POSTS_WIDTH = 20");
+"select GUIDE_POSTS_WIDTH from SYSTEM.\"CATALOG\" where 
TABLE_NAME='" + indexName + "'");assertTrue(rs.next());
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET DISABLE_WAL=false");
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET DISABLE_WAL=true");
+private static void asssertIsWALDisabled(Connection conn, String 
fullTableName, boolean expectedValue) throws SQLException {
+assertEquals(expectedValue, pconn.getTable(new 
PTableKey(pconn.getTenantId(), fullTableName)).isWALDisabled());
+  ((s=(USABLE | UNUSABLE | REBUILD | DISABLE | ACTIVE)) (async=ASYNC)? 
((SET?)p=fam_properties)?)
+  {ret = factory.alterIndex(factory.namedTable(null, 
TableName.create(t.getSchemaName(), i.getName())), t.getTableName(), ex!=null, 
PIndexState.valueOf(SchemaUtil.normalizeIdentifier(s.getText())), async!=null, 
p); }

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1656//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1656//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1656//console

This message is automatically generated.

> Unable to set property on an index with Alter statement
> ---
>
> Key: PHOENIX-3837
> URL: https://issues.apache.org/jira/browse/PHOENIX-3837
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.10.0
>Reporter: Mujtaba Chohan
>Assignee: Ethan Wang
> Fix For: 4.14.0
>
> Attachments: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch, 
> PHOENIX-3837.patch
>
>
> {{ALTER INDEX IDX_T ON T SET GUIDE_POSTS_WIDTH=1}}
> {noformat}
> Error: ERROR 601 (42P00): Syntax error. Encountered "SET" at line 1, column 
> 102. (state=42P00,code=601)
> org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00): 
> Syntax error. Encountered "SET" at line 1, column 102.
> at 
> org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
> at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111)
> at 
> org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-3837) Unable to set property on an index with Alter statement

2017-12-07 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282413#comment-16282413
 ] 

Hadoop QA commented on PHOENIX-3837:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12901107/PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch
  against master branch at commit ee728a4d19c004ad456b24cd228fb2351362472d.
  ATTACHMENT ID: 12901107

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET GUIDE_POSTS_WIDTH = 10");
+"select GUIDE_POSTS_WIDTH from SYSTEM.\"CATALOG\" where 
TABLE_NAME='" + indexName + "'");assertTrue(rs.next());
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET GUIDE_POSTS_WIDTH = 20");
+"select GUIDE_POSTS_WIDTH from SYSTEM.\"CATALOG\" where 
TABLE_NAME='" + indexName + "'");assertTrue(rs.next());
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET DISABLE_WAL=false");
+conn.createStatement().execute("ALTER INDEX "+indexName+" ON " + 
testTable +" ACTIVE SET DISABLE_WAL=true");
+private static void asssertIsWALDisabled(Connection conn, String 
fullTableName, boolean expectedValue) throws SQLException {
+assertEquals(expectedValue, pconn.getTable(new 
PTableKey(pconn.getTenantId(), fullTableName)).isWALDisabled());
+  ((s=(USABLE | UNUSABLE | REBUILD | DISABLE | ACTIVE)) (async=ASYNC)? 
((SET?)p=fam_properties)?)
+  {ret = factory.alterIndex(factory.namedTable(null, 
TableName.create(t.getSchemaName(), i.getName())), t.getTableName(), ex!=null, 
PIndexState.valueOf(SchemaUtil.normalizeIdentifier(s.getText())), async!=null, 
p); }

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ContextClassloaderIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1657//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1657//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1657//console

This message is automatically generated.

> Unable to set property on an index with Alter statement
> ---
>
> Key: PHOENIX-3837
> URL: https://issues.apache.org/jira/browse/PHOENIX-3837
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.10.0
>Reporter: Mujtaba Chohan
>Assignee: Ethan Wang
> Fix For: 4.14.0
>
> Attachments: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch, 
> PHOENIX-3837.patch
>
>
> {{ALTER INDEX IDX_T ON T SET GUIDE_POSTS_WIDTH=1}}
> {noformat}
> Error: ERROR 601 (42P00): Syntax error. Encountered "SET" at line 1, column 
> 102. (state=42P00,code=601)
> org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00): 
> Syntax error. Encountered "SET" at line 1, column 102.
> at 
> org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
> at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111)
> at 
> org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282361#comment-16282361
 ] 

Vincent Poon commented on PHOENIX-4442:
---

I don't know if this is a good idea - it might be confusing as indexes have 
additional states such as "rebuild", "building", etc.  The refactoring in the 
codebase would be a mess if we were to rename PIndexState, and would make the 
code less readable.  Furthermore an index name doesn't always map directly to a 
table name, in some cases it's just a logical name that maps to a physical 
table.  I don't see much gain from reusing this column, versus the cost of 
making the code less clear.

> Rename system catalog INDEX_STATE to STATE
> --
>
> Key: PHOENIX-4442
> URL: https://issues.apache.org/jira/browse/PHOENIX-4442
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Ethan Wang
>
> Rename system catalog INDEX_STATE to STATE so that this column can be used 
> for table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (PHOENIX-4443) Documentation for Alter property on index feature

2017-12-07 Thread Ethan Wang (JIRA) 
Ethan Wang created PHOENIX-4443:
---

 Summary: Documentation for Alter property on index feature
 Key: PHOENIX-4443
 URL: https://issues.apache.org/jira/browse/PHOENIX-4443
 Project: Phoenix
  Issue Type: Improvement
Reporter: Ethan Wang
Assignee: Ethan Wang


Documentation for Alter property on index feature



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE

2017-12-07 Thread Ethan Wang (JIRA) 
Ethan Wang created PHOENIX-4442:
---

 Summary: Rename system catalog INDEX_STATE to STATE
 Key: PHOENIX-4442
 URL: https://issues.apache.org/jira/browse/PHOENIX-4442
 Project: Phoenix
  Issue Type: Improvement
Reporter: Ethan Wang


Rename system catalog INDEX_STATE to STATE so that this column can be used for 
table as well



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (PHOENIX-4386) Calculate the estimatedSize of MutationState using Map<TableRef, Map<ImmutableBytesPtr,RowMutationState>> mutations

2017-12-07 Thread Thomas D'Silva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PHOENIX-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas D'Silva resolved PHOENIX-4386.
-
Resolution: Fixed

> Calculate the estimatedSize of MutationState using Map Map> mutations
> ---
>
> Key: PHOENIX-4386
> URL: https://issues.apache.org/jira/browse/PHOENIX-4386
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Thomas D'Silva
>Assignee: Thomas D'Silva
> Attachments: PHOENIX-4386-addendum-0.98.patch, 
> PHOENIX-4386-addendum-master.patch, PHOENIX-4386.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PHOENIX-4386) Calculate the estimatedSize of MutationState using Map<TableRef, Map<ImmutableBytesPtr,RowMutationState>> mutations

2017-12-07 Thread Thomas D'Silva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PHOENIX-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas D'Silva updated PHOENIX-4386:

Fix Version/s: 4.14.0

> Calculate the estimatedSize of MutationState using Map Map> mutations
> ---
>
> Key: PHOENIX-4386
> URL: https://issues.apache.org/jira/browse/PHOENIX-4386
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Thomas D'Silva
>Assignee: Thomas D'Silva
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4386-addendum-0.98.patch, 
> PHOENIX-4386-addendum-master.patch, PHOENIX-4386.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PHOENIX-3837) Unable to set property on an index with Alter statement

2017-12-07 Thread Ethan Wang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PHOENIX-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ethan Wang updated PHOENIX-3837:

Attachment: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch

PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch

Fetched and merged the latest changes so that it is appliable on 5.x-2.0 and 
master branch. 

> Unable to set property on an index with Alter statement
> ---
>
> Key: PHOENIX-3837
> URL: https://issues.apache.org/jira/browse/PHOENIX-3837
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.10.0
>Reporter: Mujtaba Chohan
>Assignee: Ethan Wang
> Fix For: 4.14.0
>
> Attachments: PHOENIX-3837-Merged_With_5.x-2.0-and-Master.patch, 
> PHOENIX-3837.patch
>
>
> {{ALTER INDEX IDX_T ON T SET GUIDE_POSTS_WIDTH=1}}
> {noformat}
> Error: ERROR 601 (42P00): Syntax error. Encountered "SET" at line 1, column 
> 102. (state=42P00,code=601)
> org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00): 
> Syntax error. Encountered "SET" at line 1, column 102.
> at 
> org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
> at org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111)
> at 
> org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4441) Reflect changes that were made recently in HBase branch-2

2017-12-07 Thread Sergey Soldatov (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282228#comment-16282228
 ] 

Sergey Soldatov commented on PHOENIX-4441:
--

[~anoop.hbase] thank you for jumping in. This code can be found at
https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixIndexBuilder.java#L108
Actually, that's for our internal usage, so I think we may workaround it as we 
already did for the others configuration changes. 

> Reflect changes that were made recently in HBase branch-2 
> --
>
> Key: PHOENIX-4441
> URL: https://issues.apache.org/jira/browse/PHOENIX-4441
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
>  Labels: HBase-2.0
> Fix For: 5.0.0
>
> Attachments: PHOENIX-4441.patch
>
>
> There were several changes that break our build:
> HBASE-19417. Changed method signature in RegionObserver
> HBASE-19430. Removed setTimestamp(byte[], int)  method from ExtendedCell.
> Also, there is another problem - configuration on coprocessor env is now 
> read-only, so we need to find out a way to set index failure policy for index 
> coprocessor. Will cover in a separate jira. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4406) Add option to disable tables when dropped

2017-12-07 Thread Alex Araujo (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282174#comment-16282174
 ] 

Alex Araujo commented on PHOENIX-4406:
--

Adding DISABLE/ENABLE syntax ties into HBase semantics nicely. The disadvantage 
is that end users have to roll out a DROP in two steps (DISABLE then a DROP). 
Another option could be to only rollout the DISABLE command and have a cleanup 
job do the rest.
It would still be good to have an option to disallow DROP commands for tables 
that have not been disabled to avoid replication issues.

> Add option to disable tables when dropped
> -
>
> Key: PHOENIX-4406
> URL: https://issues.apache.org/jira/browse/PHOENIX-4406
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Alex Araujo
>Assignee: Ethan Wang
>Priority: Critical
>
> Phoenix client applications can drop tables when HBase replication is 
> actively shipping edits.
> Add an option to disable the table in Phoenix's metadata when a DROP TABLE is 
> issued.
> This will allow the HBase table to be dropped by admin actions when it's safe 
> to do so.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4441) Reflect changes that were made recently in HBase branch-2

2017-12-07 Thread Anoop Sam John (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281636#comment-16281636
 ] 

Anoop Sam John commented on PHOENIX-4441:
-

bq. so we need to find out a way to set index failure policy for index 
coprocessor
Where is this code of setting config ?

> Reflect changes that were made recently in HBase branch-2 
> --
>
> Key: PHOENIX-4441
> URL: https://issues.apache.org/jira/browse/PHOENIX-4441
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
>  Labels: HBase-2.0
> Fix For: 5.0.0
>
> Attachments: PHOENIX-4441.patch
>
>
> There were several changes that break our build:
> HBASE-19417. Changed method signature in RegionObserver
> HBASE-19430. Removed setTimestamp(byte[], int)  method from ExtendedCell.
> Also, there is another problem - configuration on coprocessor env is now 
> read-only, so we need to find out a way to set index failure policy for index 
> coprocessor. Will cover in a separate jira. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (PHOENIX-4398) Change QueryCompiler get column expressions process from serial to parallel.

2017-12-07 Thread Albert Lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281553#comment-16281553
 ] 

Albert Lee edited comment on PHOENIX-4398 at 12/7/17 9:30 AM:
--

./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexReplicationIT

This two UnitTests can pass in my evniroment. Is QA have something wrong at 
that time?


was (Author: albertlee...@gmail.com):
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexReplicationIT

> Change QueryCompiler get column expressions process from serial to parallel.
> 
>
> Key: PHOENIX-4398
> URL: https://issues.apache.org/jira/browse/PHOENIX-4398
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.11.0, 4.13.0
>Reporter: Albert Lee
> Fix For: 4.11.0, 4.13.0
>
> Attachments: PHOENIX-4398.patch
>
>
> When QueryCompiler compile a select sql, the process of getting column 
> expressions is a serial process. The performance is ok when the table is 
> narrow. But when compile a wide table(e.g. 130 columns in my use case), The 
> time-consuming of this step is very high, over 70ms. So I change 
> TupleProjector(PTable projectedTable) from serial for loop to parallel future.
> Because this is just modify code performance, not add new feture, so there is 
> no unit test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4398) Change QueryCompiler get column expressions process from serial to parallel.

2017-12-07 Thread Albert Lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281553#comment-16281553
 ] 

Albert Lee commented on PHOENIX-4398:
-

./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexReplicationIT

> Change QueryCompiler get column expressions process from serial to parallel.
> 
>
> Key: PHOENIX-4398
> URL: https://issues.apache.org/jira/browse/PHOENIX-4398
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.11.0, 4.13.0
>Reporter: Albert Lee
> Fix For: 4.11.0, 4.13.0
>
> Attachments: PHOENIX-4398.patch
>
>
> When QueryCompiler compile a select sql, the process of getting column 
> expressions is a serial process. The performance is ok when the table is 
> narrow. But when compile a wide table(e.g. 130 columns in my use case), The 
> time-consuming of this step is very high, over 70ms. So I change 
> TupleProjector(PTable projectedTable) from serial for loop to parallel future.
> Because this is just modify code performance, not add new feture, so there is 
> no unit test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4441) Reflect changes that were made recently in HBase branch-2

2017-12-07 Thread Ankit Singhal (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281533#comment-16281533
 ] 

Ankit Singhal commented on PHOENIX-4441:


+1 [~sergey.soldatov]

> Reflect changes that were made recently in HBase branch-2 
> --
>
> Key: PHOENIX-4441
> URL: https://issues.apache.org/jira/browse/PHOENIX-4441
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
>  Labels: HBase-2.0
> Fix For: 5.0.0
>
> Attachments: PHOENIX-4441.patch
>
>
> There were several changes that break our build:
> HBASE-19417. Changed method signature in RegionObserver
> HBASE-19430. Removed setTimestamp(byte[], int)  method from ExtendedCell.
> Also, there is another problem - configuration on coprocessor env is now 
> read-only, so we need to find out a way to set index failure policy for index 
> coprocessor. Will cover in a separate jira. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4441) Reflect changes that were made recently in HBase branch-2

2017-12-07 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281527#comment-16281527
 ] 

Hadoop QA commented on PHOENIX-4441:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12901017/PHOENIX-4441.patch
  against master branch at commit ee728a4d19c004ad456b24cd228fb2351362472d.
  ATTACHMENT ID: 12901017

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1655//console

This message is automatically generated.

> Reflect changes that were made recently in HBase branch-2 
> --
>
> Key: PHOENIX-4441
> URL: https://issues.apache.org/jira/browse/PHOENIX-4441
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
>  Labels: HBase-2.0
> Fix For: 5.0.0
>
> Attachments: PHOENIX-4441.patch
>
>
> There were several changes that break our build:
> HBASE-19417. Changed method signature in RegionObserver
> HBASE-19430. Removed setTimestamp(byte[], int)  method from ExtendedCell.
> Also, there is another problem - configuration on coprocessor env is now 
> read-only, so we need to find out a way to set index failure policy for index 
> coprocessor. Will cover in a separate jira. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4372) Distribution of Apache Phoenix 4.13 for CDH 5.11.2

2017-12-07 Thread Pedro Boado (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281486#comment-16281486
 ] 

Pedro Boado commented on PHOENIX-4372:
--

I'll try to reproduce both issues (and fix them if needed) as soon as I have 
some time left. 5.13.1 has to be released first, so I have a couple of more 
days, right? 

> Distribution of Apache Phoenix 4.13 for CDH 5.11.2
> --
>
> Key: PHOENIX-4372
> URL: https://issues.apache.org/jira/browse/PHOENIX-4372
> Project: Phoenix
>  Issue Type: Task
>Affects Versions: 4.13.0
>Reporter: Pedro Boado
>Assignee: Pedro Boado
>Priority: Minor
>  Labels: cdh
> Attachments: PHOENIX-4372-B-v1.patch, PHOENIX-4372-B-v2.patch, 
> PHOENIX-4372-v2.patch, PHOENIX-4372-v3.patch, PHOENIX-4372-v4.patch, 
> PHOENIX-4372-v5.patch, PHOENIX-4372-v6.patch, PHOENIX-4372-v7.patch, 
> PHOENIX-4372.patch
>
>
> Changes required on top of branch 4.13-HBase-1.2 for creating a parcel of 
> Apache Phoenix 4.13.0 for CDH 5.11.2 . 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)