[jira] [Updated] (PHOENIX-5676) Inline-verification from IndexTool does not handle TTL/row-expiry

2020-01-14 Thread Abhishek Singh Chouhan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Singh Chouhan updated PHOENIX-5676: Attachment: PHOENIX-5676-4.x-HBase-1.5.patch > Inline-verification from

[jira] [Created] (PHOENIX-5682) IndexTool can just update empty_column with verified if rest of index row matches

2020-01-14 Thread Priyank Porwal (Jira)
Priyank Porwal created PHOENIX-5682: --- Summary: IndexTool can just update empty_column with verified if rest of index row matches Key: PHOENIX-5682 URL: https://issues.apache.org/jira/browse/PHOENIX-5682

[jira] [Updated] (PHOENIX-5674) IndexTool to not write already correct index rows

2020-01-14 Thread Priyank Porwal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priyank Porwal updated PHOENIX-5674: Summary: IndexTool to not write already correct index rows (was: IndexTool to not write

[jira] [Updated] (PHOENIX-5674) IndexTool to not write already correct index rows/CFs

2020-01-14 Thread Priyank Porwal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priyank Porwal updated PHOENIX-5674: Description: IndexTool can avoid writing index rows if they are already consistent with

[jira] [Resolved] (PHOENIX-5680) remove psql.py from phoenix-queryserver

2020-01-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth resolved PHOENIX-5680. -- Fix Version/s: 5.1.0 Resolution: Fixed Merged. Thanks for the review [~elserj] >

[jira] [Updated] (PHOENIX-5656) Make Phoenix scripts work with Python 3

2020-01-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated PHOENIX-5656: --- Attachment: 5656-4.x-HBase-1.5-v4.txt > Make Phoenix scripts work with Python 3 >

[jira] [Assigned] (PHOENIX-1295) Add testing utility for table creation, population, and checking query results

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned PHOENIX-1295: - Assignee: (was: Viraj Jasani) > Add testing utility for table creation,

Re: Committers please look at the Phoenix tests and fix your failures

2020-01-14 Thread James Taylor
How about we require the tests to pass as a prerequisite for commit? On Tue, Jan 14, 2020 at 3:16 PM la...@apache.org wrote: > And I cannot stress enough how important this is for the project. As an > example: We had the tests fail for just a few days, during that time we > have had check-ins

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: PHOENIX-5678.master.000.patch > Cleanup anonymous inner classes used for

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: (was: PHOENIX-5678.master.000.patch) > Cleanup anonymous inner classes used

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: (was: PHOENIX-5678.master.000.patch) > Cleanup anonymous inner classes used

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: (was: PHOENIX-5678.master.000.patch) > Cleanup anonymous inner classes used

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: PHOENIX-5678.master.000.patch > Cleanup anonymous inner classes used for

[jira] [Updated] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated PHOENIX-5645: - Attachment: PHOENIX-5645-4.14-HBase-1.4.patch > BaseScannerRegionObserver should

[jira] [Updated] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated PHOENIX-5645: - Attachment: PHOENIX-5645-addendum-4.x-HBase-1.5.patch > BaseScannerRegionObserver

Re: Moving Phoenix master to Hbase 2.2

2020-01-14 Thread Andrew Purtell
Take PhoenixAccessController as an example. Over time the HBase interfaces change in minor ways. You’ll need different compilation units for this class to be able to compile it across a wide range of 1.x. However the essential Phoenix functionality does not change. The logic that makes up the

Re: Moving Phoenix master to Hbase 2.2

2020-01-14 Thread Andrew Purtell
It’s not necessary to abstract the HBase interfaces into a compatibility layer, at least not to start. At each bump from one minor release to another a fix up typically touches a handful of files. The jump from 1.x to 2.x is a bigger deal but maybe there should still be separate branches for

[jira] [Reopened] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swaroopa Kadam reopened PHOENIX-5644: - > IndexUpgradeTool should sleep only once if there is at least one immutable > table

[jira] [Assigned] (PHOENIX-1295) Add testing utility for table creation, population, and checking query results

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned PHOENIX-1295: - Assignee: Viraj Jasani > Add testing utility for table creation, population, and

Re: Python2 EOL

2020-01-14 Thread Josh Elser
Ah, that would make sense. Thanks Gabriel. I can't say I've seen much adoption of Phoenix on Windows. The folks I have seen using it either via the JDBC driver we provide, or the ODBC driver from Simba. On 1/14/20 2:29 AM, Gabriel Reid wrote: My recollection (or maybe it was just my

Re: Moving Phoenix master to Hbase 2.2

2020-01-14 Thread Josh Elser
Still not having looked at what Tephra does -- I'm intrigued by what Istvan has in-progress. Waiting to see what he comes up with would be my suggestion :) On 1/14/20 1:12 PM, la...@apache.org wrote: Does somebody volunteer to take this up? I can see whether I can a resource where I work,

[jira] [Updated] (PHOENIX-5265) [UMBRELLA] Phoenix Test should use gold files for result comparison instead of using hard-corded comparison.

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5265: -- Summary: [UMBRELLA] Phoenix Test should use gold files for result comparison instead of

[jira] [Updated] (PHOENIX-5265) (Umbrella)Phoenix Test should use gold files for result comparison instead of using hard-corded comparison.

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5265: -- Summary: (Umbrella)Phoenix Test should use gold files for result comparison instead of using

[jira] [Updated] (PHOENIX-5674) IndexTool to not write already correct index rows/CFs

2020-01-14 Thread Kadir OZDEMIR (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kadir OZDEMIR updated PHOENIX-5674: --- Attachment: PHOENIX-5674.master.001.patch > IndexTool to not write already correct index

Re: Committers please look at the Phoenix tests and fix your failures

2020-01-14 Thread la...@apache.org
And I cannot stress enough how important this is for the project. As an example: We had the tests fail for just a few days, during that time we have had check-ins that broke other test; now it's quite hard to figure out which recent change broke the other tests. We need the test suite *always*

[jira] [Assigned] (PHOENIX-5265) Phoenix Test should use gold files for result comparison instead of using hard-corded comparison.

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned PHOENIX-5265: - Assignee: Viraj Jasani > Phoenix Test should use gold files for result comparison

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: PHOENIX-5678.master.000.patch > Cleanup anonymous inner classes used for

[jira] [Updated] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated PHOENIX-5645: - Description: Phoenix's SCN feature has some problems, because HBase major compaction

[jira] [Updated] (PHOENIX-5636) Improve the error message when client connects to server with higher major version

2020-01-14 Thread Christine Feng (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Feng updated PHOENIX-5636: Attachment: PHOENIX-5636.master.v4.patch > Improve the error message when client

[jira] [Updated] (PHOENIX-5630) MAX_MUTATION_SIZE_EXCEEDED and MAX_MUTATION_SIZE_BYTES_EXCEEDED SQLExceptions should print existing size

2020-01-14 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated PHOENIX-5630: -- Priority: Minor (was: Major) > MAX_MUTATION_SIZE_EXCEEDED and

[jira] [Updated] (PHOENIX-5671) Add tests for ViewUtil

2020-01-14 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated PHOENIX-5671: --- Attachment: (was: PHOENIX-5671.patch) > Add tests for ViewUtil > -- > >

[jira] [Updated] (PHOENIX-5671) Add tests for ViewUtil

2020-01-14 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated PHOENIX-5671: --- Attachment: PHOENIX-5671.patch > Add tests for ViewUtil > -- > >

[jira] [Updated] (PHOENIX-5681) SYSCAT VIEW_STATEMENT column in doesn't store entire DDL for VIEW

2020-01-14 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated PHOENIX-5681: --- Priority: Minor (was: Major) > SYSCAT VIEW_STATEMENT column in doesn't store entire DDL for VIEW

[jira] [Created] (PHOENIX-5681) SYSCAT VIEW_STATEMENT column in doesn't store entire DDL for VIEW

2020-01-14 Thread Xinyi Yan (Jira)
Xinyi Yan created PHOENIX-5681: -- Summary: SYSCAT VIEW_STATEMENT column in doesn't store entire DDL for VIEW Key: PHOENIX-5681 URL: https://issues.apache.org/jira/browse/PHOENIX-5681 Project: Phoenix

[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time

2020-01-14 Thread Nitesh Maheshwari (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Affects Version/s: 5.1.0 > Use 'phoenix.default.update.cache.frequency' from

[jira] [Updated] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time

2020-01-14 Thread Nitesh Maheshwari (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitesh Maheshwari updated PHOENIX-5634: --- Fix Version/s: 5.1.0 > Use 'phoenix.default.update.cache.frequency' from

Re: Moving Phoenix master to Hbase 2.2

2020-01-14 Thread la...@apache.org
Does somebody volunteer to take this up? I can see whether I can a resource where I work, but it's highly uncertain. It would need a bit of digging and design work to see how we would abstract the HBase interface in the most effective way. As mentioned below, Tephra did a good job at this and

[jira] [Updated] (PHOENIX-5677) Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code

2020-01-14 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated PHOENIX-5677: - Attachment: PHOENIX-5677-4.x-HBase-1.3.patch > Replace System.currentTimeMillis with

Re: Committers please look at the Phoenix tests and fix your failures

2020-01-14 Thread la...@apache.org
I spent a lot of time making QA better. It can be better, but it's stable enough. There're now very little excuses. "Test failure seems unrelated" is not an excuse anymore.(4.x-HBase-1.3 has some issue where HBase can't seem to start a cluster reliably... but all others are pretty stable.)

[jira] [Updated] (PHOENIX-5601) Add a new Coprocessor - ViewTTLAware Coprocessor

2020-01-14 Thread Jacob Isaac (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Isaac updated PHOENIX-5601: - Attachment: PHOENIX-5601.master.001.patch > Add a new Coprocessor - ViewTTLAware Coprocessor >

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: PHOENIX-5678.master.000.patch > Cleanup anonymous inner classes used for

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: (was: PHOENIX-5678.master.000.patch) > Cleanup anonymous inner classes used

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: (was: PHOENIX-5678.master.000.patch) > Cleanup anonymous inner classes used

[jira] [Updated] (PHOENIX-5680) remove psql.py from phoenix-queryserver

2020-01-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated PHOENIX-5680: - Description: The phoenix-queryserver repo duplicates the bin/psql.py file from the core

[jira] [Created] (PHOENIX-5680) remove psql.py from phoenix-queryserver

2020-01-14 Thread Istvan Toth (Jira)
Istvan Toth created PHOENIX-5680: Summary: remove psql.py from phoenix-queryserver Key: PHOENIX-5680 URL: https://issues.apache.org/jira/browse/PHOENIX-5680 Project: Phoenix Issue Type: Task

[jira] [Updated] (PHOENIX-5454) Phoenix scripts start foreground java processes as child processes

2020-01-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated PHOENIX-5454: - Fix Version/s: 4.16.0 Affects Version/s: 4.15.0 Backported to the 4.x branches as

Re: Moving Phoenix master to Hbase 2.2

2020-01-14 Thread István Tóth
Yes, the HBase API signatures change between versions, so we need to compile each compat module against a specific HBase. Whether I can define an internal compatibility API that is switchable at run (startup) time without a performance hit remains to be seen. István On Tue, Jan 14, 2020 at 3:21

[jira] [Updated] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-5678: -- Attachment: PHOENIX-5678.master.000.patch > Cleanup anonymous inner classes used for