Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/157#issuecomment-205847652
Yea, I'll take a look. What is the associated Jira?
On Mon, Apr 4, 2016 at 8:02 PM, James Taylor
wrote:
> @codymarcel <https:/
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/157#discussion_r58554472
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -254,6 +254,7 @@ public void run() throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/157#discussion_r58554617
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/DataTypeMapping.java
---
@@ -25,7 +25,8 @@
CHAR("CHAR",
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/157#discussion_r58555009
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/QuerySet.java
---
@@ -31,7 +31,24 @@
private long
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/157#discussion_r58557911
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WriteWorkload.java
---
@@ -253,13 +255,22 @@ private void waitForBatches
Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/157#issuecomment-205858884
General Comments.
1. Please add some unit tests. Especially around the instanceResolver and
RulesApplier. We user
https://github.com/apache/phoenix/blob
Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/157#issuecomment-209524084
@gkanade Any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user codymarcel opened a pull request:
https://github.com/apache/phoenix/pull/89
Mixed R/W workload support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/codymarcel/phoenix PHOENIX-1920
Alternatively you can review and
Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/89#issuecomment-112984238
@mujtabachohan @twdsilva
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/89#issuecomment-112984696
@samarthjain
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32763915
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/QueryExecutor.java
---
@@ -18,227 +18,271 @@
package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32765859
--- Diff:
phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java ---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32766179
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -135,10 +154,7 @@ public synchronized boolean shouldStop
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32847155
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WorkloadExecutor.java
---
@@ -19,95 +19,92 @@
package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848091
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -146,49 +173,77 @@ public void run() throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848223
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/WriteParams.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848277
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -51,13 +58,11 @@
private volatile boolean
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848731
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/DataModelResult.java
---
@@ -18,61 +18,57 @@
package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848856
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/QuerySetResult.java
---
@@ -18,31 +18,30 @@
package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32850256
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/DataModelResult.java
---
@@ -18,61 +18,57 @@
package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/105#discussion_r36532442
--- Diff:
phoenix-pherf/src/it/java/org/apache/phoenix/pherf/DataIngestIT.java ---
@@ -144,4 +148,52 @@ public void testRWWorkload() throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38470727
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -76,6 +78,8 @@
options.addOption("d", "debu
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38470777
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -136,6 +142,8 @@ public Pherf(String[] args) throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38470844
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -179,6 +188,15 @@ public void run() throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38471394
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -136,6 +142,8 @@ public Pherf(String[] args) throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38471433
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -179,6 +188,15 @@ public void run() throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38471489
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -179,6 +188,15 @@ public void run() throws Exception
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38471909
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/PherfConstants.java ---
@@ -62,6 +62,8 @@
public static final int
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38472004
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/PherfConstants.java ---
@@ -62,6 +62,8 @@
public static final int
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38472365
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ResultUtil.java ---
@@ -147,9 +147,9 @@ public String getSuffix() {
if
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38472866
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/PhoenixUtil.java ---
@@ -274,4 +274,34 @@ public void updatePhoenixStats(String
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38473049
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResultsComparator.java
---
@@ -0,0 +1,353 @@
+package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38473156
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResultsComparator.java
---
@@ -0,0 +1,353 @@
+package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38473654
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResultsComparator.java
---
@@ -0,0 +1,353 @@
+package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38474158
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResultsComparator.java
---
@@ -0,0 +1,353 @@
+package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38476254
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResultsComparator.java
---
@@ -0,0 +1,353 @@
+package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38477085
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResultsComparator.java
---
@@ -0,0 +1,353 @@
+package
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38477433
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedDiffer.java
---
@@ -51,7 +53,7 @@ private void diffQuery() throws
GitHub user codymarcel opened a pull request:
https://github.com/apache/phoenix/pull/41
working additions of pherf to phoenix as a project module
"mvn clean package" builds everything correctly.
All tests pass.
You can merge this pull request into a Git repository
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26230867
--- Diff: phoenix-pherf/README.md ---
@@ -0,0 +1,105 @@
+Pherf is a performance test framework that exercises HBase through Apache
Phoenix, a SQL
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26231197
--- Diff: phoenix-pherf/cluster/pherf.sh ---
@@ -0,0 +1,33 @@
+#!/bin/bash
--- End diff --
Yea, I planned to convert this to python post
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26231675
--- Diff:
phoenix-pherf/src/main/resources/scenario/prod_test_unsalted_scenario.xml ---
@@ -0,0 +1,342
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239341
--- Diff: phoenix-pherf/config/pherf.properties ---
@@ -0,0 +1,61 @@
+#
--- End diff --
Fixed
---
If your project is set up for it, you
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239779
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239994
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26240525
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedRunner.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241095
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241491
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243047
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Scenario.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243169
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243302
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243599
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243827
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26256135
--- Diff: phoenix-pherf/README.md ---
@@ -0,0 +1,105 @@
+Pherf is a performance test framework that exercises HBase through Apache
Phoenix, a SQL
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26256441
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26231562
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/loaddata/DataLoader.java
---
@@ -0,0 +1,366 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239765
--- Diff: phoenix-pherf/pom.xml ---
@@ -0,0 +1,291 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26339859
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache
Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/41#issuecomment-78597830
I think I have addressed any outstanding concerns. Let me know if there is
anything else.
---
If your project is set up for it, you can reply to this email and have
59 matches
Mail list logo