[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-27 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304848#comment-16304848 ] James Taylor commented on PHOENIX-4382: --- FYI, I pushed this to the cdh branch already so that they

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-26 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304218#comment-16304218 ] James Taylor commented on PHOENIX-4382: --- Please commit to master and all 4.x branches (including

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-26 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304193#comment-16304193 ] Thomas D'Silva commented on PHOENIX-4382: - Since we don't consider the schema of the column, I

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-26 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304113#comment-16304113 ] James Taylor commented on PHOENIX-4382: --- bq. Should we add a config option to determine the

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-26 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304018#comment-16304018 ] Thomas D'Silva commented on PHOENIX-4382: - [~vincentpoon] Thanks for the patch. Should we add a

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-26 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303993#comment-16303993 ] James Taylor commented on PHOENIX-4382: --- Waiting for [~tdsilva] to review as he’s very familiar

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-26 Thread Pedro Boado (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303924#comment-16303924 ] Pedro Boado commented on PHOENIX-4382: -- [~vincentpoon], [~jamestaylor] suggested to include this

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300904#comment-16300904 ] Hadoop QA commented on PHOENIX-4382: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-21 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300515#comment-16300515 ] Vincent Poon commented on PHOENIX-4382: --- nevermind, I think the issue I came across only happens

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-21 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300472#comment-16300472 ] Vincent Poon commented on PHOENIX-4382: --- Found a bug while testing separatorByte values. Will put

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-21 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300445#comment-16300445 ] Thomas D'Silva commented on PHOENIX-4382: - Sure I will review it soon. > Immutable table

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-21 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300203#comment-16300203 ] James Taylor commented on PHOENIX-4382: --- bq. I can add tests for various values that start with

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-21 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300165#comment-16300165 ] Vincent Poon commented on PHOENIX-4382: --- In the test class in the patch, there are tests with two

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-20 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299626#comment-16299626 ] James Taylor commented on PHOENIX-4382: --- bq. So, for example, the way we can distinguish

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-20 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299450#comment-16299450 ] Vincent Poon commented on PHOENIX-4382: --- - TINYINT or BYTE(1) should work fine since I explicitly

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-20 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299427#comment-16299427 ] James Taylor commented on PHOENIX-4382: --- Thanks for the explanation. Couple of follow up

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-20 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299363#comment-16299363 ] Vincent Poon commented on PHOENIX-4382: --- And with my patch, using the new (V2) scheme, those two

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-20 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299360#comment-16299360 ] Vincent Poon commented on PHOENIX-4382: --- [~jamestaylor] since we store everything using

[jira] [Commented] (PHOENIX-4382) Immutable table SINGLE_CELL_ARRAY_WITH_OFFSETS values starting with separator byte return null in query results

2017-12-20 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299341#comment-16299341 ] James Taylor commented on PHOENIX-4382: --- The fix for the new serialization is fine, but I'd still