Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-06-04 Thread Viraj Bhat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11355/ --- (Updated June 4, 2013, 9:50 p.m.) Review request for pig and Rohini

Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-06-04 Thread Viraj Bhat
On June 3, 2013, 1:20 p.m., Rohini Palaniswamy wrote: http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java, lines 629-636 https://reviews.apache.org/r/11355/diff/2/?file=295976#file295976line629

Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-06-04 Thread Viraj Bhat
On June 2, 2013, 8:55 p.m., Cheolsoo Park wrote: Hi Viraj, I have a couple of comments: - 5k records seems unnecessary for a unit test case. You need just a few records to verify your fix, don't you? - In you test case, can't you use mock.Storage instead of PigStorage? Then,

Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-06-04 Thread Viraj Bhat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11355/ --- (Updated June 4, 2013, 11:23 p.m.) Review request for pig and Rohini

Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-06-04 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11355/#review21455 --- Ship it! Ship It! - Rohini Palaniswamy On June 4, 2013, 11:23

Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-06-03 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11355/#review21315 ---

Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-06-02 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11355/#review21304 --- Hi Viraj, I have a couple of comments: - 5k records seems

Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

2013-05-29 Thread Viraj Bhat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11355/ --- (Updated May 30, 2013, 2:29 a.m.) Review request for pig and Rohini