Re: Establish Coding Standards for Apache Pirk

2016-07-17 Thread Suneel Marthi
Sorry for being a pest today, more questions: 1. Seeing that the project's presently using Log4j for logging. Do we wanna continue with that or shuld we switch to using Sl4j? 2. Regarding the previous discussion about Java 8 being the minimum required JDK, we may have to base that decision on

Re: PR merge process

2016-07-17 Thread Joe Witt
I am far from being a Git expert but I end up on this page a lot: https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git/ Joe On Sun, Jul 17, 2016 at 12:40 PM, Ellison Anne Williams wrote: > My fault completely - I forgot to include the '--author'

PR merge process

2016-07-17 Thread Suneel Marthi
I am seeing that the original author of a PR is being wiped out while committing the PRs to the codebase. The 'git commit' command to retain the original author as contributor is: git commit --author -a -m "PIRK- description closes apache/pirk#ZZ" This way the original author would show

Re: PIRK-7 -- JMH license issues

2016-07-17 Thread Ellison Anne Williams
Ok - let's take a close look at Google Caliper (unless anyone has a better option) and see if we can go ahead and port On Sun, Jul 17, 2016 at 12:03 PM, Suneel Marthi wrote: > I completely agree that we should port that code to Google Caliper. > > The benchmarking code

PIRK-7 -- JMH license issues

2016-07-17 Thread Ellison Anne Williams
Suneel -- Thanks for creating the JIRA issue and pointing out the licensing problems. I see that JMH is under the GNU GPL2 ( http://openjdk.java.net/legal/) which is not compatible with the Apache license (http://www.apache.org/legal/resolved.html). It appears that Flink just removed the