[GitHub] incubator-pirk pull request #115: PIRK-79

[wraydulany]

Github user wraydulany commented on a diff in the pull request:

https://github.com/apache/incubator-pirk/pull/115#discussion_r85686604
  
--- Diff: src/main/java/org/apache/pirk/test/utils/BaseTests.java ---
@@ -51,9 +51,9 @@
   public static final int dataPartitionBitSize = 8;
 
   // Selectors for domain and IP queries, queryIdentifier is the first 
entry for file generation
-  private static ArrayList selectorsDomain = new ArrayList<>(
+  public static ArrayList selectorsDomain = new ArrayList<>(
   Arrays.asList("s.t.u.net", "d.e.com", "r.r.r.r", "a.b.c.com", 
"something.else", "x.y.net"));
-  private static ArrayList selectorsIP = new 
ArrayList<>(Arrays.asList("55.55.55.55", "5.6.7.8", "10.20.30.40", 
"13.14.15.16", "21.22.23.24"));
+  public static ArrayList selectorsIP = new 
ArrayList<>(Arrays.asList("55.55.55.55", "5.6.7.8", "10.20.30.40", 
"13.14.15.16", "21.22.23.24"));
--- End diff --

Ditto.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #115: PIRK-79

[wraydulany]

Github user wraydulany commented on a diff in the pull request:

https://github.com/apache/incubator-pirk/pull/115#discussion_r85686457
  
--- Diff: src/main/java/org/apache/pirk/encryption/Paillier.java ---
@@ -340,4 +342,41 @@ private String parametersToString()
 return "p = " + p.intValue() + " q = " + q.intValue() + " N = " + 
N.intValue() + " NSquared = " + NSquared.intValue() + " lambdaN = " + 
lambdaN.intValue()
 + " bitLength = " + bitLength;
   }
+
+  @Override public boolean equals(Object o)
+  {
+if (this == o)
+  return true;
+if (o == null || getClass() != o.getClass())
+  return false;
+
+Paillier paillier = (Paillier) o;
+
+if (bitLength != paillier.bitLength)
+  return false;
+if (!p.equals(paillier.p))
+  return false;
+if (!q.equals(paillier.q))
+  return false;
+if (!N.equals(paillier.N))
+  return false;
+if (!NSquared.equals(paillier.NSquared))
+  return false;
+if (!lambdaN.equals(paillier.lambdaN))
+  return false;
--- End diff --

I can, but it just leaves a blob of ORd-together stuff. I admit to knowing 
little about the java compiler; wouldn't it just optimize these into such a 
beast anyway? If so, then I feel like it's more aesthetically pleasing to just 
leave them separated. If not, well, screw that, and I'll change it; or if the 
community feels my subjective aesthetics aren't aesthetically pleasing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #115: PIRK-79

[wraydulany]

Github user wraydulany commented on a diff in the pull request:

https://github.com/apache/incubator-pirk/pull/115#discussion_r85683430
  
--- Diff: 
src/test/java/org/apache/pirk/serialization/SerializationTest.java ---
@@ -75,6 +94,106 @@ public void testJavaSerDe() throws Exception
 Assert.assertTrue(deserializedDummyObject.equals(dummyRecord));
   }
 
+  @Test
+  public void testQuerierResponseSerializationDeserialization()
+  {
+testQuerierResponseSerializationDeserialization(jsonSerializer);
+testQuerierResponseSerializationDeserialization(javaSerializer);
--- End diff --

That line isn't in there twice. It's in there once with the arg 
jsonSerializer, and once with the arg javaSerializer. ;) Thus are both extant 
serialization services tested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...

[wraydulany]

Github user wraydulany commented on the issue:

https://github.com/apache/incubator-pirk/pull/107
  
Ok, changing to full PR. I should note for the record that the 
previously-working-for-me Pirk Releases also no longer pass the ES and ESS 
tests for me, another sign that It's Not My Fault.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...

[wraydulany]

Github user wraydulany commented on the issue:

https://github.com/apache/incubator-pirk/pull/107
  
Ok, I've expurgated references (import and comment) to jackson in the code, 
and I've run the style checker against the code i touched. 

Additionally, I've investigated the problems with the 1:ES and 1:ESS tests 
that I'm having, and I'm convinced that they are due to misconfiguration of the 
cluster I'm testing on.

This passes the build tests and distributed tests 1:J, 1:JS, 1:JSS, 1:SS, 
and 1:E for me. If anyone has been able to successfully execute the 1:ES and/or 
1:ESS tests with this PR *and* fail them, please comment and kill this PR. 
Otherwise, I'm going to move this from WIP to full PR in the late morning on 
the US East Coast tomorrow. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...

[wraydulany]

Github user wraydulany commented on the issue:

https://github.com/apache/incubator-pirk/pull/107
  
Fixed the `import...*` and also removed some code garbage that i'd 
commented out, from an earlier attempt to use jackson, an attempt killed by 
spark and its ancient version of jackson.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #107: [WIP] PIRK-45 Remove dependency on Java se...

[wraydulany]

Github user wraydulany commented on a diff in the pull request:

https://github.com/apache/incubator-pirk/pull/107#discussion_r82467602
  
--- Diff: 
src/main/java/org/apache/pirk/query/wideskies/QueryDeserializer.java ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pirk.query.wideskies;
+
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+import com.google.gson.*;
+import com.google.gson.reflect.TypeToken;
+import org.apache.pirk.schema.query.QuerySchema;
+import org.apache.pirk.schema.query.filter.DataFilter;
+import org.apache.pirk.schema.query.filter.FilterFactory;
+import org.apache.pirk.utils.PIRException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.lang.reflect.Type;
+import java.math.BigInteger;
+import java.util.*;
--- End diff --

Yeah, there are 8 of those. Fixing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #107: [WIP] PIRK-45 Remove dependency on Java se...

[wraydulany]

GitHub user wraydulany opened a pull request:

https://github.com/apache/incubator-pirk/pull/107

[WIP] PIRK-45 Remove dependency on Java serialization

This is a WIP (do not merge) for adding in JSON serialization. I can't get 
this WIP to pass the elasticsearch spark streaming tests on my cluster.

I'm fairly sure that this is a configuration problem on my end (the errors 
I get appear to be such), but I'm having little luck resolving them, and would 
love it if some of the community could give it a test.

I've left in Java Serialization for now, but I've made JSON serialization 
the default.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wraydulany/incubator-pirk PIRK-45

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-pirk/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #107


commit c2c6af2465e21cd706c8cfd0dc4f95f7746d86f0
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-28T15:13:12Z

Initial start on moving away from Java object serialization.

commit 66235a9c6ac07e3cec6a94c0874b40bf6624192e
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-29T17:02:17Z

Initial work.

commit 03b4964c2b25538aaecfdcd56a408bcba8154688
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-01T17:20:09Z

Merge branch 'master' of https://github.com/wraydulany/incubator-pirk into 
PIRK-45

commit de01c5ad1e670200cefa6c7dfc2b678cb245eaf6
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-01T17:21:27Z

Merge branch 'master' of https://github.com/wraydulany/incubator-pirk into 
PIRK-45

commit 7b221de870f7efc8b41ec52fd5d05af06360c405
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-04T18:24:18Z

Added deserializer for query; I think I should delete the serializer for 
QueryInfo.

commit fdeb7d77117691f7dda63a2a180d805861216893
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-04T19:21:22Z

Query serialization seems to be working now; at least it doesn't fail to 
get recalled.

commit b31afcfe7f01ebda6a19e27b5e651f8dc8763f16
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-04T19:42:20Z

Response deserializer compiles.

commit 42e2bb6082a601e5e503e76170499baff37fc478
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-05T12:31:51Z

Custom deserializers complete, as are class amendments to make them work.

commit 603fcaa777f754dbf60836a8a81b7239b39ae494
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-05T14:29:21Z

Merge remote-tracking branch 'upstream/master' into PIRK-45

commit fbebc4adafefa640e5b0339d2423abdabed9b0b3
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-05T15:59:55Z

Needed to add a new constructor for QueryInfo so as to not depend on the 
existence of a populated QuerySchemaRegistry.

commit b9caf260f14405705864ba200d993057a7040416
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-06T12:16:34Z

Move to gson breaks hdfs?

commit dc9fcfd848c89bf59310c0c12284b5bbb72caec4
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-06T12:49:45Z

Working with Gson on two tests; time for distributed tests.

commit 99cddd1981f76569d63add70a6351ba744ca13c9
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-10-07T20:19:48Z

Merge remote-tracking branch 'upstream/master' into PIRK-45




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #101: [PIRK-68] - Add the Capability for Generic Fields...

[wraydulany]

Github user wraydulany commented on the issue:

https://github.com/apache/incubator-pirk/pull/101
  
+1 lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #96: [PIRK-70] Add supporting LaTeX for math dec...

[wraydulany]

GitHub user wraydulany opened a pull request:

https://github.com/apache/incubator-pirk/pull/96

[PIRK-70] Add supporting LaTeX for math deck to repo.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wraydulany/incubator-pirk PIRK-70

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-pirk/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #96


commit 9186a3d769940d3c024fa3f74ea3a56a49118f25
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-20T14:14:40Z

Added files.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #95: [WIP] [PIRK-69] Improve clarity of group theory po...

[wraydulany]

Github user wraydulany commented on the issue:

https://github.com/apache/incubator-pirk/pull/95
  
Please don't close this until we have some feedback from the community 
indicating that the changes provide sufficient background to make clear my 
(previously quite obscure, unless you knew group theory terminology off the top 
of your head already) mathematical notation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #91: [Pirk-66] - Fix Website To Indicate Pirk's ...

[wraydulany]

GitHub user wraydulany opened a pull request:

https://github.com/apache/incubator-pirk/pull/91

[Pirk-66] - Fix Website To Indicate Pirk's Use of Java 8

This is a one-byte change. Heck, it's a one-bit change, from a certain pov.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wraydulany/incubator-pirk PIRK-66

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-pirk/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit 838710a726bd7e7386e29ced4583c575674f400d
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-16T18:37:51Z

Now for_developers.md says we're developing for Java 8.

commit 3548428d3966a341a7ab7dc6722a7f7049251286
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-17T02:01:04Z

Trying to trigger a commit.

commit 79cc576c0540edeeb336edbc7b7eb17e9773fedb
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-17T02:04:20Z

Triggered that commit, deleting pointless space.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #90: Pirk 66

[wraydulany]

Github user wraydulany closed the pull request at:

https://github.com/apache/incubator-pirk/pull/90


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #90: Pirk 66

[wraydulany]

GitHub user wraydulany opened a pull request:

https://github.com/apache/incubator-pirk/pull/90

Pirk 66

Changed "Java 7" to "Java 8" on for-developers page.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wraydulany/incubator-pirk PIRK-66

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-pirk/pull/90.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #90


commit 838710a726bd7e7386e29ced4583c575674f400d
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-16T18:37:51Z

Now for_developers.md says we're developing for Java 8.

commit 3548428d3966a341a7ab7dc6722a7f7049251286
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-17T02:01:04Z

Trying to trigger a commit.

commit 79cc576c0540edeeb336edbc7b7eb17e9773fedb
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-09-17T02:04:20Z

Triggered that commit, deleting pointless space.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #49: [Pirk 38]: Update Javadocs for Schema Loade...

[wraydulany]

GitHub user wraydulany opened a pull request:

https://github.com/apache/incubator-pirk/pull/49

[Pirk 38]: Update Javadocs for Schema Loaders

Now with 100% more merging upstream master.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wraydulany/incubator-pirk PIRK-38

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-pirk/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit 6f214b768acb314df7785eedbea5f2f8342906d3
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T11:15:03Z

Updated javadocs and some other comments for user and developer

commit 7491376dd5e161b20fa6221c9ac06c7dd3575f74
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T15:35:37Z

Minor changes to words, remove errantly added import.

commit f5870b9cb3124733096dcb82d9911eb54de38639
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T15:38:53Z

Minor changes to words, eliminate unnecessary complexity in link name

commit 956ae54332f6d1ecf2523ebbe977f7ac683386a2
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T15:45:41Z

Yet more minor but useful changes to words

commit 37406b08197e5937f917fe1ee866e5d0ee7ddb51
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-02T13:54:29Z

Documenting that element names are case sensitive

commit c6f6549a00fb30aa6fc435a220aa1c2a739a4f8b
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T13:31:01Z

Now updating comments for QuerySchemeLoader

commit 23568fc1688792b87d4379d3bedfc1cdaf44d371
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T13:32:52Z

Merge remote-tracking branch 'upstream/master' into PIRK-38

commit 3726f36de429e32cb2372546b9b2712a5aacd3a9
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T15:05:36Z

A few more comment updates for the DataSchemaLoader

commit dcaf4210dfa5ecce5aab6307126b56b5b07bba3d
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T19:54:22Z

Turn all the pre-function comments to javadocs; fix a tag.

commit c46ed6042d29510e1e653e5996b9ab2bcf2bce7c
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T22:36:51Z

QuerySchemaLoader: Turn all the pre-function comments to javadocs; fix a 
tag.

commit 08e58c758ae579170239e826fcaa83250718e4c7
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T22:39:42Z

I wish that I could reference members and methods in a javadoc link; alas, 
no.

commit 5ff53952eff4c9777017334f782e5c150df131bf
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-06T00:07:31Z

Merge remote-tracking branch 'upstream/master' into PIRK-38




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #48: [Pirk 38]: Update Javadocs for Schema Loaders

[wraydulany]

Github user wraydulany commented on the issue:

https://github.com/apache/incubator-pirk/pull/48
  
Whoops. Still a n00b, need to merge upstream first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #48: [Pirk 38]: Update Javadocs for Schema Loade...

[wraydulany]

Github user wraydulany closed the pull request at:

https://github.com/apache/incubator-pirk/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #48: [Pirk 38]: Update Javadocs for Schema Loade...

[wraydulany]

GitHub user wraydulany opened a pull request:

https://github.com/apache/incubator-pirk/pull/48

[Pirk 38]: Update Javadocs for Schema Loaders



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wraydulany/incubator-pirk PIRK-38

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-pirk/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #48


commit 6f214b768acb314df7785eedbea5f2f8342906d3
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T11:15:03Z

Updated javadocs and some other comments for user and developer

commit 7491376dd5e161b20fa6221c9ac06c7dd3575f74
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T15:35:37Z

Minor changes to words, remove errantly added import.

commit f5870b9cb3124733096dcb82d9911eb54de38639
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T15:38:53Z

Minor changes to words, eliminate unnecessary complexity in link name

commit 956ae54332f6d1ecf2523ebbe977f7ac683386a2
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-01T15:45:41Z

Yet more minor but useful changes to words

commit 37406b08197e5937f917fe1ee866e5d0ee7ddb51
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-02T13:54:29Z

Documenting that element names are case sensitive

commit c6f6549a00fb30aa6fc435a220aa1c2a739a4f8b
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T13:31:01Z

Now updating comments for QuerySchemeLoader

commit 23568fc1688792b87d4379d3bedfc1cdaf44d371
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T13:32:52Z

Merge remote-tracking branch 'upstream/master' into PIRK-38

commit 3726f36de429e32cb2372546b9b2712a5aacd3a9
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T15:05:36Z

A few more comment updates for the DataSchemaLoader

commit dcaf4210dfa5ecce5aab6307126b56b5b07bba3d
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T19:54:22Z

Turn all the pre-function comments to javadocs; fix a tag.

commit c46ed6042d29510e1e653e5996b9ab2bcf2bce7c
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T22:36:51Z

QuerySchemaLoader: Turn all the pre-function comments to javadocs; fix a 
tag.

commit 08e58c758ae579170239e826fcaa83250718e4c7
Author: Walter Ray-Dulany <raydul...@gmail.com>
Date:   2016-08-04T22:39:42Z

I wish that I could reference members and methods in a javadoc link; alas, 
no.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---