Re: [DRAFT] First Podling Report PLC4X

2017-12-29 Thread Justin Mclean
Hi, I’d also add that the software grant was submitted. Thanks, Justin

Welcome PPMC members

2017-12-29 Thread Justin Mclean
Hi, Thanks for signing up to be part of the initial PPMC for Apache PLC4X project. If you have not already done so please sign up to the email lists by sending an email to each of these: private-subscr...@plc4x.apache.org dev-subscr...@plc4x.apache.org As a PPMC member, you are responsible for

IsoTPProtocol tests

2017-12-29 Thread Justin Mclean
Hi, I just checked in some IsoTPProtocol tests and notice that he header size was off in one case. [1] Someone mind double checking for me as I’m not familiar with the protocol and was just going with what was in the code. Thanks, Justin 1.

Re: [DRAFT] First Podling Report PLC4X

2017-12-29 Thread Justin Mclean
Hi, Looking good to me there’a couple of things I would add. I’d add “Make our first release” as a point under "Most important issues to address while moving towards graduation” > Any Issues the Incubator PMC or ASF Board might wish/need to be aware of: > > * Still not all members of the

Re: decodeData in Plc4xS7Protocol

2017-12-29 Thread Christofer Dutz
Hi Justin, I did have a look at the code you referred to and I agree that this is actually not 100% correct. It will probably not have caused any damage as each of the arrays is just one element. But you are right it’s not correct. I fixed that … thanks for finding things like that ;-) Chris