Re: Handling of signed / unsigned values

2018-08-03 Thread Christofer Dutz
Hi Julian, I just double checked and created some more variables. Seems you are correct and the naming in the address only refers to the size of the data-element referenced. So both a DINT and a REAL consume 4 bytes in memory and therefore both are called something DBW2 ... wonder where TIA

Re: Handling of signed / unsigned values

2018-08-03 Thread Julian Feinauer
Hey Chris, this is an excellent idea and will make it a lot easier to translate TIA programs to Plc4X code as it makes this really copy and paste (and of course we know Hurz). We also had a look into TIA and it seems that the D stands for Double Word (i.e. 4 Bytes) and the B for single

[GitHub] JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.

2018-08-03 Thread GitBox
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410172284 @chrisdutz I guess due to my partial scala background I totally ignore Javas Completable futures as superior and thus didnt think about

[GitHub] chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close.

2018-08-03 Thread GitBox
chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410171496 And I don't agree with Sebastians assumption. Even if it might be the same thread when running in unit-tests (Here we have to write the

[GitHub] chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close.

2018-08-03 Thread GitBox
chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410170620 Ok ... so I just checked in the version I was talking about. It is basically structurally equal to the way we are doing things in the