Re: [generation] Progress on the code generation ...

2019-04-10 Thread Christofer Dutz
Yeah ... would be an option, but was hesitant to setup a whole separate repo for this one maven module. But not really got a strong opinion about it ... The "Royals" sort of live with a bunch of deps like that in their repo for years ;-) Chris Am 10.04.19, 20:33 schrieb "Otto Fowler" :

Re: [generation] Progress on the code generation ...

2019-04-10 Thread Otto Fowler
Having it separate is the way that Apache Nifi for example does it, down to it’s own git repo as well. On April 10, 2019 at 14:27:25, Christofer Dutz (christofer.d...@c-ware.de) wrote: Hi all, just wanted to keep you all in the loop (I’ll try to use the [generation] as marker for this topic).

[generation] Progress on the code generation ...

2019-04-10 Thread Christofer Dutz
Hi all, just wanted to keep you all in the loop (I’ll try to use the [generation] as marker for this topic). I just committed some changes to the “plc4x-maven-plugin”. And I also noticed I should explain why this module is not integrated into the build. Maven is quite good at resolving depende

Re: Anyone interested in revamping the Kafka-Connect adapter?

2019-04-10 Thread Tim Mitsch
Hey I'm not so deep in Kafka-Connect - but i would be interested to work on the camel implementation of scraper - i will do a jira issue for that, good point Julian. But time is quite rare until weekend. Best Tim Am 10.04.19, 10:35 schrieb "Julian Feinauer" : Hi, yes, that shoul

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [288]'

2019-04-10 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [288]': Is back to normal.

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #59: Feature/alternate plc4 x 108

2019-04-10 Thread GitBox
sruehl commented on a change in pull request #59: Feature/alternate plc4 x 108 URL: https://github.com/apache/incubator-plc4x/pull/59#discussion_r273885556 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.java

[GitHub] [incubator-plc4x] chrisdutz commented on a change in pull request #59: Feature/alternate plc4 x 108

2019-04-10 Thread GitBox
chrisdutz commented on a change in pull request #59: Feature/alternate plc4 x 108 URL: https://github.com/apache/incubator-plc4x/pull/59#discussion_r273877508 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.j

[GitHub] [incubator-plc4x] chrisdutz commented on a change in pull request #59: Feature/alternate plc4 x 108

2019-04-10 Thread GitBox
chrisdutz commented on a change in pull request #59: Feature/alternate plc4 x 108 URL: https://github.com/apache/incubator-plc4x/pull/59#discussion_r273874554 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.j

[GitHub] [incubator-plc4x] sruehl commented on a change in pull request #59: Feature/alternate plc4 x 108

2019-04-10 Thread GitBox
sruehl commented on a change in pull request #59: Feature/alternate plc4 x 108 URL: https://github.com/apache/incubator-plc4x/pull/59#discussion_r273873825 ## File path: plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.java

[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [287]'

2019-04-10 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [287]': Check console output at "https://builds.apache.org/job/PLC4X/job/PLC4X/job/develop/287/";>PLC4X/PLC4X/develop [develop] [287]"

[GitHub] [incubator-plc4x] JulianFeinauer commented on issue #59: Feature/alternate plc4 x 108

2019-04-10 Thread GitBox
JulianFeinauer commented on issue #59: Feature/alternate plc4 x 108 URL: https://github.com/apache/incubator-plc4x/pull/59#issuecomment-481596726 @chrisdutz thank you for the PR! I will try to review it this week and start some tests with our S7 PLC here, to see if it works. --

[GitHub] [incubator-plc4x] chrisdutz opened a new pull request #59: Feature/alternate plc4 x 108

2019-04-10 Thread GitBox
chrisdutz opened a new pull request #59: Feature/alternate plc4 x 108 URL: https://github.com/apache/incubator-plc4x/pull/59 Hi, in this alternate implementation, I added a "ping" method to the default API and moved the code for the TCP ping into the classes actually involved in TCP

Re: Anyone interested in revamping the Kafka-Connect adapter?

2019-04-10 Thread Julian Feinauer
Hi, yes, that should be the way to go (also for something like Camel...). I have no time to contriobute this week, I can only offer to answer questions... perhaps Tim can say something? Julian PS.: Oh, we should at least add Jira issues... we have to learn that Am 10.04.19, 10:32 schrieb "Chr

Anyone interested in revamping the Kafka-Connect adapter?

2019-04-10 Thread Christofer Dutz
Hi all, yesterday I have been trying to understand the Kafka-Connect adapter and think I managed to get to a point where I sort of understand it. However I’m not quite happy with the way it currently works (I think you have to put every item address in a space-separate list also does it use manu

AW: Integration of other Languages / Daffodil

2019-04-10 Thread Bjoern Hoeper
Hey, ok I agree that we should have enough time to discuss this quite important topic so a separate meeting is much better. I would be fine going to Frankfurt and I am quite flexible still in May. Best Regards Björn -Ursprüngliche Nachricht- Von: Christofer Dutz Gesendet: Mittwoch, 10

Re: Integration of other Languages / Daffodil

2019-04-10 Thread Christofer Dutz
Hi Björn, while this would be possible, we planned on doing some initial heavy lifting for Edgent on that day. So I would suggest a separate date for a PLC4X multi-language-kick-off meeting ... What do you think? I definitely can offer our Frankfurt office as location as it's intentionally pl

AW: Integration of other Languages / Daffodil

2019-04-10 Thread Bjoern Hoeper
Hey, I am also glad to join the team and I am really happy that the discussion took off this well. I would +1 Julians Proposal for a personal meeting at due time for discussing the code generation. Something that came to my mind was to join this meeting with the Apache Edgent Meetup you mention

Re: Integration of other Languages / Daffodil

2019-04-10 Thread Julian Feinauer
Hi, I did not intend to hurry you in any way, chris : ) You are the one to set the next steps... I just wanted to bring the topic back (after all that paperwork). And after your statements here, I would even more like to have a meetup where you present this a bit more detailed. What do you thin

Re: Integration of other Languages / Daffodil

2019-04-10 Thread Christofer Dutz
Hi Julian, I agree with bringing this topic more back to the core ... as you can imagine it feels like I have not been working on this to 100% as about 90% of my time and energy was consumed with pre-graduation work. I think this will be over about 08:45 CET tomorrow ;-) I guess I still will n