Re: [VOTE] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Christofer Dutz
+1 Binding Found a minor documentation error when building on Linux All checks performed: * Checked out using the updated tooling (now downloads from TLP URL): OK * Checked signatures: OK * Checked the zip correctly unpacks to the expected directory structure: OK * verify the existence of

Re: [DISCUSS] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Christofer Dutz
Regarding the year number ... I've made sure this is automatically updated. Also did I start work on having other parts of our site automatically adapt to the current state. For example the groovy-maven-plugin is now used to define some dynamic properties with useful version numbers so we can

[jira] [Created] (PLC4X-126) Make the asciidoctor generated site reference the dynamic properties

2019-05-22 Thread Christofer Dutz (JIRA)
Christofer Dutz created PLC4X-126: - Summary: Make the asciidoctor generated site reference the dynamic properties Key: PLC4X-126 URL: https://issues.apache.org/jira/browse/PLC4X-126 Project: Apache

Re: [DISCUSS] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Justin Mclean
Hi, > JMH is used to microbenchmark the protocol stack. Currently it is only > implemented for ADS. > As these licenses habe a classpath exception they should be safe to use. > Pretty sure we checked this with legal back then (thus the XML commemts) It’s an optional dependanc, that is seem no

Re: [DISCUSS] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Sebastian Rühl
JMH is used to microbenchmark the protocol stack. Currently it is only implemented for ADS. As these licenses habe a classpath exception they should be safe to use. Pretty sure we checked this with legal back then (thus the XML commemts) Sebastian > Am 22.05.2019 um 09:18 schrieb Christofer

Re: [VOTE] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Julian Feinauer
Hi, I checked - no incubating in name or DISCLAIMER file - signatures and hashes correct (checked with tooling from Chris) - all source files have ASF headers (rat plugin) - can compile from source I ran `mvn clean verify

Re: [DISCUSS] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Julian Feinauer
Hi all, I am just checking the rc and I observed that the confluence site is quite outdated ("check incubating in it.."). I suggest that we move that to our homepage (?) and update it a bit AND it would be good to state which maven profiles are relevant for the release, i.e, what we should run

Re: [VOTE] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Justin Mclean
Hi, +1 (binding) I should of added. Thanks, Justin

Re: [DISCUSS] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Christofer Dutz
Yeah ... That's not even used for testing. It's one of the modules, I have no idea what they are used for. Having a look at it, I would even suggest getting rid of it. It's using GPL stuff and isn't really used and seems to be designed for the ADS protocol only. But for now: Yes, it's just