+1 Binding
Found a minor documentation error when building on Linux
All checks performed:
* Checked out using the updated tooling (now downloads from TLP URL): OK
* Checked signatures: OK
* Checked the zip correctly unpacks to the expected directory structure: OK
* verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES: OK
* Checked the contents of LICENSE, NOTICE, README, RELEASE_NOTES: OK
* Built from sources (including tests and all profiles activated and
additionally with empty maven local repo) according to instructions in README:
OK
* All tests pass: OK
* No non-image binaries or unlicensed code in rat.txt: OK
* No usage of SNAPSHOT versions (in the dynamic driver we have a locked
snapshot version of scxml2 library, but that's in highly experimental code
which will be replaced soon, other than that there is one mention of SNAPSHOT
in a Readme, in the fake tools pom.xml and the pom of the plc4x-maven-plugin
(which is also in the sandbox and will be moved to a separate repo as soon as
it's going to be released for the first time ... the plugin isn't required by
the rest of the build): OK
Ran the full build on:
- MacOS: OK
Total time: 18:21 min
- Linux (Ubuntu): OK (After manually installing python "setuptools", which was
not documented in README, but is now added)
Total time: 19:21 min
- Windows 10: (After moving the directory somewhere so the full path of the
object files doesn't exceed 250 characters ... also need to document this ...
also did I need to start the plc4j-opm build 3 times till the tests all passed
(timing issues))
Total time: 52:10 min
Am 22.05.19, 00:08 schrieb "Christofer Dutz" <[email protected]>:
Apache PLC4X 0.4.0 has been staged under [2] and it’s time to vote
on accepting it for release. All Maven artifacts are available under [1].
Voting will be open for 72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.
Release tag: release/0.4.0
Hash for the release tag: 10739fd4a6d201364d5021c78e7e1c529f04336d
Per [3] "Before voting +1 PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."
You can achieve the above by following [4].
[ ] +1 accept (indicate what you validated - e.g. performed the non-RM
items in [4])
[ ] -1 reject (explanation required)
[1]
https://repository.apache.org/content/repositories/orgapacheplc4x-1009
[2] https://dist.apache.org/repos/dist/dev/plc4x/0.4.0/rc1
[3] https://www.apache.org/dev/release.html#approving-a-release
[4]
https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
