[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [42]'

2020-08-20 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [42]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/42/;>PLC4X/PLC4X/develop [develop] [42]"

Re: [S7] proposal for changing the way we read STRING values.

2020-08-20 Thread Christofer Dutz
Hi Cesar, I'm not saying that I won't implement the other ... of course that's the better solution. But for now this helps simplify things. And given that no one seems to be willing to fund such extensions and I'm currently doing them in my free time, I'm just postponing them in order to be

Re: [S7] proposal for changing the way we read STRING values.

2020-08-20 Thread Cesar Garcia
HI, > So my idea is to only request one byte (the ACT size) of the String and as soon as that’s returned, to ask for only the chars that are actually used. This should drastically reduce the payload on the wire. I find it better to work in a two-step process as you point out. I have my doubts

Re: [S7] proposal for changing the way we read STRING values.

2020-08-20 Thread Julian Feinauer
Hey, I'm unemotional with your suggestion so you have my +0 there : ) Julian Am 20.08.20, 13:27 schrieb "Christofer Dutz" : Hi Julian, what I didn't like with using the Array syntax was that your're not reading an array of Strings ... How would you read an array of strings?

[GitHub] [plc4x] ottobackwards commented on pull request #180: PLC4X-236 Pre-Commit and Hinting Configuration for python

2020-08-20 Thread GitBox
ottobackwards commented on pull request #180: URL: https://github.com/apache/plc4x/pull/180#issuecomment-677762209 @vemmert - This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [plc4x] ottobackwards opened a new pull request #180: PLC4X-236 Pre-Commit and Hinting Configuration for python

2020-08-20 Thread GitBox
ottobackwards opened a new pull request #180: URL: https://github.com/apache/plc4x/pull/180 black, mypy and pre-commit. pre-commit is added as a dev dependency in poetry To enable these hooks -> - pip install pre-commit - pre-commit install Please see

Re: Wiki / Where and How we want to add documentation for other upcoming programming languages?

2020-08-20 Thread Lukas Ott
Thank you Chris and Volker for your answers. :-) The Python Developer Wiki you ll find here: https://cwiki.apache.org/confluence/display/PLC4X/Python+-+Developer+Wiki Cheers, Lukas Am Do., 20. Aug. 2020 um 17:11 Uhr schrieb Christofer Dutz < christofer.d...@c-ware.de>: > And it's easier to

Re: Wiki / Where and How we want to add documentation for other upcoming programming languages?

2020-08-20 Thread Christofer Dutz
And it's easier to grant individuals which are not yet committers rights to edit confluence ... Chris Am 20.08.20, 17:09 schrieb "Volker Emmert" : Hi Lukas, for now at the beginning of the new project I think a wiki or something similar will serve us better. At least I would

Re: Wiki / Where and How we want to add documentation for other upcoming programming languages?

2020-08-20 Thread Volker Emmert
Hi Lukas, for now at the beginning of the new project I think a wiki or something similar will serve us better. At least I would feel it as a hindrance to create a PR/pushing to the develop in order to update something on the website every time a small change is being made. Regards, Volker

Wiki / Where and How we want to add documentation for other upcoming programming languages?

2020-08-20 Thread Lukas Ott
Hi PLC4X developers, As we started now our Python dev here: https://github.com/apache/plc4x/tree/feature/plc4py We are looking for a place for documentation. 1) We like to start with a wiki to document what we have done (e.g. like using https://python-poetry.org/ ) to setup the python project.

[GitHub] [plc4x] ottobackwards merged pull request #179: Feature/plc4py

2020-08-20 Thread GitBox
ottobackwards merged pull request #179: URL: https://github.com/apache/plc4x/pull/179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [S7] proposal for changing the way we read STRING values.

2020-08-20 Thread Christofer Dutz
Hi Julian, what I didn't like with using the Array syntax was that your're not reading an array of Strings ... How would you read an array of strings? How about using round-braces? STRING(10) This way you could read an array of 10-Char strings: STRING(10)[5] Chris Am 20.08.20, 13:16

Re: [S7] proposal for changing the way we read STRING values.

2020-08-20 Thread Julian Feinauer
Hi, this also was a bit controversial in the past and AFAIR we already hat STRING[xx] as the command to not read a String Array but a String with given size (ignoring ACT value). In the end its about latency vs bandwith I guess. Personally, I would stick to the rule: Read MAX either given by

Re: [S7] proposal for changing the way we read STRING values.

2020-08-20 Thread Christofer Dutz
Another alternative would be to explicitly limit the number of chars read. So if we would extend the address syntax for STRING types to something like %DB2:30:STRING:10 It would simply read the 10 chars without checking the size first. Chris Am 20.08.20, 12:44 schrieb "Christofer Dutz" :

[S7] proposal for changing the way we read STRING values.

2020-08-20 Thread Christofer Dutz
Hi all, while investigating: https://issues.apache.org/jira/browse/PLC4X-240 I noticed that the reading of STRING types seems to be extremely inefficient. The reason is that we are currently reading a STRING element by reading 258 bytes (1 byte for MAX num of chars, 1 byte for ACT num of chars

[jira] [Created] (PLC4X-240) Protocol error in reading string

2020-08-20 Thread Stefano Bossi (Jira)
Stefano Bossi created PLC4X-240: --- Summary: Protocol error in reading string Key: PLC4X-240 URL: https://issues.apache.org/jira/browse/PLC4X-240 Project: Apache PLC4X Issue Type: Bug