[GitHub] [plc4x] dependabot[bot] opened a new pull request, #751: build(deps): bump assertj-core from 3.24.1 to 3.24.2

dependabot[bot] opened a new pull request, #751: URL: https://github.com/apache/plc4x/pull/751 Bumps assertj-core from 3.24.1 to 3.24.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.assertj:assertj-core&p

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #750: build(deps): bump Saxon-HE from 11.4 to 12.0

dependabot[bot] opened a new pull request, #750: URL: https://github.com/apache/plc4x/pull/750 Bumps Saxon-HE from 11.4 to 12.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=net.sf.saxon:Saxon-HE&package-mana

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #749: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.5.0

dependabot[bot] opened a new pull request, #749: URL: https://github.com/apache/plc4x/pull/749 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.1.2 to 3.5.0. Commits https://github.com/apache/maven-dependency-plugin/commit/520f8fd6ba4a0

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #748: build(deps): bump kotlin.version from 1.7.22 to 1.8.0

dependabot[bot] opened a new pull request, #748: URL: https://github.com/apache/plc4x/pull/748 Bumps `kotlin.version` from 1.7.22 to 1.8.0. Updates `kotlin-stdlib` from 1.7.22 to 1.8.0 Release notes Sourced from https://github.com/JetBrains/kotlin/releases";>kotlin-stdlib's rele

[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [1217]'

BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [1217]': Is back to normal.

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072191526 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java: ## @@ -16,17 +16,25 @@ * specific language governing permissions and limitations * under t

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072185474 ## plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml: ## @@ -27,7 +27,7 @@ - + Review Comment: Couple of months back I turned them all up

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072183895 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java: ## @@ -16,17 +16,25 @@ * specific language governing permissions and limitations * under the

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072181255 ## plc4j/examples/hello-ads-telemetry/pom.xml: ## @@ -40,13 +43,31 @@ - org.apache.commons - commons-pool2 + org.slf4j + slf4j-api

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072148900 ## plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml: ## @@ -27,7 +27,7 @@ - + Review Comment: I'm using the logging to output informa

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072146589 ## plc4j/examples/hello-ads-telemetry/pom.xml: ## @@ -40,13 +43,31 @@ - org.apache.commons - commons-pool2 + org.slf4j + slf4j-api

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072144969 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java: ## @@ -16,17 +16,25 @@ * specific language governing permissions and limitations * under t

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072123552 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121894 ## plc4j/tools/scraper-ng/pom.xml: ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation=

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121595 ## plc4j/tools/scraper/pom.xml: ## @@ -100,12 +96,6 @@ 0.11.0-SNAPSHOT test - - org.apache.plc4x - plc4j-connection-cache - 0.11.0-SNA

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121286 ## plc4j/tools/scraper-ng/pom.xml: ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation=

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120717 ## plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java: ## @@ -136,11 +136,11 @@ public void onConnect(ConversationContext context)

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120527 ## plc4j/tools/connection-cache/src/test/resources/logback-test.xml: ## @@ -27,7 +27,9 @@ - + + + Review Comment: ```suggestion ``` ###

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120180 ## plc4j/tools/connection-cache/src/test/java/org/apache/plc4x/java/utils/cache/CachedPlcConnectionManagerTest.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Soft

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072118836 ## plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/CachedPlcConnectionManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072117311 ## plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml: ## @@ -27,7 +27,7 @@ - + Review Comment: ```suggestion ``` -- This is

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116783 ## plc4j/examples/hello-ads-telemetry/pom.xml: ## @@ -40,13 +43,31 @@ - org.apache.commons - commons-pool2 + org.slf4j + slf4j-api

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116126 ## plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java: ## @@ -136,11 +136,11 @@ public void onConnect(ConversationContext context) {

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116724 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116329 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072115260 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java: ## @@ -16,17 +16,25 @@ * specific language governing permissions and limitations * under the

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072113699 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072112458 ## plc4j/api/src/main/java/org/apache/plc4x/java/DefaultPlcDriverManager.java: ## @@ -32,19 +34,19 @@ import java.util.ServiceLoader; import java.util.Set; -public class

[GitHub] [plc4x] sruehl merged pull request #718: build(deps): bump kotlin.version from 1.7.22 to 1.8.0

sruehl merged PR #718: URL: https://github.com/apache/plc4x/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org F

[GitHub] [plc4x] chrisdutz opened a new pull request, #747: New Implementation of the Connection-Cache

chrisdutz opened a new pull request, #747: URL: https://github.com/apache/plc4x/pull/747 New-implementation of the Connection Cache and removal of both the old connection-cache as well as the connection-pool. In addition some types in the API module were updated: - The PlcDrive

[GitHub] [plc4x] sruehl merged pull request #745: build(deps): bump netty-bom from 4.1.86.Final to 4.1.87.Final

sruehl merged PR #745: URL: https://github.com/apache/plc4x/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org F

[GitHub] [plc4x] sruehl merged pull request #744: build(deps): bump freemarker from 2.3.31 to 2.3.32

sruehl merged PR #744: URL: https://github.com/apache/plc4x/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org F

[GitHub] [plc4x] sruehl commented on pull request #745: build(deps): bump netty-bom from 4.1.86.Final to 4.1.87.Final

sruehl commented on PR #745: URL: https://github.com/apache/plc4x/pull/745#issuecomment-1385187601 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl merged pull request #746: build(deps): bump mockito.version from 4.11.0 to 5.0.0

sruehl merged PR #746: URL: https://github.com/apache/plc4x/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org F