Re: [VOTE] Create plc4x-extras repository

2024-03-23 Thread Sebastian Rühl
+1 (binding) - Sebastian On 2024/03/23 16:48:36 Christofer Dutz wrote: > We would like to create a new git-repository “plc4x-extras” that will contain > the integration modules as well as the examples. > > Please vote +1 if you are in favor of creating this repository and moving > things from

Re: AW: So when do we want to meet on Saturday?

2024-03-18 Thread Sebastian Rühl
11 sounds good - Sebastian On 2024/03/18 09:48:04 Christofer Dutz wrote: > Hi Lukasz, > > Ok … I could have a look and be there some time round 11 AM … > > My Toddy shirt is so faded, that you can’t even see it anymore :-( > > And with bringing stuff … I’m a bit torn … I could load up my car

Re: AW: [DISCUSS] Disable the Sonar-Check in Github Actions?

2024-03-15 Thread Sebastian Rühl
that in the IoTDB project). > > Chris > > Von: Sebastian Rühl > Datum: Freitag, 15. März 2024 um 11:23 > An: dev@plc4x.apache.org > Betreff: Re: [DISCUSS] Disable the Sonar-Check in Github Actions? > Honestly I think we should do the following: > > - Take sonar

Re: [DISCUSS] Disable the Sonar-Check in Github Actions?

2024-03-15 Thread Sebastian Rühl
Honestly I think we should do the following: - Take sonar serious and look after that stuff Reported there - Disable the build breaker for some time so it doesn't flag everything as a failed build - Think about how we can avoid ending in the same situation again If you look at other projects

PSA: New `with-java` profile to build java part plc4j

2024-02-06 Thread Sebastian Rühl
The java part `plc4j` was for a long time the "primary" language of plc4x. But with other parts gaining more traction (plc4go, plc4net and plc4py as a latest addition) it was about time to not call it the favorite child anymore. With the recent change in the develop branch you now need to enable

Re: AW: [VOTE] Drop Java 1.8 Support

2023-12-08 Thread Sebastian Rühl
+1 on dropping 1.8 support. There is always the option to fork or offer paid support if someone is keen on it, but me personally don't want to do archaeology on ancient java versions... :D - Sebastian On 2023/12/08 14:25:05 Christofer Dutz wrote: > Given the fact that nobody officially admits

Re: [VOTE] Apache PLC4X 0.11.0 RC1

2023-10-02 Thread Sebastian Rühl
+1 (binding) Built on Linux AARCH64 Sebastian [OK] Download all staged artifacts under the url specified in the release vote email. [OK] Verify the signature is correct. [OK] Check if the signature references an Apache email address. [OK] Verify the SHA512 hashes. [OK] Unzip the archive. [OK]

Re: AW: [DRAFT] Board Report

2023-06-13 Thread Sebastian Rühl
ioned components." - Sebastian On 2023/06/13 09:53:20 Christofer Dutz wrote: > Hi Sebastian, > > I added: > > „In PLC4Go a lot of work has been put into streamlining the API, SPI and the > C-Bus driver, which now has a coverage above 80%.“ > > Ok? > > Chris >

Re: [DRAFT] Board Report

2023-06-13 Thread Sebastian Rühl
I Guess we could mention that there was a good bunch of time spend on getting the quality up for the plc4go part. So the API/SPI as well as the c-bus driver has now coverage above 80%. This also includes general fixing of QC issues and testing. - Sebastian On 2023/06/13 08:03:23 Christofer

Re: [DISCUSS] Add GitHub Discussions?

2023-05-15 Thread Sebastian Rühl
+1 sure go for it - Sebastian On 2023/05/15 14:39:27 Christofer Dutz wrote: > Hi all, > > So, my PR for infra just got merged and we can now customize the > auto-generated emails sent for GitHub Discussions … so now I would like to > hear your thoughts on if we want to enable GitHub

Re: AW: [DISCUSS] Have some sort of multi-connection?

2023-05-10 Thread Sebastian Rühl
Hi Chris, I also had the name AggregatedConnection flying around in my head (maybe I think to much of multi vitamin when reading MultiConnection :D) What would be helpful is to list the scenarios in a wiki site and then think through what each connection would have to to in which usecases.

Re: [DISCUSS] Handling string fields

2022-11-07 Thread Sebastian Rühl
To give a little context: In BACnet I have roundtrip tests implemented which takes some bytes, parses them and the serialize again. Here we are losing data because the 0x0 is just omitted and then never written again. IMHO null terminated strings are something special

Re: BOOLeans ;-)

2022-10-13 Thread Sebastian Rühl
In some language I saw that being used as ranges: BOOL[5] would be one bool at index 5 BOOL[:5] would be 5 bools till index 5 BOOL[3:5] would be 3 bools from index 3 to 5 BOOL[2:] would be all bools from index 2 BOOL[:-1] would be all bools till the last index -1 So maybe I'm wrong, but when you

Re: [DISCUSS] Donate/Move the Apache Camel integration to the Apache Camel project?

2022-10-13 Thread Sebastian Rühl
+1 Sounds really good for me (wanted to do that couple of years ago anyway) On 2022/10/12 18:22:41 Christofer Dutz wrote: > Hi all, > > I know we‘ve discussed this on several occasions and as far as I remember > there never really were any objections. But I’d like to do this one > (hopefully)

Re: [VOTE] Apache PLC4X 0.10.0 RC2

2022-10-04 Thread Sebastian Rühl
+1 (binding) Sebastian [x] Download all staged artifacts under the url specified in the release vote email. [x] Verify the signature is correct. [x] Check if the signature references an Apache email address. [x] Verify the SHA512 hashes. [x] Unzip the archive. [x] Verify the existence of

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.6.0 RC1

2022-09-23 Thread Sebastian Rühl
+1 (binding) Sebastian [OK] Download all staged artifacts under the url specified in the release vote email. [OK] Verify the signature is correct. [OK] Check if the signature references an Apache email address. [OK] Verify the SHA512 hashes. [OK] Unzip the archive. [OK] Verify the existence of

Re: [PROPOSAL] Implement a Java GUI application for browsing PLCs with PLC4X

2022-06-23 Thread Sebastian Rühl
-> Electron is de facto the standard for Desktop Applications at least at > > the moment. > > > > https://medium.com/the-web-tub/electron-on-cordova-29ede5d6d789 > > > > https://www.reddit.com/r/javahelp/comments/lrg2ho/web_app_vs_java_fx_vs_electron_js/ > >

RE: [PROPOSAL] Implement a Java GUI application for browsing PLCs with PLC4X

2022-06-23 Thread Sebastian Rühl
I would vote doing it as a terminal application with tcell :D https://github.com/gdamore/tcell https://github.com/gcla/gowid good example for that is termshark - Sebastian On 2022/06/23 13:47:29 Christofer Dutz wrote: > Hi all, > > Great to see this discussion here :-) > > Well, I agree

Re: Higher level device API for drivers - stepping above a plc field

2022-05-17 Thread Sebastian Rühl
Hi Łukasz, at the moment I use the model classes directly but regarding BACNet I also expect the troubles you are describing. So I like the idea to have a way to work with protocol native features directly like you described with the ExtendedDriver. - Sebastian On 2022/05/16 20:50:41 Łukasz

Re: [DISCUSS] Start release process for 0.10.0?

2022-04-29 Thread Sebastian Rühl
Sure, sounds like fun - Sebastian On 2022/04/29 09:25:28 Christofer Dutz wrote: > Hi all, > > we have again implemented a lot of new features and fixed issues ... but > mainly we've changed some driver names (Modbus) which are no longer in-line > with our website. > I think we should start

Re: PLC4Py - Change of Build System - Poetry is for the time beeing not suitable anymore

2022-04-20 Thread Sebastian Rühl
pip-tools SGTM - Sebastian On 2022/04/19 19:52:03 Lukas Ott wrote: > Hello PLC4X Developers, > > As shown here: https://github.com/apache/plc4x/pull/348 > > We started the discussion to change our build system. > > Poetry has at the moment an increasing amount of issues: >

Re: [DISCUSS] Long running branches

2022-04-07 Thread Sebastian Rühl
I agree. It's fine developing new features on develop as long as they are not breaking the build or have a regression. So in case of plc4py this is completely fine as this is a T-0 implementation. - Sebastian On 2022/04/07 11:08:36 Christofer Dutz wrote: > Hi all, > > We have an always

Re: KNX: DPT_Value_Temp aka that 16-bit float with 'special' encoding

2022-03-07 Thread Sebastian Rühl
Hey Darren, you can find a example here: https://github.com/apache/plc4x/blob/develop/protocols/bacnetip/src/main/resources/protocols/bacnetip/bacnetip.mspec#L1262 and here:

Re: [DISCUSS] Remove commons-beanutils dependency

2022-01-21 Thread Sebastian Rühl
Hi Yang, could you please try bring that issue up to the upstream project? We don't want to replicate this logic in PLC4X if this can be solved upstream (at common-beanutils). Maybe there is a alternative implementation for java pojos that I'am currently not aware of. Other than that it's

Re: [DRAFT] December PLC4X board report

2021-12-02 Thread Sebastian Rühl
Other than that why do we have 2 times the ## Issues section? - Sebastian On 2021/12/02 15:07:02 Christofer Dutz wrote: > ## Description: > The mission of the Apache PLC4X project is creating a set of libraries for > communicating with industrial programmable logic controllers (PLCs) using a >

Re: [DRAFT] December PLC4X board report

2021-12-02 Thread Sebastian Rühl
LGTM +1 On 2021/12/02 15:07:02 Christofer Dutz wrote: > ## Description: > The mission of the Apache PLC4X project is creating a set of libraries for > communicating with industrial programmable logic controllers (PLCs) using a > variety of protocols but with a shared API. > > ## Issues: > There

Re: [DISCUSS] Dealling with endianess switches ...

2021-09-28 Thread Sebastian Rühl
Looks all good to me, and I agree with your both. On note to option 2: When you look at it from a generic perspective this is more like a batch-set-property were you set "some" property (endianess is one of them) for a batch of fields. So I could imaging such batch-attribute-setting later down

Re: Changes on mspec: parameterized type refs, assert, try, const

2021-09-26 Thread Sebastian Rühl
mail is an assumption that try is always > followed by optional field. This tells me that 'try' should rather be a > block than a field. By this way we will be able to pair these visually > as well as handle situation when there is one try statement but multiple > optional fields. &

Changes on mspec: parameterized type refs, assert, try, const

2021-09-24 Thread Sebastian Rühl
Hi together, I have some exciting changes in the pipeline regarding the mspec: 1. parameters on type refs with that change it is now possible to target a discriminated child in advance. 2. assert keyword with that change it is possible to throw a ParserAssertException (in java, or

Re: AW: [DISCUSS] Apache PLC4X 0.9.0 RC2

2021-09-21 Thread Sebastian Rühl
I would be fine with that minor imperfection. In case of trouble we can always release a new hotfix. - Sebastian On 2021/09/21 08:22:58, Christofer Dutz wrote: > Ok ... taking reference to Otto's -1 vote. > > I have checked ... it seems that the new testsuite for OPC-UA introduced >

Re: [DISCUSS] Which Java version to use as baseline?

2021-09-21 Thread Sebastian Rühl
We also could go with Java 11 on develop, and if there is demand backport it to java8 on a release branch. But more important would be to know what users are actually using. - Sebastian On 2021/09/21 08:30:47, Christofer Dutz wrote: > Hi all, > > up to now PLC4J has been built in a way,

Re: [VOTE] Apache PLC4X 0.9.0 RC2

2021-09-20 Thread Sebastian Rühl
+1 (binding) Sebastian Rühl [x] Download all staged artifacts under the url specified in the release vote email. [x] Verify the signature is correct. [x] Check if the signature references an Apache email address. [x] Verify the SHA512 hashes. [x] Unzip the archive. [x] Verify the existence

Re: [DISCUSS] [GO] Visibility of SPI package

2021-07-27 Thread Sebastian Rühl
Hi, I would recommend to build a plc4go-spi module similar to what we have in java to keep the core plc4go clean of non api code. Sebastian On 2021/07/26 14:46:36, Christofer Dutz wrote: > Hi all, > > today I stubled over something. > > One of the USPs of PLC4X is, that you can use all of

Re: Added a new field-type "unknown"

2021-05-26 Thread Sebastian Rühl
Sounds good to me. Additionally we could log this packets for debugging purposes so we can collect more data on them when time passes by. - Sebastian On 2021/05/26 09:11:15, Christofer Dutz wrote: > Hi all, > > usually we have fully specified mspec documents. This way we can fully >

Re: Cleanup in our repo (and Sandbox)?

2021-05-21 Thread Sebastian Rühl
Hi all, FYI: I just pushed the renaming from "build-utils" to "code-generation" as it kept itching me. Also I would like to throw something into discussion: 1. In camel for examples they have a extra repository for camel-examples. Maybe we should do that to to not have our repo to overblown.

Re: Please welcome our newest PLC4X committer Thomas Frost

2021-05-07 Thread Sebastian Rühl
Hey Thomas, a warm welcome from my side :) Really great to get some speed into plc4c again. Sebastian > Am 07.05.2021 um 13:39 schrieb Christofer Dutz : > > Hi all, > > please welcome Thomas to the PLC4X family. > He has been doing an outstanding job getting my POC-quality PLC4C > drivers

Re: Out of order Transaction IDs

2021-05-03 Thread Sebastian Rühl
Hi Ben, answers inline: > - Change the RequestTransactionManager class so that it processes the > requests in the transaction ID order instead of the submitted order. This wouldn’t solve the problem because how would the manager know that there is a latter message inbound with a lower

Re: Progress on plc4go

2021-04-26 Thread Sebastian Rühl
Noticing int the last mail that the rendering is completely broken here again the old mail as plain text: Last week I did some progress on plc4go that I want to summarize with this mail: 1. big.Int & big.Float Support: a. Like in Java we can now support oversized ints

Re: plc4x summary from 1bd132a to f97d36f (buffer changes and test framework)

2021-04-26 Thread Sebastian Rühl
Somehow the mailing list removed all the bullet points (apparently it doesn’t like html mails). Here again hopefully readable as plain text: TLDR: changes in plc4x which help developing drivers across languages that have no effect how plc4x send/receiver data or how you use the API As of the

plc4x summary from 1bd132a to f97d36f (buffer changes and test framework)

2021-04-26 Thread Sebastian Rühl
TLDR: changes in plc4x which help developing drivers across languages that have no effect how plc4x send/receiver data or how you use the API As of the last mail `Progress on plc4go` from 15.03.2021 I want to give another overview what has happened between 1bd132a to f97d36f Changes on

Re: Byte representation

2021-04-21 Thread Sebastian Rühl
Small correction: not having native json support in java (is this 2021? :D) in might be best to still use Jackson, but in a more native way where we don’t work with annotations for the generated classes Sebastian > Am 21.04.2021 um 10:36 schrieb Sebastian Rühl > : > > Talking a

Re: Byte representation

2021-04-21 Thread Sebastian Rühl
Talking about Jackson, this can be soon be replaced with our native generated implementation. In Golang xml/json is already ported, in java only xml for now. When I’m done with that we have full control over the serialization which then is language agnostic and dictated by what is defined in

Next evolution of code generation

2021-04-20 Thread Sebastian Rühl
Hi Together, Having worked now on golang for a while and jumped back to java I saw that we had many similarities between the languages. First of all the structure if message being sent (e.g. during the S7 connection dance) and the conversations happening (e.g. during the s7 connect). So it

Byte representation

2021-04-20 Thread Sebastian Rühl
Hi together, Working on xml serialization (and boxed [more about that in my next summary mail]) I noticed that we are missing support for byte in mspec: By (logical) definition a byte is a container of a bits without a immediate semantical meaning. This could be for example a image, binary

Re: RFC / Tooling SPI for drivers / connection state tracking

2021-04-20 Thread Sebastian Rühl
Hi Lukaz, The additions looks good for me and I go along with the points of Chris. Regarding the change of the stack configurer: I would propose to add the suppliers as an set of ne methods as an alternate way to configure your stack. So they could coexist and one would override the other

Re: PLC4c: What I'm up to in PR#233

2021-04-17 Thread Sebastian Rühl
Hi Chris, > I have to admit, I was a bit worried as I saw in your PR that there were > generated files updated (If we don't yet generate that comment Jetbrains IDEs > react on, we definitely need to do that) ... we need to find a way to get > these changes back into the code generation

Re: RFC / Tooling SPI for drivers / connection state tracking

2021-04-17 Thread Sebastian Rühl
Hi Lukasz, Answers below inline > At present we do not offer end user an API to react on connection > shutdown or failure. There is no way for him to find that ie. link died > and his program needs to take action. Sounds like we should add a EventListener so you could register for events and

Re: Drivers causing OutOfMemory exceptions when querying too much too fast

2021-04-07 Thread Sebastian Rühl
We could do it like golang does it with its queues: You size them and if the queue is full the scheduling would simply block (blocking the async call so it won’t return) Sebastian > Am 07.04.2021 um 10:50 schrieb Christofer Dutz : > > Hi Lukasz, > > this was exactly the part I was referring

Progress on plc4go

2021-03-15 Thread Sebastian Rühl
Last week I did some progress on plc4go that I want to summarize with this mail: big.Int & big.Float Support: Like in Java we can now support oversized ints and floats (<64bits) in golang. This is currently only implemented for parsing positive ints. Code for the other uses cases (real, -int) on

plc4go - what a good opportunity to get started again

2021-03-09 Thread Sebastian Rühl
Hi together, Just awake from hibernation and noticed I haven’t wrote in a long time on this mailing list. The last years I had the opportunity to work with golang and fell in love with that language (not only that I also worked with some ci/cd related tools (like renovate) which would be a

Re: [VOTE] Rename our "master" branch to "release"

2020-06-30 Thread Sebastian Rühl
+1 Sebastian > Am 29.06.2020 um 09:09 schrieb Christofer Dutz : > > Hi all, > > we had already discussed that some days ago, but I’d like to formally have > you all vote on this … just to make it official. > > I always thought “master”, “trunk” etc. were sub-ideal names as they don’t >

Re: [PROPOSAL] Add better PLC4X-API support for Input Dialogs

2020-05-29 Thread Sebastian Rühl
SGTM Sebastian

Re: AMS Mspec

2019-11-29 Thread Sebastian Rühl
Hi Chris, Replies below inline: > Am 29.11.2019 um 11:38 schrieb Christofer Dutz : > > Hi Sebatian, > > I just had a look at your mspec work … it seems in the AMSHeader type, you > ran into a problem which I would like to help you with. > > The simple field: > [simple uint32

Re: AMS/ADS mspec and tests for protocol-base-mspec

2019-11-29 Thread Sebastian Rühl
Hack-Session in December? > > Julian > > Am 28.11.19, 12:27 schrieb "Sebastian Rühl" > : > >Hi Chris, > >Sure that, I will try out some stuff anyway but two things I would like to > have: > >1. predefined constants for fields (for example ad

Re: AMS/ADS mspec and tests for protocol-base-mspec

2019-11-28 Thread Sebastian Rühl
Hi Chris, Sure that, I will try out some stuff anyway but two things I would like to have: 1. predefined constants for fields (for example address values uint8 which there are some reserved values). This could be then public static final int fields in java for example 2. Support for bit masks

AMS/ADS mspec and tests for protocol-base-mspec

2019-11-28 Thread Sebastian Rühl
Short notice: I continue working on the mspec for ams/ads and need therefore some new features. The protocol-base-mspec is missing tests so I will add them in this brach too https://github.com/apache/plc4x/tree/feature/ams_ads_mpsec

Re: [RESULT] [VOTE] Apache PLC4X 0.5.0 RC3

2019-11-28 Thread Sebastian Rühl
Just a small note to the release checkers: There where a couple of leftovers I had to fix in current develop. At least we should check if there is nothing with -SNAPSHOT left in the release (e.g. karaf) Secondly we should check if the development is in sync with the current version.

Re: PLC4X and OSGi

2019-10-08 Thread Sebastian Rühl
Hi Julian, We should put the osgi metadata directly into the modules as they „just“ enhance the manifest. Additional JARs would only increase the complexity. Sebastian > Am 07.10.2019 um 15:58 schrieb Julian Feinauer : > > Hi all, > > as some of you may have notices from Twitter or Slack I

Re: Switch to from assembly to shade plugin for building Uber-jars?

2019-08-28 Thread Sebastian Rühl
Hi Chris, My experience is the other way around: shade over assembly. So from my side go for it +1 Sebastian > Am 28.08.2019 um 09:56 schrieb Christofer Dutz : > > Hi all, > > you know we were having problems in the past with the assembly of the no-deps > artifacts. > We solved this by

Re: [DISCUSS] Integrate CRUNCH into PLC4X

2019-08-28 Thread Sebastian Rühl
LGTM so +1 from my side for integration (after solving Ottos proposed TODOs)

Re: [DISCUSS] Retire Daffodil and SCXML?

2019-06-25 Thread Sebastian Rühl
+1 sure go for it Sebastian > Am 25.06.2019 um 09:42 schrieb Christofer Dutz : > > Hi all, > > I would like to start to move the new code generation outside the sandbox. > For this I would like to replace the existing code-generation modules. > > We currently have the dynamic driver modules,

Re: [BUILDS] What build system to use?

2019-05-27 Thread Sebastian Rühl
+1 for the Maven Hybrid solution (CoC, Ease of use [something I miss when I work with other languages], solving occurring problems) Sebastian > Am 27.05.2019 um 14:41 schrieb Christofer Dutz : > > Hi all, > > as the discussion had come up multiple times now … mainly on Slack, I would > like

Re: [DISCUSS] Apache PLC4X 0.4.0 RC1

2019-05-22 Thread Sebastian Rühl
JMH is used to microbenchmark the protocol stack. Currently it is only implemented for ADS. As these licenses habe a classpath exception they should be safe to use. Pretty sure we checked this with legal back then (thus the XML commemts) Sebastian > Am 22.05.2019 um 09:18 schrieb Christofer

Re: AW: [DISCUSS ] PLC4X Teamware

2019-04-27 Thread Sebastian Rühl
Cool idea, +1 from me (altought I can‘t be at the Event) Sebastian > Am 27.04.2019 um 16:11 schrieb Julian Feinauer : > > Hi, > > of course... Will do it when the kids are in bed :) > > Von meinem Mobiltelefon gesendet > > > Ursprüngliche Nachricht > Betreff: Re: [DISCUSS

Re: [DISCUSS] Send Code Review mails to commits@

2019-03-29 Thread Sebastian Rühl
Yep lets do that... > Am 29.03.2019 um 13:42 schrieb Julian Feinauer : > > Hi all, > > as we all got a lot of spam from Sebastians Code Review and my changes we had > a short discussion in the Slack channel. > I suggest to send these mails to the commits@ mailing list or probably > another

Re: [VOTE] Defining the initial PMC/Committers for graduation

2019-03-25 Thread Sebastian Rühl
+1 Christofer Dutz schrieb am Mo. 25. März 2019 um 11:27: > Hi all. > > As we discussed this here before, our PPMC is quite full of people that > have never showed much interest in the project. > This was a result of how we setup the project when we started it here at > codecentric. A lot of

Re: New contributor : )

2019-03-06 Thread Sebastian Rühl
Welcome, Andreas! Andreas Oswald schrieb am Mi. 6. März 2019 um 10:28: > Hi Julian, hi everybody, > > thanks for merging! I´d like to contribute to the documentation to get to > know the project better and who knows, someday I´ll also start coding. > > So if you have any ideas and suggestions

Re: [VOTE] Apache PLC4X (Incubating) 0.3.0 RC2

2019-01-29 Thread Sebastian Rühl
+1 (binding) Sebastian Checks performed: - Checked signatures: OK - Checked signature is from a valid Apache signature referencing a valid Apache-Email address: OK gpg: Korrekte Signatur von "Julian Feinauer mailto:jfeina...@apache.org>>" [ultimativ] - Checked the zip correctly unpacks

Re: [BUILD-FAILURE]: Job 'PLC4X/PLC4X/features%2Fscraper-jmx-support [features/scraper-jmx-support] [2]'

2018-12-11 Thread Sebastian Rühl
) > > Chris > > > > Am 11.12.18, 10:05 schrieb "Sebastian Rühl" > : > >As I have seen on other apache projects I would vote for enabling this > plugin for plc4x: > > https://wiki.jenkins.io/display/JENKINS/The+Continuous+Integration+Game+plu

Re: [BUILD-FAILURE]: Job 'PLC4X/PLC4X/features%2Fscraper-jmx-support [features/scraper-jmx-support] [2]'

2018-12-11 Thread Sebastian Rühl
As I have seen on other apache projects I would vote for enabling this plugin for plc4x: https://wiki.jenkins.io/display/JENKINS/The+Continuous+Integration+Game+plugin :P > Am 11.12.2018 um 10:03 schrieb Julian

Re: Make getConnection(...) return a Future

2018-12-11 Thread Sebastian Rühl
Hi Julian, Wouldn’t it maybe an option to add a second signature for getConnection() which accepts an Timeout similar to get() from future? This way we wouldn’t break existing connections. Otherwise you could also wrap this by yourself as you done already. Maybe this would be a good addtion to

Re: Make getConnection(...) return a Future

2018-12-11 Thread Sebastian Rühl
@chris: wouldn’t that just add a .get(2, SECONDS) at the end of the already existing statement? Sebastian > Am 11.12.2018 um 09:24 schrieb Christofer Dutz : > > +1 > > Even if I initially thought it would be ok for this to be handled > synchronously as this prevents users from using the

Re: Another successful PLC4X POC :-)

2018-11-30 Thread Sebastian Rühl
Hey, That are great news and im really proud of being part of this. Thanks to all committers for working so hard on this to make this happen :). Great achievement, lets keep rocking the PLC world. Sebastian > Am 30.11.2018 um 18:58 schrieb Christofer Dutz : > > Hi all, > > I'm just traveling

Re: My Summary of the Code-Retreat Mallorca 2018

2018-11-26 Thread Sebastian Rühl
Hi all, Thank you all, it was a great time. To items to add to the result list: * The simulated driver has now subscription support * All modules have now basic(generated) osgi manifests * We have karaf-features for all supported protocols * Improvement on overall coverage Regarding of

Re: Integration of OPC UA into PLC4X

2018-11-25 Thread Sebastian Rühl
Hi Tim, Sure go for it :+1 Sebastian > Am 24.11.2018 um 11:51 schrieb Tim Mitsch : > > > Hallo everybody > > As more and more great features have been and will be integrated into PLC4X > something like OPC-UA server functionality (e.g. based on Eclipse >

Re: [S7] Added support for Siemens LOGO devices

2018-11-23 Thread Sebastian Rühl
Hey Chis, Thats awesome, keep up the good work. Sebastian > Am 23.11.2018 um 17:54 schrieb Christofer Dutz : > > Hi all. > > Today we managed to get support for Siemens LOGO devices working. > It turned out that the protocol implementation of LOGO devices is far less > robust than with the

Re: Plc-opm

2018-10-26 Thread Sebastian Rühl
commit/4ad765e3d7328526a8bbfe7b5918645be74ca603). Again, thanks to Julian for the great work on plc4j-opm, this looks really promising and my first impressions are really good :). Keep up the good work. Sebastian > Am 26.10.2018 um 18:58 schrieb Sebastian Rühl > : > > Hi, > > We still have issues with the

Plc-opm

2018-10-26 Thread Sebastian Rühl
Hi, We still have issues with the build of plc-ops which I currently fix in master. (Still using 0.1.0-SNAPSHOT driver bases) @chris: time for the enforcer plugin sanity checks ;) Sebastian

Re: OPM / Connection Pool

2018-10-26 Thread Sebastian Rühl
Thinks so... > Am 26.10.2018 um 16:33 schrieb Julian Feinauer : > > Hey, > > > is this regarding the feature to return a Future of the send to fail if netty > is not able to send something, or? > > > Julian > > ____ > Von:

Re: OPM / Connection Pool

2018-10-26 Thread Sebastian Rühl
/io/netty/handler/timeout/WriteTimeoutHandler.html> As simple as inserting one line of code in the pipelines :) `channel.pipeline().addLast("readTimeoutHandler", new ReadTimeoutHandler <https://netty.io/4.1/api/io/netty/handler/timeout/ReadTimeoutHandler.html>(30);` > Am 26.10.

Re: Happy birthday Toddy!

2018-10-26 Thread Sebastian Rühl
All the best Toddy ;D > Am 16.10.2018 um 18:40 schrieb Christofer Dutz : > > Happy birthday Toddy! > > Today, one year ago, I did the first commit and look at us now! Wow ... Going > strong and stronger every day. > > So happy the days are over, where I was talking to myself on this list. So

Re: OPM / Connection Pool

2018-10-26 Thread Sebastian Rühl
t; > >Yes, we can directly add the validation hook from commons pool, but I > think we need a plc specific ping method in the api to call as we have no > "common" field or "query" we can issue. > > >Best > >Julian > >

Re: OPM / Connection Pool

2018-10-26 Thread Sebastian Rühl
we have no "common" > field or "query" we can issue. > > > Best > > Julian > > > Von: Sebastian Rühl > Gesendet: Freitag, 26. Oktober 2018 13:23:55 > An: dev@plc4x.apache.org > Betreff: Re: OPM / Connection Pool > > Hi Julian, >

Re: OPM / Connection Pool

2018-10-26 Thread Sebastian Rühl
Hi Julian, Regarding the reuse of Connections: I was aware of that issue but forgot to add a TODO for that (sorry for that). But in general a pool is not a request limiter rater a connection limiter. Therefore the continue use shouldn’t be that big of an issue for the time being (Till we

Re: Question regarding arrays in new API

2018-09-18 Thread Sebastian Rühl
wo roundtrips > to the plc, I only care about the API. > > Perhaps this is another interesting topic for Thursday. > > Best > Julian > > Am 18.09.18, 08:29 schrieb "Sebastian Rühl" > : > >Hi Julian, > >Currently I have no idea if the modbus

Re: Question regarding arrays in new API

2018-09-18 Thread Sebastian Rühl
odbusAddressToKafka.getAddress() + > 1))[0]); > byteBuffer.put(3, > response.getByteArray(Integer.toString(modbusAddressToKafka.getAddress() + > 1))[1]); > return byteBuffer.getInt(); > > Or is there any simpler approach to this? > > Best > Julian > > Am 1

Re: Question regarding arrays in new API

2018-09-18 Thread Sebastian Rühl
Hi Julian, Two bytes would be a register so you could read it like that („register:7"): https://github.com/apache/incubator-plc4x/blob/master/plc4j/protocols/modbus/src/test/java/org/apache/plc4x/java/modbus/ManualPlc4XModbusTest.java

Re: [DISCUSSION] Exception handling during Parsing

2018-09-17 Thread Sebastian Rühl
Hi, Small addition for a rule of thumb: If there is a prober/useful way to react to a error (from dev pov) „user inputs data“ or something other a programmer might need to think about for runtime error a checked exception is appropriate. For Errors which indicate a programming error one should

Re: Define execute operation on Request; remove read/write operations from Reader/Writer

2018-09-13 Thread Sebastian Rühl
or something that can handle the >>> execute). However, in order to construct a immutable PlcReadRequest, >>> currently we still need to obtain a PlcRequest.Builder from the same >>> mutable PlcConnection. I think, if we really want PlcReadRe

Re: Subscriber emulation

2018-09-13 Thread Sebastian Rühl
her > combination doesn't really make sense, does it? > > Chris > > Am 12.09.18, 15:31 schrieb "Sebastian Rühl" > : > >Hi, > >I agree with Julian here; we could implement these things in a plc4j-util > module or something like that (or pooling in

Re: Define execute operation on Request; remove read/write operations from Reader/Writer

2018-09-12 Thread Sebastian Rühl
Hey Andrey, One thing that would stand against this: Adding a execute() would make the PlcReadRequest mutable which is a thing we should avoid (Mutable because it would need a reference store to something that can handle the execute). FYI: I added a mutability test into plc4j-api (which should

Re: Subscriber emulation

2018-09-12 Thread Sebastian Rühl
Hi, I agree with Julian here; we could implement these things in a plc4j-util module or something like that (or pooling in a plc4j-pool). Regarding implementing a plcSubscriber based on PlcReader: I think I did that in the camel component when no plcSubscriber is available if I remember

Re: API Changes proposal

2018-08-30 Thread Sebastian Rühl
Hi Chris, [1] no need to supply a text to „ PlcInvalidFieldException“ as it only requires you to supply the field name. [2] using junit5 for parameterd tests seems to be a big relief :) You should add a Pull-Request with WIP: (work in progress fix) so we can add remarks like above inline as

Re: ASF Slack

2018-08-30 Thread Sebastian Rühl
Hi Chris, Actually I have invited the @asfarchivebot to the channel couple days ago as described (and required) in #general so I would guess everything gets archived now. Sebastian > Am 30.08.2018 um 10:03 schrieb Christofer Dutz : > > Hi all, > > But we should keep in mind, that slack is

Re: Plc4XJPA Layer considerations

2018-08-24 Thread Sebastian Rühl
Provide access to fields via “symbolic names” or aliases. > They could be provided by the system (S7CommPlus) or they could be registered > with the “EntityManager” > > > > > > > >

Immutability of plc4j-api

2018-08-16 Thread Sebastian Rühl
Hi, I integrated the MutabilityDetector into a test: https://github.com/apache/incubator-plc4x/commit/47ff4f0d1c29142c7cb306b159bc5fa24ae8e658 With this we have a working unit test to track the state of

Re: Code-Retreat on Mallorca?

2018-08-02 Thread Sebastian Rühl
Hi Chris, Im fine with this date. Count me in. Sebastian > Am 01.08.2018 um 14:38 schrieb Christofer Dutz : > > Hi all, > > > > Ok ... so I synced my calendar with that of our Finca and I would suggest > 22.11.-25.11. > > > > Who of you would be able to join in for this time? If you

Re: Datatypes in Plc4j

2018-08-02 Thread Sebastian Rühl
Sorry for the typo, I actually meant Julian (I blame the MBP 13’’ keyboard for that ;) > Am 02.08.2018 um 09:54 schrieb Sebastian Rühl > : > > Hi Julia,

Re: Warm welcome and Batching

2018-07-26 Thread Sebastian Rühl
Hi Julian, Welcome to the list and the community. :) By now Christofer should hopefully answered all you question in his response. Im working mostly on the Beckhoff ADS and Modbus implementation at the time being. So in case you reach one of these protocols I am happy to help and feedback is

Re: Refactoring the PLC4X Subscription API?

2018-07-12 Thread Sebastian Rühl
cluster the > types, so everything dealing with subscriptions simply start with > "Subscription" ... > > How about renaming SubsciptionEvent to SubscriptionNotification? But as I > said, I'm not insisting on that naming convention. > > > > Chris > &g

  1   2   >