Re: [DriverGen] Major refactoring and great improvements

2019-05-31 Thread Christofer Dutz
ilder method plus the sub-type fields it contains and is then able to construct an immutable Object. Chris Outlook für Android<https://aka.ms/ghei36> herunterladen From: Julian Feinauer Sent: Thursday, May 30, 2019 12:0

Re: [DriverGen] Major refactoring and great improvements

2019-05-30 Thread Christofer Dutz
t; herunterladen From: Julian Feinauer Sent: Thursday, May 30, 2019 12:06:22 AM To: dev@plc4x.apache.org Subject: Re: [DriverGen] Major refactoring and great improvements Hey Chris, this is one oft he problems I also stumbled across when reasoning and which I consider 'h

Re: [DriverGen] Major refactoring and great improvements

2019-05-29 Thread Niclas Hedhman
I have implemented far too many protocols over the years, in Java, and I typically end up with; Link Layer = serial port, IP, TCP, UDP... Framing / Packet Layer = everything common no matter what payload is. Typicall involves start/stop markers, escaping/replacement, checksums, Operations Layer

Re: [DriverGen] Major refactoring and great improvements

2019-05-29 Thread Julian Feinauer
Hey Chris, this is one oft he problems I also stumbled across when reasoning and which I consider 'hard'. One way to make it way cleaner would be to switch to a layered architecture. If we generally distinguish between Transport Layers and Communication Layer (better anmes are welcome) we can in

Re: [DriverGen] Major refactoring and great improvements

2019-05-29 Thread Christofer Dutz
Hi all, so today I somewhat finished the POJO generation for Java and am currently implementing the IO classes to parse the POJOs (Second step will be serializing) Now I stumbled into following problem (One example from the S7 protocol): [discriminatedType 'S7Message' ['payloadLength'] [con

[DriverGen] Major refactoring and great improvements

2019-05-29 Thread Christofer Dutz
Hi all, I just wanted to give you all an update on how we are progressing on the driver generation front. I just pushed some major refactorings which transition the POC more in the direction of something usable. Here the most important changes: * There are Protocol-modules which are discov