[GitHub] [plc4x] chrisdutz commented on a diff in pull request #545: feat(plc4go): Implementing the correct reading of BOOL types

2023-01-07 Thread GitBox
chrisdutz commented on code in PR #545: URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040985 ## plc4go/protocols/modbus/readwrite/model/DataItem.go: ## @@ -24,30 +24,48 @@ import ( "github.com/apache/plc4x/plc4go/spi/utils"

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #545: feat(plc4go): Implementing the correct reading of BOOL types

2023-01-07 Thread GitBox
chrisdutz commented on code in PR #545: URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040882 ## plc4go/protocols/modbus/readwrite/model/DataItem.go: ## @@ -24,30 +24,48 @@ import ( "github.com/apache/plc4x/plc4go/spi/utils"

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #545: feat(plc4go): Implementing the correct reading of BOOL types

2023-01-07 Thread GitBox
chrisdutz commented on code in PR #545: URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040681 ## plc4go/examples/read/hello_world_plc4go_read.go: ## @@ -31,7 +31,7 @@ func main() { drivers.RegisterModbusTcpDriver(driverManager) // Get a