[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072191526 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java: ## @@ -16,17 +16,25 @@ * specific language governing permissions and limitations * under

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072148900 ## plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml: ## @@ -27,7 +27,7 @@ - + Review Comment: I'm using the logging to output

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072146589 ## plc4j/examples/hello-ads-telemetry/pom.xml: ## @@ -40,13 +43,31 @@ - org.apache.commons - commons-pool2 + org.slf4j + slf4j-api

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072144969 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java: ## @@ -16,17 +16,25 @@ * specific language governing permissions and limitations * under

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120717 ## plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java: ## @@ -136,11 +136,11 @@ public void onConnect(ConversationContext context)

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116724 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache

chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116329 ## plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +