[CANCELLED][VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-27 Thread Christofer Dutz
r RC Chris? J From: Justin Mclean Sent: Friday, September 27, 2019 11:47:56 AM To: dev@plc4x.apache.org Subject: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2 Hi, > I copied the LICENSE from plc4x into th

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-27 Thread Julian Feinauer
That's a good point from Justin... We really hope to be low with releases. Would it be too hard to prepare another RC Chris? J From: Justin Mclean Sent: Friday, September 27, 2019 11:47:56 AM To: dev@plc4x.apache.org Subject: Re: [VOTE] Apache PLC4X Build-Tools

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-27 Thread Christofer Dutz
I copied the LICENSE from plc4x into the plc4x-build-tools and didn't notice the end at first. And I mentioned that in my vote email. Chris Am 27.09.19, 08:44 schrieb "Justin Mclean" : Hi, > But as far as I know there's no Netty in the plugin… Then why is it mentioned in

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-27 Thread Justin Mclean
Hi, > But as far as I know there's no Netty in the plugin… Then why is it mentioned in LICENSE? Thanks, Justin

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-26 Thread Christofer Dutz
But as far as I know there's no Netty in the plugin... Holen Sie sich Outlook für Android<https://aka.ms/ghei36> From: Justin Mclean Sent: Thursday, September 26, 2019 11:49:03 PM To: dev@plc4x.apache.org Subject: Re: [VOTE] Apache PLC4X Build-Tool

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-26 Thread Christofer Dutz
s Code-Generation 1.0.0 RC2 But as far as I know there's no Netty in the plugin... Holen Sie sich Outlook für Android<https://aka.ms/ghei36> From: Justin Mclean Sent: Thursday, September 26, 2019 11:49:03 PM To: dev@plc4x.apache.org Subject: Re: [VOTE] Apache

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-26 Thread Justin Mclean
Hi, -1 (binding) as NOTICE file is missing information I checked: - signatures and hashes fine - LICENSE is OK - NOTICE need some more work(see below) - No unexpected binary files - All source files have ASF headers - Can compile from source Netty has a NOTICE file [1] so relevant portions of

Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-26 Thread Christofer Dutz
+1 (binding) Chris Here what I checked: - SHA512 Hashes are valid - PGP signatures match - signed by apache email address - zip unpacks - Content of LICENSE, NOTICE, README, RELEASE_NOTES is correct (Except that the LICENSE file contains a list of files, that are not contained in the archive)

[VOTE] Apache PLC4X Build-Tools Code-Generation 1.0.0 RC2

2019-09-26 Thread Christofer Dutz
Directly when reviewing the RC1 I noticed the RELEASE_NOTES referenced a SNAPSHOT version, so I immediately did a RC2 Apache PLC4X Build-Tools Code-Generation 1.0.0 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. Voting