Re: Refactoring the PLC4X Subscription API?

i36> herunterladen From: Sebastian Rühl Sent: Thursday, July 12, 2018 2:31:47 PM To: dev@plc4x.apache.org Subject: Re: Refactoring the PLC4X Subscription API? Hi Chris, This would be a little bit better. Maybe we could even introduce sub packages? (‚read‘, ‚write‘, ’subscription’) This way we

Re: Refactoring the PLC4X Subscription API?

Hi Chris, This would be a little bit better. Maybe we could even introduce sub packages? (‚read‘, ‚write‘, ’subscription’) This way we don’t need to prefix everything. Sure when a term is to general like ‚Request‘ one should prefix it accordingly (‚WriteRequest‘, ‚ReadRequest‘, ’SubscriptionReq

Re: Refactoring the PLC4X Subscription API?

Hi Sebastian, I'm not insisting on the term ... for me it was just a way to cluster the types, so everything dealing with subscriptions simply start with "Subscription" ... How about renaming SubsciptionEvent to SubscriptionNotification? But as I said, I'm not insisting on that naming conven

Re: Refactoring the PLC4X Subscription API?

Hi Chris, Looks good to me besides on small thing: Im quite more keen on using the term „Notification" instead of „SubscriptionEventItem“. If you look at other definitions this is a common used term in this space: https://en.wikipedia.org/wiki/Publish%E2%80%93subscribe_pattern

Re: Refactoring the PLC4X Subscription API?

Hi All, I just finished refactoring the API as well as the ADS driver to match these changes. Both the test-suite as well as the manual tests now are executed successfully. Please have a look at the changes I proposed. Hope I didn't break anything. And it's not a final version, just a mo

Re: Refactoring the PLC4X Subscription API?

Sound good +1 from my side. > Am 06.07.2018 um 13:10 schrieb Justin Mclean : > > Go for it > > On Fri., 6 Jul. 2018, 7:43 pm Christofer Dutz, > wrote: > >> Ok, >> >> >> >> I am interpreting the silence as consent and will do the changes I >> proposed. >> >> >> >> Chris >> >> >> >> >>

Re: Refactoring the PLC4X Subscription API?

Go for it On Fri., 6 Jul. 2018, 7:43 pm Christofer Dutz, wrote: > Ok, > > > > I am interpreting the silence as consent and will do the changes I > proposed. > > > > Chris > > > > > > Am 03.07.18, 13:57 schrieb "Christofer Dutz" : > > > > Hi all, > > > > now digging into the subscription

Re: Refactoring the PLC4X Subscription API?

Ok, I am interpreting the silence as consent and will do the changes I proposed. Chris Am 03.07.18, 13:57 schrieb "Christofer Dutz" : Hi all, now digging into the subscription features of EtherNet/IP, I also had a first detailed look at the API for Subscriptions in PL

Refactoring the PLC4X Subscription API?

Hi all, now digging into the subscription features of EtherNet/IP, I also had a first detailed look at the API for Subscriptions in PLC4X. I would like to propose refactoring that a little. I would propose to create SubscriptionRequest and -Response objects containing SubscriptionItems. This w