sruehl merged PR #1178:
URL: https://github.com/apache/plc4x/pull/1178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
chrisdutz opened a new pull request, #1179:
URL: https://github.com/apache/plc4x/pull/1179
Reworked the configuration of transports so a transports configuration
options are referenced by a prefix, that matches the transport code.
So for example in S7 I can customize the timeout like
sruehl commented on PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#issuecomment-1784911154
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
sruehl commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1375982833
##
plc4j/drivers/ads/pom.xml:
##
@@ -140,11 +140,6 @@
plc4j-transport-tcp
0.12.0-SNAPSHOT
-
- org.apache.plc4x
- plc4j-transport-serial
chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376200487
##
plc4j/drivers/firmata/pom.xml:
##
@@ -122,12 +122,6 @@
0.12.0-SNAPSHOT
-
- org.apache.plc4x
- plc4j-transport-serial
Review Comment:
chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376202402
##
plc4j/drivers/c-bus/src/main/java/org/apache/plc4x/java/cbus/configuration/CBusTcpTransportConfiguration.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Sof
chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376205060
##
plc4j/drivers/ads/pom.xml:
##
@@ -140,11 +140,6 @@
plc4j-transport-tcp
0.12.0-SNAPSHOT
-
- org.apache.plc4x
- plc4j-transport-seria
chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376205948
##
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java:
##
@@ -111,7 +112,7 @@ public Plc4xProtocolBase
configurePipeline(C
chrisdutz commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376216805
##
plc4j/transports/pcap-shared/src/main/java/org/apache/plc4x/java/transport/pcap/PcapTransportConfiguration.java:
##
@@ -19,22 +19,18 @@
package org.apache.plc4x.jav
sruehl commented on code in PR #1179:
URL: https://github.com/apache/plc4x/pull/1179#discussion_r1376502186
##
plc4j/drivers/c-bus/src/main/java/org/apache/plc4x/java/cbus/configuration/CBusTcpTransportConfiguration.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Softwa
(Note: You are receiving this because you are subscribed to the dev@
list for one or more projects of the Apache Software Foundation.)
It's back *and* it's new!
We're excited to announce that the first edition of Community over
Code Europe (formerly known as ApacheCon EU) which will be held at th
chrisdutz merged PR #1179:
URL: https://github.com/apache/plc4x/pull/1179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.o
12 matches
Mail list logo