JulianFeinauer commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470423361
Hey, from my perspective all issues are adressed (either directly or via the
new Jira Issues) so I feel fine with this PR.
So feel
Hey Otto,
fair point. I think we should to decide a new release strategy. But if we
consider to keep it as it is now we should not have to vote.
Or?
Julian
Von meinem Mobiltelefon gesendet
Ursprüngliche Nachricht
Betreff: Re: [DISCUSS] Release Strategy for future releases
V
Shamelessly copying Tim's email ... but I did all the checking.
+1 Binding
All checks performed:
* Checked out using the new tooling: OK
* Checked signatures: OK
* Checked the zip correctly unpacks to the expected directory structure: OK
* verify the existence of DISCLAIMER, LICENSE, NOTICE, REA
Shouldn’t you call an official vote for something like this?
On March 6, 2019 at 15:29:18, Christofer Dutz (christofer.d...@c-ware.de)
wrote:
Big +1 for that ;-)
Chris
Am 06.03.19, 21:26 schrieb "Julian Feinauer" :
Hi Chris,
No offense. I agree that we should not stress those lovely peopl
Big +1 for that ;-)
Chris
Am 06.03.19, 21:26 schrieb "Julian Feinauer" :
Hi Chris,
No offense. I agree that we should not stress those lovely people more than
necessary.
So we keep our aim on 0.4 (with whatever accumulates till then) for now and
start regular releases when g
Hi Andreas,
thanks for the first of hopefully many future contributions.
We are in desperate need of people working on the website so I am really happy
to have you keep an eye on empty spaces like the one you found ;-)
Chris
Am 06.03.19, 15:06 schrieb "Sebastian Rühl"
:
Welcome, Andre
+1 for that also. It just feels uncool to shoot 20 emails to the dev@ list with
one click :)
What do others think?
Julian
Von meinem Mobiltelefon gesendet
Ursprüngliche Nachricht
Betreff: Re: [DISCUSS] Send Github Comments to other list
Von: Christofer Dutz
An: dev@plc4x.apa
Hi Chris,
No offense. I agree that we should not stress those lovely people more than
necessary.
So we keep our aim on 0.4 (with whatever accumulates till then) for now and
start regular releases when graduated.
Is this a plan?
Julian
Von meinem Mobiltelefon gesendet
Ursprüngliche
Hi Julian,
That's why I don't like that feature very much as I never read the emails
because of the minimal informational content.
Other projects redirect that to the issues@ list ... how about that?
Chris
Am 06.03.19, 10:24 schrieb "Julian Feinauer" :
Hey all,
as you all just sa
Hi Julian,
I would +1 this, but please have one thing in Mind ... every release we do
requires us to check it (of course) ... but also we have to have people in the
Incubator also validate these releases.
Some people there are under heavy load and I would not like to increase this
load too much
timbo2k commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470257889
changed most of the issue from @JulianFeinauer
for refactoring and rework to be more generic i created issues PLC4X-89 and
PLC4X-90
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263079012
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandler/Trig
Tim Mitsch created PLC4X-90:
---
Summary: TriggeredScraper: Improve Testcoverage and Refactoring of
Code
Key: PLC4X-90
URL: https://issues.apache.org/jira/browse/PLC4X-90
Project: Apache PLC4X
Issue
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263058883
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandler/Trig
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263058508
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandler/Trig
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263057933
##
File path: plc4j/utils/scraper/pom.xml
##
@@ -65,6 +65,11 @@
plc4j-connection-pool
0.4.0
Tim Mitsch created PLC4X-89:
---
Summary: Make Triggers for TriggeredScraper more generic
Key: PLC4X-89
URL: https://issues.apache.org/jira/browse/PLC4X-89
Project: Apache PLC4X
Issue Type: Improvemen
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263054168
##
File path: plc4j/utils/scraper/pom.xml
##
@@ -65,6 +65,11 @@
plc4j-connection-pool
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263046032
##
File path: plc4j/utils/scraper/pom.xml
##
@@ -65,6 +65,11 @@
plc4j-connection-pool
0.4.0
Welcome, Andreas!
Andreas Oswald schrieb am Mi. 6. März 2019 um
10:28:
> Hi Julian, hi everybody,
>
> thanks for merging! I´d like to contribute to the documentation to get to
> know the project better and who knows, someday I´ll also start coding.
>
> So if you have any ideas and suggestions on
thx
On 3/6/19 1:51 PM, Tim Mitsch wrote:
Hello Gunther
This bug is known and we fixed it already in development branch.
The problem is not the amount of variables rather than one-byte variables like
BOOL,BYTE,USINT, ... - Simens uses a filling-byte when acquiring a single
one-byte request
Righ
Hello Gunther
This bug is known and we fixed it already in development branch.
The problem is not the amount of variables rather than one-byte variables like
BOOL,BYTE,USINT, ... - Simens uses a filling-byte when acquiring a single
one-byte request
Right now we have the bugfix-release 0.3.1 as R
I try to read multiple variables synchronous from a S7-1500 and get a
exception. I use the code from the hello world example. When i split up the
variables into smaller units like 5-8 it works. any suggestion on this? Is
there a limit to the number of variables?
Gunther
String vars =
"%Q73:W
Hi Julian, hi everybody,
thanks for merging! I´d like to contribute to the documentation to get to know
the project better and who knows, someday I´ll also start coding.
So if you have any ideas and suggestions on what changes to the documentation
might be helpful do not hesitate to contact m
Hey all,
as you all just saw… all github comments (during review) are send as separate
message to the list.
This adds a lot of noise to the list.
Julian
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822268
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/JobConfigurationImplBu
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262826702
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScr
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262826904
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821540
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScrapeJob.java
##
@
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827199
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827288
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822320
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/ScraperConfiguration.j
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827814
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822739
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/Trigg
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821820
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/Scraper.java
##
@@
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821681
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/Scraper.java
##
@@
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821146
##
File path: plc4j/utils/scraper/pom.xml
##
@@ -65,6 +65,11 @@
plc4j-connection-pool
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827655
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821901
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScraperImpl.java
##
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827260
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandl
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262823550
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScr
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822363
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/ScraperConfigurationBu
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822036
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScraperTaskImpl.java
###
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821317
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ResultHandler.java
#
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262823035
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScr
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822210
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/JobConfigurationImpl.j
Hi all,
perhaps some may find this email too early (as we are still in the process of
doing a Release) but I want to ask / discuss about how we plan to do releases
in the future.
Up till now, they were were infrequent due to the early stage of the project
but now I think we have stabilized well
JulianFeinauer commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470009105
Hey @timbo2k I'm pretty impressed by your work (especially I like the syntax
we now have for the triggering modes).
I added a lot o
48 matches
Mail list logo
