[GitHub] [plc4x] chrisdutz commented on a change in pull request #174: Feature/extended register read

2020-08-02 Thread GitBox
chrisdutz commented on a change in pull request #174: URL: https://github.com/apache/plc4x/pull/174#discussion_r464209291 ## File path: protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec ## @@ -249,7 +249,7 @@ [type 'ModbusPDUReadFileRecordResponseItem' [im

[GitHub] [plc4x] chrisdutz merged pull request #175: See issue reported by Stefano Bossi.

2020-08-02 Thread GitBox
chrisdutz merged pull request #175: URL: https://github.com/apache/plc4x/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [plc4x] chrisdutz commented on pull request #175: See issue reported by Stefano Bossi.

2020-08-02 Thread GitBox
chrisdutz commented on pull request #175: URL: https://github.com/apache/plc4x/pull/175#issuecomment-667820556 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

PreviousRe: s7URIPattern doesn't match

2020-08-02 Thread Christofer Dutz
Actually this is not a bug. We intentionally changed the sytax. Please see the documentation page: https://plc4x.apache.org/users/protocols/s7.html We generally changed the connection string sytax for all drivers to a form that is more homogenous. The reason for the change was that the pervious

Re: Reading Array of Int

2020-08-02 Thread Julian Feinauer
Hi, sorry for the delayed working on it but I just took a look and think I fixed the issue. It seems that arrays where not properly implemented in the S7 Driver (?). I opened up a PR (https://github.com/apache/plc4x/pull/175) and hope that @Christofer Dutz finds some time to have a quick look

[GitHub] [plc4x] JulianFeinauer opened a new pull request #175: See issue reported by Stefano Bossi.

2020-08-02 Thread GitBox
JulianFeinauer opened a new pull request #175: URL: https://github.com/apache/plc4x/pull/175 - removed assert as this is not called in any java setup in S7Field - Added support for parsing of multiple requested fields. Thi

Re: Reading Array of Int

2020-08-02 Thread Julian Feinauer
Hi, I'm looking into it : ) J Am 01.08.20, 16:17 schrieb "Christofer Dutz" : Hi Stefano, I think such a Jira would be a good idea. I’m currently working on the Beckhoff ADS and would try to have a look as soon as possible. Chris Von: Stefano Bossi Antworten an:

Re: s7URIPattern doesn't match

2020-08-02 Thread Gerardo Melia
Sorry about the delay. Here's the jira: https://issues.apache.org/jira/browse/PLC4X-222 Regards On Wed, 22 Jul 2020 at 14:31, Lukas Ott wrote: > Hi Gerado, > > Go to: https://issues.apache.org/jira/projects/PLC4X/summary and create an > account with your mail address. Login and then you can cr

[jira] [Created] (PLC4X-222) Wrong s7URIPattern

2020-08-02 Thread Gerardo Melia (Jira)
Gerardo Melia created PLC4X-222: --- Summary: Wrong s7URIPattern Key: PLC4X-222 URL: https://issues.apache.org/jira/browse/PLC4X-222 Project: Apache PLC4X Issue Type: Bug Components: API