chrisdutz commented on a change in pull request #174:
URL: https://github.com/apache/plc4x/pull/174#discussion_r464209291
##########
File path: protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec
##########
@@ -249,7 +249,7 @@
[type 'ModbusPDUReadFileRecordResponseItem'
[implicit uint 8 'dataLength' '(COUNT(data) * 2) + 1']
Review comment:
I think this needs to be adjusted to "COUNT(data) + 1" as the datatype
changed from short to byte
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
