[GitHub] [poi] pjfanning commented on pull request #312: close XSSFWorkbook on SXSSFWorkbook.write() method

2022-03-10 Thread GitBox
pjfanning commented on pull request #312: URL: https://github.com/apache/poi/pull/312#issuecomment-1064841771 That code change was deliberate as far as I know. Could you change your code to close the SXSSFWorkbook and also to call dispose on the SXSSFWorkbook after you do the write? --

[GitHub] [poi] appbakers opened a new pull request #312: close XSSFWorkbook on SXSSFWorkbook.write() method

2022-03-10 Thread GitBox
appbakers opened a new pull request #312: URL: https://github.com/apache/poi/pull/312 Please check code change. If there is a reason why close is not called after underlying XSSFWorkbook is written. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [poi] asfgit closed pull request #311: Bump mockito-core from 4.3.1 to 4.4.0

2022-03-08 Thread GitBox
asfgit closed pull request #311: URL: https://github.com/apache/poi/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] commented on pull request #311: Bump mockito-core from 4.3.1 to 4.4.0

2022-03-08 Thread GitBox
dependabot[bot] commented on pull request #311: URL: https://github.com/apache/poi/pull/311#issuecomment-1062163637 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] dependabot[bot] opened a new pull request #311: Bump mockito-core from 4.3.1 to 4.4.0

2022-03-08 Thread GitBox
dependabot[bot] opened a new pull request #311: URL: https://github.com/apache/poi/pull/311 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.3.1 to 4.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v4.4.0

[GitHub] [poi] pjfanning commented on pull request #310: Allow sections to have distinct headers and footers

2022-03-06 Thread GitBox
pjfanning commented on pull request #310: URL: https://github.com/apache/poi/pull/310#issuecomment-1060031605 @quimperval could you review https://github.com/apache/poi/commit/83a90487cb315e5ee798a11bcff3938dba8b67ac ? We generally aim to not use the generated CT classes and to use

[GitHub] [poi] pjfanning commented on pull request #310: Allow sections to have distinct headers and footers

2022-03-06 Thread GitBox
pjfanning commented on pull request #310: URL: https://github.com/apache/poi/pull/310#issuecomment-1059962969 Thanks - I added all the changes except for the example - let me have a think about that part. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [poi] asfgit closed pull request #310: Allow sections to have distinct headers and footers

2022-03-06 Thread GitBox
asfgit closed pull request #310: URL: https://github.com/apache/poi/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] quimperval commented on a change in pull request #310: Allow sections to have distinct headers and footers

2022-03-06 Thread GitBox
quimperval commented on a change in pull request #310: URL: https://github.com/apache/poi/pull/310#discussion_r820229853 ## File path: poi-ooxml/src/main/java/org/apache/poi/xwpf/model/XWPFHeaderFooterPolicy.java ## @@ -52,227 +41,236 @@ Licensed to the Apache Software

[GitHub] [poi] pjfanning commented on a change in pull request #310: Allow sections to have distinct headers and footers

2022-03-06 Thread GitBox
pjfanning commented on a change in pull request #310: URL: https://github.com/apache/poi/pull/310#discussion_r820204999 ## File path: poi-ooxml/src/main/java/org/apache/poi/xwpf/model/XWPFHeaderFooterPolicy.java ## @@ -52,227 +41,236 @@ Licensed to the Apache Software

[GitHub] [poi] quimperval commented on a change in pull request #310: Allow sections to have distinct headers and footers

2022-03-05 Thread GitBox
quimperval commented on a change in pull request #310: URL: https://github.com/apache/poi/pull/310#discussion_r820167822 ## File path: poi-ooxml/src/main/java/org/apache/poi/xwpf/model/XWPFHeaderFooterPolicy.java ## @@ -52,227 +41,236 @@ Licensed to the Apache Software

[GitHub] [poi] pjfanning commented on a change in pull request #310: Allow sections to have distinct headers and footers

2022-03-05 Thread GitBox
pjfanning commented on a change in pull request #310: URL: https://github.com/apache/poi/pull/310#discussion_r820119473 ## File path: poi-ooxml/src/main/java/org/apache/poi/xwpf/model/XWPFHeaderFooterPolicy.java ## @@ -52,227 +41,236 @@ Licensed to the Apache Software

[GitHub] [poi] quimperval opened a new pull request #310: Allow sections to have distinct headers and footers

2022-03-05 Thread GitBox
quimperval opened a new pull request #310: URL: https://github.com/apache/poi/pull/310 The below variable was added in the class XWPFHeaderFooterPolicy.java. The variable allows to save a header policy for each section in the document. This variable is used to add header and footer

[GitHub] [poi] quimperval closed pull request #309: Allow each sections to have different headers

2022-03-04 Thread GitBox
quimperval closed pull request #309: URL: https://github.com/apache/poi/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] quimperval opened a new pull request #309: Allow each sections to have different headers

2022-03-04 Thread GitBox
quimperval opened a new pull request #309: URL: https://github.com/apache/poi/pull/309 This commit is to allow distinct sections in a docx document to have distinct headers and footers and addeed the unit tests

[GitHub] [poi] dependabot[bot] commented on pull request #308: Bump guava from 31.0.1-jre to 31.1-jre

2022-03-01 Thread GitBox
dependabot[bot] commented on pull request #308: URL: https://github.com/apache/poi/pull/308#issuecomment-1055885864 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #308: Bump guava from 31.0.1-jre to 31.1-jre

2022-03-01 Thread GitBox
asfgit closed pull request #308: URL: https://github.com/apache/poi/pull/308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] opened a new pull request #308: Bump guava from 31.0.1-jre to 31.1-jre

2022-03-01 Thread GitBox
dependabot[bot] opened a new pull request #308: URL: https://github.com/apache/poi/pull/308 Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre. Release notes Sourced from https://github.com/google/guava/releases;>guava's releases. 31.1 Maven

[GitHub] [poi] dependabot[bot] commented on pull request #307: Bump com.github.jk1.dependency-license-report from 2.0 to 2.1

2022-02-28 Thread GitBox
dependabot[bot] commented on pull request #307: URL: https://github.com/apache/poi/pull/307#issuecomment-1054347906 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #307: Bump com.github.jk1.dependency-license-report from 2.0 to 2.1

2022-02-28 Thread GitBox
asfgit closed pull request #307: URL: https://github.com/apache/poi/pull/307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] opened a new pull request #307: Bump com.github.jk1.dependency-license-report from 2.0 to 2.1

2022-02-28 Thread GitBox
dependabot[bot] opened a new pull request #307: URL: https://github.com/apache/poi/pull/307 Bumps com.github.jk1.dependency-license-report from 2.0 to 2.1. [![Dependabot compatibility

[GitHub] [poi] asfgit closed pull request #306: Bump Saxon-HE from 11.1.1 to 11.2

2022-02-19 Thread GitBox
asfgit closed pull request #306: URL: https://github.com/apache/poi/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] commented on pull request #306: Bump Saxon-HE from 11.1.1 to 11.2

2022-02-19 Thread GitBox
dependabot[bot] commented on pull request #306: URL: https://github.com/apache/poi/pull/306#issuecomment-1045995927 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #305: Bump com.github.spotbugs from 4.8.0 to 5.0.6

2022-02-19 Thread GitBox
asfgit closed pull request #305: URL: https://github.com/apache/poi/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] commented on pull request #305: Bump com.github.spotbugs from 4.8.0 to 5.0.6

2022-02-19 Thread GitBox
dependabot[bot] commented on pull request #305: URL: https://github.com/apache/poi/pull/305#issuecomment-1045995925 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] dependabot[bot] opened a new pull request #306: Bump Saxon-HE from 11.1.1 to 11.2

2022-02-18 Thread GitBox
dependabot[bot] opened a new pull request #306: URL: https://github.com/apache/poi/pull/306 Bumps Saxon-HE from 11.1.1 to 11.2. [![Dependabot compatibility

[GitHub] [poi] dependabot[bot] opened a new pull request #305: Bump com.github.spotbugs from 4.8.0 to 5.0.6

2022-02-17 Thread GitBox
dependabot[bot] opened a new pull request #305: URL: https://github.com/apache/poi/pull/305 Bumps com.github.spotbugs from 4.8.0 to 5.0.6. [![Dependabot compatibility

[GitHub] [poi] katana95 closed pull request #304: ASP-13774 updated build file

2022-02-15 Thread GitBox
katana95 closed pull request #304: URL: https://github.com/apache/poi/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] katana95 closed pull request #304: ASP-13774 updated build file

2022-02-15 Thread GitBox
katana95 closed pull request #304: URL: https://github.com/apache/poi/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] katana95 opened a new pull request #304: ASP-13774 updated build file

2022-02-15 Thread GitBox
katana95 opened a new pull request #304: URL: https://github.com/apache/poi/pull/304 Jira task: https://pdffiller.atlassian.net/browse/ASP-13774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [poi] dependabot[bot] commented on pull request #302: Bump slf4j-api from 1.7.35 to 1.7.36

2022-02-08 Thread GitBox
dependabot[bot] commented on pull request #302: URL: https://github.com/apache/poi/pull/302#issuecomment-1032691148 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] dependabot[bot] commented on pull request #303: Bump slf4j-simple from 1.7.35 to 1.7.36

2022-02-08 Thread GitBox
dependabot[bot] commented on pull request #303: URL: https://github.com/apache/poi/pull/303#issuecomment-1032691169 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #302: Bump slf4j-api from 1.7.35 to 1.7.36

2022-02-08 Thread GitBox
asfgit closed pull request #302: URL: https://github.com/apache/poi/pull/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] asfgit closed pull request #303: Bump slf4j-simple from 1.7.35 to 1.7.36

2022-02-08 Thread GitBox
asfgit closed pull request #303: URL: https://github.com/apache/poi/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] opened a new pull request #303: Bump slf4j-simple from 1.7.35 to 1.7.36

2022-02-08 Thread GitBox
dependabot[bot] opened a new pull request #303: URL: https://github.com/apache/poi/pull/303 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.35 to 1.7.36. Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56;>e9ee55c update

[GitHub] [poi] dependabot[bot] opened a new pull request #302: Bump slf4j-api from 1.7.35 to 1.7.36

2022-02-08 Thread GitBox
dependabot[bot] opened a new pull request #302: URL: https://github.com/apache/poi/pull/302 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.35 to 1.7.36. Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56;>e9ee55c update

[GitHub] [poi] asfgit closed pull request #301: Bump Saxon-HE from 10.6 to 11.1

2022-02-03 Thread GitBox
asfgit closed pull request #301: URL: https://github.com/apache/poi/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] commented on pull request #301: Bump Saxon-HE from 10.6 to 11.1

2022-02-03 Thread GitBox
dependabot[bot] commented on pull request #301: URL: https://github.com/apache/poi/pull/301#issuecomment-1029067570 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] dependabot[bot] opened a new pull request #301: Bump Saxon-HE from 10.6 to 11.1

2022-02-03 Thread GitBox
dependabot[bot] opened a new pull request #301: URL: https://github.com/apache/poi/pull/301 Bumps Saxon-HE from 10.6 to 11.1. [![Dependabot compatibility

[GitHub] [poi] pjfanning closed pull request #300: WIP: fix issue with setColumnAttributes

2022-02-01 Thread GitBox
pjfanning closed pull request #300: URL: https://github.com/apache/poi/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] pjfanning commented on pull request #300: WIP: fix issue with setColumnAttributes

2022-02-01 Thread GitBox
pjfanning commented on pull request #300: URL: https://github.com/apache/poi/pull/300#issuecomment-1027374675 Merged using r1897678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [poi] asfgit closed pull request #299: Last seen data has been cached .

2022-02-01 Thread GitBox
asfgit closed pull request #299: URL: https://github.com/apache/poi/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] pjfanning opened a new pull request #300: WIP: fix issue with setColumnAttributes

2022-01-27 Thread GitBox
pjfanning opened a new pull request #300: URL: https://github.com/apache/poi/pull/300 https://bz.apache.org/bugzilla/show_bug.cgi?id=60541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [poi] pjfanning edited a comment on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
pjfanning edited a comment on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019524102 I reverted my change - see https://github.com/apache/poi/commit/8649a4672c8b092dfe2330df254612719f037181 - the original value matches the Microsoft specification doc -

[GitHub] [poi] pjfanning commented on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
pjfanning commented on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019524102 I reverted my change - see https://github.com/apache/poi/commit/8649a4672c8b092dfe2330df254612719f037181 - the original value matches the Microsoft docs -- This is an automated

[GitHub] [poi] RealBlackCat commented on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
RealBlackCat commented on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019497289 > @RealBlackCat can you close this Pull Request? ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [poi] RealBlackCat closed pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
RealBlackCat closed pull request #298: URL: https://github.com/apache/poi/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] pjfanning commented on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
pjfanning commented on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019496983 @RealBlackCat can you close this Pull Request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [poi] pjfanning commented on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
pjfanning commented on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019496893 I committed https://github.com/apache/poi/commit/981b1ccf033eeb291c6a915cdd6a04958b2f111b and will see if this causes any build/test issues -- This is an automated message from

[GitHub] [poi] pjfanning commented on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
pjfanning commented on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019496450 trunk is the main branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [poi] RealBlackCat commented on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
RealBlackCat commented on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019496160 > A couple of things: > > * this 4.1.0 branch is unsupported > * we prefer PRs to have test cases Can you tell me the version maintained now? I have the same

[GitHub] [poi] pjfanning commented on pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
pjfanning commented on pull request #298: URL: https://github.com/apache/poi/pull/298#issuecomment-1019491665 A couple of things: * this 4.1.0 branch is unsupported * we prefer PRs to have test cases -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [poi] RealBlackCat opened a new pull request #298: fix REL_4_1_0-CORE_PROPERTIES_ECMA376 error

2022-01-23 Thread GitBox
RealBlackCat opened a new pull request #298: URL: https://github.com/apache/poi/pull/298 fix REL_4_1_0 CORE_PROPERTIES_ECMA376 error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [poi] dependabot[bot] commented on pull request #297: Bump slf4j-simple from 1.7.32 to 1.7.33

2022-01-22 Thread GitBox
dependabot[bot] commented on pull request #297: URL: https://github.com/apache/poi/pull/297#issuecomment-1019113824 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #297: Bump slf4j-simple from 1.7.32 to 1.7.33

2022-01-22 Thread GitBox
asfgit closed pull request #297: URL: https://github.com/apache/poi/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] opened a new pull request #297: Bump slf4j-simple from 1.7.32 to 1.7.33

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #297: URL: https://github.com/apache/poi/pull/297 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.32 to 1.7.33. Commits https://github.com/qos-ch/slf4j/commit/2758a974264ab65df3af1d473eb9423ca978c14a;>2758a97 prepare

[GitHub] [poi] pjfanning commented on pull request #296: cache data of exernal workbook

2022-01-21 Thread GitBox
pjfanning commented on pull request #296: URL: https://github.com/apache/poi/pull/296#issuecomment-1018822555 thanks - merged with https://github.com/apache/poi/commit/68ce022531f47497226f42f434cc8a78c000ebbe -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [poi] dependabot[bot] commented on pull request #295: Bump com.github.spotbugs from 4.8.0 to 5.0.5

2022-01-21 Thread GitBox
dependabot[bot] commented on pull request #295: URL: https://github.com/apache/poi/pull/295#issuecomment-1018807272 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #296: cache data of exernal workbook

2022-01-21 Thread GitBox
asfgit closed pull request #296: URL: https://github.com/apache/poi/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] asfgit closed pull request #295: Bump com.github.spotbugs from 4.8.0 to 5.0.5

2022-01-21 Thread GitBox
asfgit closed pull request #295: URL: https://github.com/apache/poi/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] pjfanning commented on a change in pull request #296: cache data of exernal workbook

2022-01-21 Thread GitBox
pjfanning commented on a change in pull request #296: URL: https://github.com/apache/poi/pull/296#discussion_r789822635 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java ## @@ -26,10 +28,12 @@ Licensed to the Apache Software

[GitHub] [poi] aspojo opened a new pull request #296: cache data of exernal workbook

2022-01-21 Thread GitBox
aspojo opened a new pull request #296: URL: https://github.com/apache/poi/pull/296 cache data of exernal workbook ,so that excel can show the cached cell value when the linked workbook not exists -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [poi] dependabot[bot] opened a new pull request #295: Bump com.github.spotbugs from 4.8.0 to 5.0.5

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #295: URL: https://github.com/apache/poi/pull/295 Bumps com.github.spotbugs from 4.8.0 to 5.0.5. [![Dependabot compatibility

[GitHub] [poi] pjfanning commented on pull request #293: issue with rounding in multiply function

2022-01-14 Thread GitBox
pjfanning commented on pull request #293: URL: https://github.com/apache/poi/pull/293#issuecomment-1013561180 merged into POI using r1897066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [poi] pjfanning closed pull request #293: issue with rounding in multiply function

2022-01-14 Thread GitBox
pjfanning closed pull request #293: URL: https://github.com/apache/poi/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] commented on pull request #294: Bump slf4j-api from 1.7.32 to 1.7.33

2022-01-13 Thread GitBox
dependabot[bot] commented on pull request #294: URL: https://github.com/apache/poi/pull/294#issuecomment-1012236959 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #294: Bump slf4j-api from 1.7.32 to 1.7.33

2022-01-13 Thread GitBox
asfgit closed pull request #294: URL: https://github.com/apache/poi/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] opened a new pull request #294: Bump slf4j-api from 1.7.32 to 1.7.33

2022-01-13 Thread GitBox
dependabot[bot] opened a new pull request #294: URL: https://github.com/apache/poi/pull/294 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.32 to 1.7.33. Commits See full diff in https://github.com/qos-ch/slf4j/commits;>compare view

[GitHub] [poi] dependabot[bot] commented on pull request #292: Bump com.github.spotbugs from 4.8.0 to 5.0.4

2022-01-08 Thread GitBox
dependabot[bot] commented on pull request #292: URL: https://github.com/apache/poi/pull/292#issuecomment-1007968720 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #292: Bump com.github.spotbugs from 4.8.0 to 5.0.4

2022-01-08 Thread GitBox
asfgit closed pull request #292: URL: https://github.com/apache/poi/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] pjfanning commented on pull request #292: Bump com.github.spotbugs from 4.8.0 to 5.0.4

2022-01-08 Thread GitBox
pjfanning commented on pull request #292: URL: https://github.com/apache/poi/pull/292#issuecomment-1007711849 spotbugs gradle plugin has stopped working properly since v4.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [poi] pjfanning commented on pull request #292: Bump com.github.spotbugs from 4.8.0 to 5.0.4

2022-01-07 Thread GitBox
pjfanning commented on pull request #292: URL: https://github.com/apache/poi/pull/292#issuecomment-1007711849 spotbugs gradle plugin has stopped working properly since v4.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [poi] dependabot[bot] opened a new pull request #292: Bump com.github.spotbugs from 4.8.0 to 5.0.4

2022-01-06 Thread GitBox
dependabot[bot] opened a new pull request #292: URL: https://github.com/apache/poi/pull/292 Bumps com.github.spotbugs from 4.8.0 to 5.0.4. [![Dependabot compatibility

[GitHub] [poi] dependabot[bot] commented on pull request #291: Bump jmh-core from 1.33 to 1.34

2021-12-24 Thread GitBox
dependabot[bot] commented on pull request #291: URL: https://github.com/apache/poi/pull/291#issuecomment-1000860350 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [poi] asfgit closed pull request #291: Bump jmh-core from 1.33 to 1.34

2021-12-24 Thread GitBox
asfgit closed pull request #291: URL: https://github.com/apache/poi/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] dependabot[bot] opened a new pull request #291: Bump jmh-core from 1.33 to 1.34

2021-12-24 Thread GitBox
dependabot[bot] opened a new pull request #291: URL: https://github.com/apache/poi/pull/291 Bumps jmh-core from 1.33 to 1.34. [![Dependabot compatibility

[GitHub] [poi] asfgit closed pull request #290: Customize Spliterator implementations for better parallelism

2021-12-23 Thread GitBox
asfgit closed pull request #290: URL: https://github.com/apache/poi/pull/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774323457 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774070490 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774068923 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774062182 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774062182 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774062182 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774059777 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774058914 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774054291 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774054291 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r774047111 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java ## @@ -1269,6 +1272,19 @@ public String getSheetName(int sheetIx) {

[GitHub] [poi] pjfanning commented on pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on pull request #290: URL: https://github.com/apache/poi/pull/290#issuecomment-999653538 @daniel-shuy generally looks good - but could you add some test coverage for some of the new methods? We don't necessarily need full coverage but some regression tests would be a

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773959043 ## File path: poi/src/main/java/org/apache/poi/ss/usermodel/Workbook.java ## @@ -220,6 +222,32 @@ Licensed to the Apache Software Foundation (ASF) under

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773958948 ## File path: poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java ## @@ -31,17 +31,8 @@ Licensed to the Apache Software Foundation (ASF)

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773958641 ## File path: poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackageRelationshipCollection.java ## @@ -373,6 +373,14 @@ public

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773929659 ## File path: poi/src/main/java/org/apache/poi/ss/usermodel/Workbook.java ## @@ -220,6 +222,32 @@ Licensed to the Apache Software Foundation (ASF) under

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773928779 ## File path: poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java ## @@ -31,17 +31,8 @@ Licensed to the Apache Software Foundation (ASF)

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773928358 ## File path: poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackageRelationshipCollection.java ## @@ -373,6 +373,14 @@ public

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773928157 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFRow.java ## @@ -100,15 +103,6 @@ public void setCollapsed(Boolean collapsed) {

[GitHub] [poi] pjfanning commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
pjfanning commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773927305 ## File path: poi/src/main/java/org/apache/poi/ss/usermodel/Workbook.java ## @@ -220,6 +222,32 @@ Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773925706 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFRow.java ## @@ -120,18 +121,14 @@ public XSSFSheet getSheet() { } /** -

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773925498 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java ## @@ -786,15 +798,6 @@ public void remove() throws

[GitHub] [poi] daniel-shuy commented on a change in pull request #290: Customize Spliterator implementations for better parallelism

2021-12-22 Thread GitBox
daniel-shuy commented on a change in pull request #290: URL: https://github.com/apache/poi/pull/290#discussion_r773924678 ## File path: poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java ## @@ -100,11 +101,6 @@ public InputStream getWorksheetXMLInputStream()

<    1   2   3   4   5   6   7   8   9   10   >