Re: [VOTE] Apache XmlBeans 5.2.1 release (RC1)

2024-05-23 Thread Marius Volkhart
+1 Thanks for putting this together. Cheers, Marius > On May 22, 2024, at 12:26, PJ Fanning wrote: > > Hi everyone, > > I've prepared artifacts for the release of Apache XmlBeans 5.2.1 (RC1). This > is built with Java 8. > > This is a bug fix and dependency upgrade release. > > > A

Re: Java 11 for POI 5?

2024-02-29 Thread Marius Volkhart
Hello, We do use POI with Java 8. We deploy to customer environments where we don’t have a strong say in the runtime version. We do NOT think POI needs to support Java 8 in the next version. Cheers, Marius > On Feb 25, 2024, at 08:03, Dominik Stadler > wrote: > > So I see two +1 and one

Re: [DISCUSS] dropping support for bin distribution?

2023-02-25 Thread Marius Volkhart
+1 for removing them. Maven downloads, even if not using a Maven-aware build tool, feels like a very reasonable option. Cheers, Marius > On Feb 25, 2023, at 09:37, PJ Fanning wrote: > > Hi everyone, > > The ASF only requires that we do src distributions for releases. We also > publish our

Re: [VOTE] Apache POI 5.2.3 release (RC1)

2022-09-13 Thread Marius Volkhart
+1 from me. Thanks for preparing the release! Cheers, Marius > On Sep 9, 2022, at 16:51, PJ Fanning wrote: > > Hi everyone, > > The Apache POI project is pleased to announce the release of POI 5.2.3. > Featured are a handful of new areas of functionality, and numerous bug fixes. > > See

Re: curvesapi module

2022-01-18 Thread Marius Volkhart
I don’t know the reasoning behind why we don’t need to bring in the module name for curvesapi, but curvesapi should get an automatic module name assigned by the JVM when it gets put on the modulepath, even if it doesn’t define a preferred Automatic-Module-Name. As for making it optional -

Re: [VOTE] Apache POI 5.2.0 release (RC2)

2022-01-12 Thread Marius Volkhart
Dominik's understanding mirrors mine. I just added the updated docs for logging configs, and I'll take a look at adding something about transitive dependencies as well. -- Cheers, Marius Volkhart On Wed, Jan 12, 2022 at 1:48 AM Dominik Stadler wrote: > On Logging dependencies: As far a

Re: [VOTE] Apache POI 5.2.0 release (RC2)

2022-01-07 Thread Marius Volkhart
+1 Thank you for the many hours spent on fixing, triaging, responding, and releasing. Cheers, Marius > On Jan 7, 2022, at 03:44, PJ Fanning wrote: > > Hi everyone, > > I've prepared artifacts for the release of Apache POI 5.2.0 (RC2). > > > The most notable changes in this release are:

Re: Project structure / gradle build

2021-03-23 Thread Marius Volkhart
modularizing a project with it. -- Cheers, Marius Volkhart On Tue, Mar 23, 2021 at 9:30 PM Andreas Beeker wrote: > Hi Devs, > > since a few days / every now and then I try to get into our gradle build, > but I have some problems, because I somehow try to start big (with the >

Re: integration test failures

2021-03-15 Thread Marius Volkhart
Hi PJ, It looks like the changes to POIFSStream from r1887657 are the cause. Those didn't get reverted in r1887660. When I revert those, the tests pass again. -- Cheers, Marius On Mon, Mar 15, 2021, 02:01 fannin...@apache.org wrote: > Hi, > I'm at a bit of a loss as to why this failure has

Re: XmlBeans next release?

2021-03-03 Thread Marius Volkhart
+1 On Thu, Mar 4, 2021, 01:04 fannin...@apache.org wrote: > +1 > > > > > > > On Wednesday 3 March 2021, 23:58:38 GMT, Andreas Beeker < > kiwiwi...@apache.org> wrote: > > > > > > Hi Devs, > > as our POI build has some problems, I would at least try to make XmlBeans > available via maven.org. > >

Logging Documentation Patch

2021-02-21 Thread Marius Volkhart
that is confusing or missing. https://bz.apache.org/bugzilla/show_bug.cgi?id=65153 -- Cheers, Marius Volkhart

Re: Junit5 migration

2021-02-09 Thread Marius Volkhart
Hello, I think I'm running into a reported deadlock in Ant when running the integration tests with the Log4J logging code. https://bz.apache.org/bugzilla/show_bug.cgi?id=64733 When I include either of the legacy result listeners, Ant hangs. When I remove them however, everything passes. This

Re: POI 5.0.1?

2021-01-31 Thread Marius Volkhart
+1 for 5.0.1 from me. -- Cheers, Marius Volkhart On Wed, Jan 27, 2021 at 10:36 PM Andreas Beeker wrote: > Hi Devs, > > when are we ready for POI 5.0.1? > > ... until then I'll continue fixing sonar issues. > > I'll try to fix the "Constant names should comply

Re: Logging

2021-01-25 Thread Marius Volkhart
+1 for b + e +1 for logging changes not holding up 5.0.1 I'll happily do the work, including appropriate changes to the docs on the website. -- Cheers, Marius Volkhart On Mon, Jan 25, 2021 at 8:21 AM Dominik Stadler wrote: > Hi, > > +1 for a 5.0.1 first, there were already a f

Re: Logging

2020-12-13 Thread Marius Volkhart
, and if there's a specific timeline you'd like them on, I can probably accommodate it. -- Cheers, Marius Volkhart On Sun, Dec 13, 2020 at 2:43 PM fannin...@apache.org wrote: > The POILogger is actually a reasonably good implementation. > > default void log(int level, Objec

Modifying picture in HSSF

2020-12-09 Thread Marius Volkhart
to HSSFPictureData, but I haven't thought much about it. Any thoughts, particularly around whether or not such a change is of interest, are most welcome. -- Cheers, Marius Volkhart

Re: Nullability annotations

2020-12-05 Thread Marius Volkhart
I started with a prototype of this and annotated a single package, so we could see what this would look like. Changes with commentary available at https://github.com/apache/poi/pull/203 On 2020/12/05 12:33:19, Marius Volkhart wrote: > Yes, I do not think this should hold up a release. It

Logging

2020-12-05 Thread Marius Volkhart
ommons Logging dependency - Add Log4J API dependency - Remove POILogger API - Remove POILogFactory API - Modify all log sites to use Log4J API - Write new documentation for how POI submits events -- Cheers, Marius Volkhart

Re: Nullability annotations

2020-12-05 Thread Marius Volkhart
.0.0 release because it is a while since > we did any releases. I'd prefer not to delay a release for this. We could > certainly consider it after the next release. > > > > > > On Wednesday 2 December 2020, 22:37:46 GMT, Marius Volkhart > wrote: > > >

Nullability annotations

2020-12-02 Thread Marius Volkhart
not complete it. Again, if the contribution is of interest, I can go into more details of a plan for anyone interested. -- Cheers, Marius Volkhart

Website update

2020-11-11 Thread Marius Volkhart
Hello, I wanted to submit a change for the website (poi.apache.org) but I can't seem to find the files for the documentation. I found them at the last 2.x branch tag. Any information you could provide on how to go about patching the website would helpful! -- Cheers, Marius Volkhart