Re: Java 9+ build issues

2022-01-23 Thread Dominik Stadler
Hi, thanks for reverting, yes, let's keep it this way for now. FYI, I had some actual error appear about duplicated classes when I included the test-jars in a project, probably one of the regression or fuzzy testing efforts. Dominik. On Sat, Jan 22, 2022 at 10:21 PM PJ Fanning wrote: > We

Re: Java 9+ build issues

2022-01-22 Thread PJ Fanning
We don't distribute the test jars - at least not via Maven Central. If we ever did choose to distribute the test jars, we would have to consider not including the main source classes. On Saturday 22 January 2022, 22:19:19 GMT+1, PJ Fanning wrote: Hi Andreas, I'm ok with reverting

Re: Java 9+ build issues

2022-01-22 Thread PJ Fanning
Hi Andreas, I'm ok with reverting the test jar changes. On Saturday 22 January 2022, 22:06:41 GMT+1, Dominik Stadler wrote: Hi, sorry for breaking the build, unfortunately these Java 9+ module stuff is quite a mystery for me as well.We can revert to the previous state if you think

Re: Java 9+ build issues

2022-01-22 Thread Dominik Stadler
Hi, sorry for breaking the build, unfortunately these Java 9+ module stuff is quite a mystery for me as well.We can revert to the previous state if you think your current solution is not final. Would be nice if we can decide to ditch Java 8 at some point so we can simplify the build and then

Re: Java 9+ build issues

2022-01-22 Thread Andreas Beeker
HI, On 22.01.22 15:37, PJ Fanning wrote: I've tried to fix the build issues in Java 9+ that happened after  https://github.com/apache/poi/commit/bba249d52207799dc984efd884353aa4783c1c40 If anyone knows more about Jigsaw modules than me (and I don't much) -- maybe they can have a look. I

Java 9+ build issues

2022-01-22 Thread PJ Fanning
Hi, I've tried to fix the build issues in Java 9+ that happened after  https://github.com/apache/poi/commit/bba249d52207799dc984efd884353aa4783c1c40 This change seems worthwhile so I tried to fix the underlying compile issues but ran into trouble with the test tasks setting module stuff. By