After test-removing/renaming the classes, I'm also +1 for unifying to POIFS.
The current version still contains so many (bloat/) not anymore necessary
classes and its actually fun,
to remove one after another and it still works :)
... of course I try to rewrite the tests where it makes sense.
And
3->4 is already a big upgrade, with lots of other API changes (all the
Enums, for example). I think the direct use of NPOIFS will be small, and
one more easy renaming migration step isn't that bad. I'd rather not keep
even deprecated classes around longer than necessary.
On Mon, Aug 27, 2018 at
v@poi.apache.org
> Betreff: Re: Remove OPOIFSFileSystem for 4.0.0?
>
> After OPOIFS* is now removed, should I rename/normalize/refactor NPOIFS* to
> POIFS*?
>
> Andi
>
>
-
To unsubscribe, e-mail: dev-unsu
I'd prefer if we rename the NPOIFS classes to POIFS but also keep deprecated
NPOIFS subclasses to reduce the impact on users who will be upgrading from
POI 3 to 4.
--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
---
+1 for full refactoring to POIFS*
Gesendet mit BlueMail
Originale Nachricht
Von: Andreas Beeker
Gesendet: Sun Aug 26 19:06:02 GMT-03:00 2018
An: dev@poi.apache.org
Betreff: Re: Remove OPOIFSFileSystem for 4.0.0?
After OPOIFS* is now removed, should I rename/normalize
After OPOIFS* is now removed, should I rename/normalize/refactor NPOIFS* to
POIFS*?
Andi
signature.asc
Description: OpenPGP digital signature
Javen O'Neal-2 wrote
> How many lines of code can we delete by removing this class?
Quite a few ... The issue came to my mind, as I've had a look into #61677
and didn't want to (try to) fix it in two areas. I've started to remove the
OPOIFS* classes yesterday, but this is not so trivial as I thoug
+1.
How many lines of code can we delete by removing this class?
+1 for removal before 4.0.0
Gesendet mit BlueMail
Originale Nachricht
Von: "pj.fanning"
Gesendet: Mon Aug 13 17:54:14 GMT-03:00 2018
An: dev@poi.apache.org
Betreff: Re: Remove OPOIFSFileSystem for 4.0.0?
+1 for 4.0.0 change
--
Sent from: http://apache-poi.
+1 for 4.0.0 change
--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
Hi,
NPOIFS should be quite stable in the meantime - how about removing
OPOIFSFileSystem for/before 4.0.0?
Andi
signature.asc
Description: OpenPGP digital signature
11 matches
Mail list logo
