Re: xmlbeans 3.0.2 release?

2018-09-26 Thread Javen O'Neal
+1 On Wed, Sep 26, 2018, 14:53 pj.fanning wrote: > Should we do an XMLBeans 3.0.2 release? > > > https://issues.apache.org/jira/browse/XMLBEANS-520?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%203.0.2%22 > > > > -- > Sent from:

Re: [RESULT] [VOTE] Apache POI 4.0.0 release (RC1)

2018-09-06 Thread Javen O'Neal
Congrats on the release!

Re: POI 4.0.0 in bugzilla

2018-09-06 Thread Javen O'Neal
Just to verify (I'm in agreement), by disabling 3.17-FINAL from new bugs, that means we are discontinuing support for the 3.17 code branch. If we need to create a bug against 3.17 for a security update, we'll need to ask Nick to temporarily allow new bugs for 3.17-FINAL. In a pinch (Nick is busy),

Re: Remove OPOIFSFileSystem for 4.0.0?

2018-08-14 Thread Javen O'Neal
+1. How many lines of code can we delete by removing this class?

Re: Remove Spanish translation?

2018-07-15 Thread Javen O'Neal
+1 Wrong documentation < No documentation

Re: Use forrest 0.9?

2018-07-10 Thread Javen O'Neal
+1

Re: Adding a function or two...

2018-03-27 Thread Javen O'Neal
HSSF and SS Common tests live here: https://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ XSSF and SS Common tests live here: https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ We separated the tests because HSSF code is compiled and tested without

Re: publishing poi xmlbeans jars

2018-03-08 Thread Javen O'Neal
+1 sending it back to Incubator or subproject of Commons. +0.9 as a subproject of POI. Would prefer Xmlbeans to have its own PMC to make it easier for other Apache devs to make changes, but given how stable/mature it is, the support volume should be low. If/when POI does replace XMLBeans for a

Re: Tests that create documents without closing them

2018-02-11 Thread Javen O'Neal
Yes.. many tests were written without closing the document. Some tests close documents outside of a finally statement and thus won't close the document if the unit test fails. When the JVM exits, it should close any open resources that the unit tests failed to close. This would be really bad for

RE: XMLBeans in 4.0.0 release

2018-01-11 Thread Javen O'Neal
Bringing xmlbeans out of the attic is my vote. I can be one of the Xmlbeans PMCs if all we are missing is a head count and a couple emails to infra. I don't see taking Xmlbeans out of the attic as a huge support burden. It's a stable, complete product and any future development is probably just

Re: classloading xsbs for pptx

2017-11-28 Thread Javen O'Neal
> Should we do this at the Tika level or at the Solr level...or, longer term, should we do this within POI? Definitely POI. CTTable is an implementation detail of POI that we should avoid leaking to outside libraries--even Tika. On Nov 28, 2017 09:03, "Allison, Timothy B."

Re: [GitHub] poi pull request #68: Share chart data implementation between XSSFChart and ...

2017-11-26 Thread Javen O'Neal
Once you've closed out a bug, you can add the change to the 4.0.0 changelog here: https://svn.apache.org/viewvc/poi/site/src/documentation/content/xdocs/status.xml?view=log If you install Apache Ant 1.8+ and Apache Forrest 0.6.*, you can rebuild the HTML site with these changes.

Re: svn commit: r1815988 - /poi/trunk/src/java/org/apache/poi/ss/format/CellDateFormatter.java

2017-11-21 Thread Javen O'Neal
The result of > LocaleUtil.getUserLocale() should be stored in a local variable at the beginning of the method to reduce the number of get calls, as well as producing inconsistent results if the user locale is modified while formatting a cell value. The UserLocale currently uses per-thread

Re: svn commit: r1815994 - in /poi/trunk/src: java/org/apache/poi/sl/usermodel/ java/org/apache/poi/ss/format/ java/org/apache/poi/util/ ooxml/java/org/apache/poi/xssf/usermodel/helpers/ resources/dev

2017-11-21 Thread Javen O'Neal
Should we be lower-casing and switching on codepoints rather than the first character if a string can contain multiple-byte symbols? Modified: poi/trunk/src/java/org/apache/poi/ss/format/CellFormatPart.java URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/

Re: svn commit: r1815953 - /poi/site/src/documentation/content/xdocs/overview.xml

2017-11-21 Thread Javen O'Neal
Does this library version bump need to be reflected in the changelog? On Nov 21, 2017 08:29, wrote: > Author: centic > Date: Tue Nov 21 16:29:24 2017 > New Revision: 1815953 > > URL: http://svn.apache.org/viewvc?rev=1815953=rev > Log: > Adjust version of commons-codec in docu

Re: Financial support to implement bar chart functionality

2017-11-20 Thread Javen O'Neal
Which POi modules do you need chart support for? Just XSSF? There are some improvements in the pipeline. Not sure if it meets your needs though. https://github.com/apache/poi/pull/68 On Nov 20, 2017 02:27, "gmu...@gmail.com" wrote: Dear POI devs, I love Apache POI and have

Re: Charts

2017-11-11 Thread Javen O'Neal
Alain BĂ©arez has contributed several pull requests for a common charting API between XSSF and XSLF via github-68 [1] and github-72 [2] that need a signed contributor license agreement before merging. The CLA is in progress. Sandeep Tiwari recently opened bug 61745 with a patch for XWPF. This is a

Re: [DISCUSS] Getting a fixed version of XMLBeans

2017-11-09 Thread Javen O'Neal
Dave Fisher's (e) seems like the best fix to me. Not everyone needs the XMLBeans fixes, so we shouldn't force it on them in order to update to the latest version of POI. Changing the java package name from org.apache.xmlbeans would break compatibility with XMLBeans 2.3.0 and 2.6.0, as well as any

Re: Non-maintainer upload of bugfixes for the XMLBeans library in the Attic

2017-11-07 Thread Javen O'Neal
Any other project using XMLBeans on Android would likely be affected by the same issue. Making the XMLBeans update within the POI source code or POI maven coordinates would make it more difficult for others to find this update. If we had to change the Java package name to

Re: jaxb problems

2017-10-22 Thread Javen O'Neal
If the schemas aren't backwards compatible and we have CT* classes in the XSSF classes, then wouldn't that mean that we'd need to dynamically import the CT classes and reload the XSSF classes with the correct schema at runtime? This sounds tricky. On Oct 22, 2017 02:30, "Andreas Beeker"

Re: [GitHub] poi pull request #79: Remove the method invocation of toString on a string.

2017-10-15 Thread Javen O'Neal
Looks like all of the String.toString() calls have been removed. I added this to the forbidden APIs list in r1812239 to eliminate this problem from recurring. On Oct 15, 2017 17:42, "Javen O'Neal" <one...@apache.org> wrote: We can probably add String.toString() to forbidden A

Re: [GitHub] poi pull request #79: Remove the method invocation of toString on a string.

2017-10-15 Thread Javen O'Neal
We can probably add String.toString() to forbidden APIs to make sure there aren't other usages of String.toString and that this stays fixed in the future. Even if String.toString gets compiled out and therefore doesn't affect library performance, it could be confusing for someone reading the

Re: Apache POI 4.0/Java 8

2017-09-30 Thread Javen O'Neal
Are we following the guidelines of http://semver.org? If so, should we declare that (possibly in the 4.0.0 release notes)? Semver.org specifies that adding any deprecation warning would need to be done in a minor release and any removal of a deprecated feature be done in a major release. This is

RE: Apache POI 4.0/Java 8

2017-09-15 Thread Javen O'Neal
Yes, and our @deprecated messages should be using the new semantic versioning 4.0.0. On Sep 15, 2017 4:06 AM, "Allison, Timothy B." wrote: Thank you, Dominik!!! So, speaking of 4.0...should we move to semantic versioning: 4.0.0? -Original Message- From: Dominik

Re: [VOTE] Apache POI 3.17 release (RC2)

2017-08-30 Thread Javen O'Neal
Github-69 would be worth reviewing and committing if we're going to do an RC3. On Aug 30, 2017 10:44, "Greg Woolsey" wrote: > I would like an RC3 (sorry, I know this is a fair bit of work) to pick > up r1806623 > fixing bug 61468, as I consider that a rather serious

RE: POI 4.0 and Java 8

2017-08-28 Thread Javen O'Neal
Other stakeholders we should ping? > Vaadin, if they're on Java 6 or 7. On Aug 28, 2017 8:50 AM, "Allison, Timothy B." wrote: Thank you, David! Anyone with contacts at/works for Alfresco? Other stakeholders we should ping? From: David Pilato [mailto:da...@pilato.fr]

Re: Discussions on POI 4.0 / Java7/8 voting

2017-08-21 Thread Javen O'Neal
a) 4.0 b) JDK8 c) yes, of course. d) +1 for sematic versioning. On Aug 21, 2017 09:40, "pj.fanning" wrote: > My votes are: > > a) 4.0 > b) JDK8 (if Tika team agrees to upgrade) > c) yes > d) semver > > > > -- > View this message in context: http://apache-poi.1045710.n5. >

Re: [VOTE] Apache POI 3.17 release (RC1)

2017-08-21 Thread Javen O'Neal
Let's leave this vote open until Dominik and/or Tim can run tests against our corpus and Tika. If this is the last Java 6-compatible release, let's make it a good one. On Aug 21, 2017 3:43 PM, "Andreas Beeker" wrote: > Hi, > > I've prepared artifacts for the release of

Re: Discussions on POI 4.0 / Java7/8 voting

2017-08-20 Thread Javen O'Neal
a) 4.0 b) JDK8 c) yes, of course. How many releases into the 4.x series will we allow for API breaks? If we need to make all of our API changes by the time 4.0 final releases, then we might have a few more 4.0 betas than other releases (and probably wouldn't be ready for 4.0 final until Q2 2018).

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Javen O'Neal
That sounds like a good compromise. On Aug 11, 2017 04:18, "pj.fanning" wrote: > Would it be feasible to keep the existing classes and APIs and have them > delegate to the XDDF impl? > We could immediately deprecate any of these legacy APIs. > > > > -- > View this message

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-07-26 Thread Javen O'Neal
skip in a > particular run, so we don't need to maintain a master list? > > 1. https://maven.apache.org/plugins/maven-shade-plugin/ > > On Wed, Jul 26, 2017 at 11:20 AM Javen O'Neal <javenon...@gmail.com> > wrote: > > > +1 to Apache Commons Math. > > >

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-07-26 Thread Javen O'Neal
or is the preferred solution to implement the functionality > > directly in POI? > > > > On 2017-06-27 15:51 (-0700), "Javen O'Neal" <one...@apache.org> wrote: > > > Greg Woolsey has provided quite a few improvements on Table support for > > &

Re: svn commit: r1801806 - in /poi/trunk/src/ooxml: java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java java/org/apache/poi/xssf/streaming/SheetDataWriter.java testcases/org/apache/poi/xssf/streamin

2017-07-13 Thread Javen O'Neal
I like the idea of using XML-specific startElement, endElement, and writeAttribute functions so that the code doesn't get littered with angle brackets, quotes, and escaping attributes that contain quotes, ampersands, and other characters. I think Java will convert "a"+"b"+"c" into

Re: Java 6 support

2017-07-09 Thread Javen O'Neal
> My 2 cents is that we could continue to support a 3.x branch and backport security fixes and fixes that would be generally useful to a wide community. I could get behind back porting security fixes since they're fairly infrequent and small. Fully maintaining a branch would get tricky as the

Re: Java 6 support

2017-07-09 Thread Javen O'Neal
Then let's kick XMLBeans to POI 5.0 and drop Java 6 ASAP if it's preventing Java 9 support. Java 9 is just around the corner (July 27). We should aim to support Java 9 the day it's released so we're not a reason for other software projects to delay Java 9 adoption. Have we addressed the open

Re: svn commit: r1801373 - in /poi/trunk/src: java/org/apache/poi/sl/usermodel/ ooxml/testcases/org/apache/poi/sl/

2017-07-09 Thread Javen O'Neal
Is this a bug in the JVM implementation or are self-referential generics not allowed per the Java 6 language spec? Are our jenkins slaves using the latest version of Java 6? Looks like Java 6 and 9 support are mutually exclusive here. Time to drop Java 6 support. On Jul 9, 2017 5:27 PM,

Re: Java 6 support

2017-07-09 Thread Javen O'Neal
gt; > I'm -1 on Java 8, as 7 is still needed for Android AFAIK and we get a > number of requests in that area lately. > > Dominik > > On Jul 9, 2017 16:10, "Javen O'Neal" <one...@apache.org> wrote: > > > (writing an iterator in Java is particularly

Re: Java 6 support

2017-07-09 Thread Javen O'Neal
out intermediate code, and somehow Kotlin and other languages managed to compile to Java 6 bytecode... https://stackoverflow.com/questions/22610400/a-program-made-with-java-8-can-be-run-on-java-7 On Jul 9, 2017 15:48, "Javen O'Neal" <one...@apache.org> wrote: +1 I'm in favor of drop

Re: Java 6 support

2017-07-09 Thread Javen O'Neal
+1 I'm in favor of dropping Java 6 support. If users still need to run new versions of POI on old JVMs, they should be able to cross-compile, though it may require some extra tools on their end to modify the bytecode to be compatible with and old JVM. If we can figure out a way to maintain

Fwd: Re: [apache/poi] Trailing commas custom formats (#56)

2017-07-03 Thread Javen O'Neal
Luca has a question about PR #56 on GitHub. Seems relevant to some of the recent internationalization work. Anyone more familiar with the subject care to chime in on the GitHub PR? -- Forwarded message -- From: "Luca Martini" Date: Jul 3, 2017 03:52

Re: svn commit: r1800341 - in /poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/charts: XSSFCategoryAxis.java XSSFChartAxis.java XSSFDateAxis.java XSSFValueAxis.java

2017-06-29 Thread Javen O'Neal
It's probably worth annotating a method that takes or returns a CT* class with @Internal, since CT* classes are an implementation detail to POI ooxml and may not work if we get rid of xmlbeans or fully read the XML into POJOs then recreate the XML on write. On Jun 29, 2017 4:06 PM,

Moving to Git

2017-06-28 Thread Javen O'Neal
A fair increase in Github PR's. Having a git repo might increase the number of (good) PR's we get, as that seems to be where a lot of developers are at. Then we'd be able to have github show merged PR's with credit to the author rather than closed PR's. Looks like some of Apache Commons is going

Re: [RESULT][VOTE] Apache POI 3.17-beta1 release (RC1)

2017-06-27 Thread Javen O'Neal
PMC +1 and 1x PMC 0 votes. > > I release the artifacts now and announce the release on the website, > when I see the files on maven central. > > Andi > > On 6/27/17 10:41 PM, Javen O'Neal wrote: > > +0 from me. I didn't have time to review this release. > > &g

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-06-27 Thread Javen O'Neal
Greg Woolsey has provided quite a few improvements on Table support for XSSF recently (last 6-12 months). Question to the devs: Are tables part of the XLS binary file format, and if so are users interested in a common SS Table interface? Question to Robert: Is LLNL particularly interested in

Re: [VOTE] Apache POI 3.17-beta1 release (RC1)

2017-06-27 Thread Javen O'Neal
+0 from me. I didn't have time to review this release. On Jun 27, 2017 7:48 AM, "Greg Woolsey" wrote: > +1 > > So far so good in my tests, no sudden slow downs in my performance cases. > > On Tue, Jun 27, 2017, 05:15 Allison, Timothy B. > wrote: > >

Re: svn commit: r1799645 - /poi/trunk/src/ooxml/java/org/apache/poi/xssf/util/EMUUtils.java

2017-06-23 Thread Javen O'Neal
if you don't want to wait for "ant jenkins" to run til completion (the ooxml-lite and test-integration targets take a long time and rarely catches issues not caught by the "test" target if you're not adding a test-data/*/* file), then run: "ant test rat-check findbugs forbidden-apis-check".

Developing POI with an IDE

2017-06-20 Thread Javen O'Neal
What IDE's are people using to develop POI? Command line Ant and Gradle on Linux are pretty straight forward. We currently ship POI with an Eclipse .project file, but I'd be interested in adding project files for other IDEs if it makes it easier for people to build POI for the first time. I am

RE: Is it time for POI 3.17-beta1?

2017-06-19 Thread Javen O'Neal
+1 from me. On Jun 19, 2017 04:26, "Allison, Timothy B." wrote: > +1 > > I'd like to get in some small modifications I've been meaning to work on. > I'll have time today. > > -Original Message- > From: Andreas Beeker [mailto:kiwiwi...@apache.org] > Sent: Monday, June

Re: DataTables and formula evaluation

2017-06-09 Thread Javen O'Neal
I think most people using isFormulaCell assume they're working with a cell containing a regular formula, not a cell that belongs to an array formula or table. I'd say it's fair to document this distinction in the JavaDoc and provide a isArrayFormulaCell and isTableFormulaCell if those concepts are

Re: [PATCHES] poi as calculation engine

2017-05-30 Thread Javen O'Neal
tch (8ab388eb78)? [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=61136 [2] https://bz.apache.org/bugzilla/attachment.cgi?id=35014=diff On Tue, May 30, 2017 at 8:49 PM, Javen O'Neal <one...@apache.org> wrote: > How about we adopt a full lazy-evaluation approach for Formula objects? > Eithe

Re: [PATCHES] poi as calculation engine

2017-05-30 Thread Javen O'Neal
How about we adopt a full lazy-evaluation approach for Formula objects? Either _byteEncoding and _encodedTokenLen should be provided or _ptgTokens should be provided. Only when the other is needed should Ptg.readTokens or Ptg.serializeTokens be called. As I understand it, reading and serializing

Re: svn commit: r1796035 - in /poi/trunk: build.gradle build.xml sonar/ooxml/pom.xml

2017-05-24 Thread Javen O'Neal
Is jmh a test dependency or a regular OOXML runtime dependency? I was hoping that we wouldn't have to require jmh for projects using the poi jars. Is it a required dependency because it's used for poi-ooxml-schemas.jar? If so, can we exclude it from that jar so it isn't a dependency? On May 24,

Re: Build failed in Jenkins: POI-DSL-Maven #194

2017-05-15 Thread Javen O'Neal
I broke the Maven and Sonar builds be adding OpenJDK JMH test dependency. It shouldn't be needed for the jars or maven, right? On May 15, 2017 17:06, "Apache Jenkins Server" wrote: > See

Re: svn commit: r1795122 - /poi/trunk/test-data/spreadsheet/~$tableStyle.xlsx

2017-05-14 Thread Javen O'Neal
Not a bad idea svn propedit test-data/spreadsheet On May 14, 2017 16:18, "Greg Woolsey" wrote: Thanks for noticing that I totally missed that I checked in the temp file. Perhaps the ignore list needs this as a pattern to avoid it happening again. On Sun, May 14, 2017,

Re: Not able to add excelsheets to existing excel file

2017-05-10 Thread Javen O'Neal
You create 2 workbook objects if the file exists. One of those workbooks doesn't get closed. If the workbook exists, you read from and write to the same file while the workbook is open. This corrupts the file. Either use the in-place write method (this is a new addition, still in development), or

Re: Java (Apache POI) : How to retrieve comment/annotation and associated highlight text from Microsoft Word?

2017-05-10 Thread Javen O'Neal
:14 PM, Javen O'Neal <one...@apache.org> wrote: > First, if you're using Java 1.5+(?), you can use for-each loops for > more readable code. > for (final XWPFComment comment : adoc.getComments()) { > final String id = comment.getId(); > final String author = comment.get

Re: Java (Apache POI) : How to retrieve comment/annotation and associated highlight text from Microsoft Word?

2017-05-10 Thread Javen O'Neal
First, if you're using Java 1.5+(?), you can use for-each loops for more readable code. for (final XWPFComment comment : adoc.getComments()) { final String id = comment.getId(); final String author = comment.getAuthor(); final String text = comment.getText(); } I don't see anything in

RE: xls record length exception

2017-04-27 Thread Javen O'Neal
No multibytes found; more details in issue. > > Thank you! > > -Original Message- > From: Javen O'Neal [mailto:javenon...@gmail.com] > Sent: Wednesday, April 26, 2017 11:59 PM > To: POI Developers List <dev@poi.apache.org> > Subject: Re: xls record length except

Re: xls record length exception

2017-04-26 Thread Javen O'Neal
Are there any multibyte Unicode characters in the record? Any chance you could open the file in a hex editor or modify the biff record reader to dump the bytes of just that record? If the record contents are sensitive, you could redact all single-byte codepoints with 0x41 ("A"). Of course at

Re: [Bug 61004] org.apache.poi.hssf.usermodel.HSSFWorkbook.createCellStyle() throws NoClassDefFoundError on Google App Engine

2017-04-19 Thread Javen O'Neal
ent #2 from Javen O'Neal <one...@apache.org> --- Do we need to make an effort to exclude java.awt.Color or java.awt.* from our codebase if we want to support restricted environments? If this is a commitment that we can and want to make, we should add the appropriate rules to forbidden apis. Thi

Re: bean-free ooxml streaming readers?

2017-04-04 Thread Javen O'Neal
Absolutely! Since XMLBeans is collecting cobwebs in the attic, we've been looking for a replacement, so long as it doesn't grow the POI codebase too much. On Apr 4, 2017 5:29 AM, "Allison, Timothy B." wrote: Thank you, Javen. On Tika, we now have mostly bean-free SAX-based

Re: POI 3.16 Final?

2017-04-04 Thread Javen O'Neal
+1 ThreadLocal-related bugs: https://bz.apache.org/bugzilla/buglist.cgi?bug_status=__all__=Threadlocal_id=158556=Importance=POI_format=specific On Apr 3, 2017 8:15 AM, "Dominik Stadler" wrote: > Hi, > > soonish sounds fine to me, I can start a first regression run

Re: java.lang.IllegalArgumentException: target is null for type http://schemas.openxmlformats.org/officeDocument/2006/relationships/h

2017-03-16 Thread Javen O'Neal
> wb.write(fileOut); . Fileout is just the directory SXSSFWorkbook.write(File) must be a filename, not a directory. On Mar 16, 2017 2:06 PM, "Dominik Stadler" wrote: > Can you share some standalone sample code which reproduces this? Or at > least some snippets that show

Getting and setting cell value

2017-03-10 Thread Javen O'Neal
Would it be a good idea to add the following two methods to the cell interface so that the switch(cell.getCellType()) code can be taken care of in POI? interface org.apache.poi.ss.usermodel.Cell { Object getCellValue(); void setCellValue(Object value); } We would have to decide how to

RE: xlsb Streaming Reader?

2017-03-06 Thread Javen O'Neal
ng to support OOXML schemas other than the 1st edition? > > -Original Message- > From: Javen O'Neal [mailto:javenon...@gmail.com] > Sent: Monday, March 06, 2017 12:24 PM > To: POI Developers List <dev@poi.apache.org> > Subject: Re: xlsb Streaming Reader? > > +1!

Re: xlsb Streaming Reader?

2017-03-06 Thread Javen O'Neal
+1! We currently have no support for xlsb, either streaming or dom. This would be a welcome addition. We also have bugs open for OOXML strict (bug 57699) and 3rd Edition OOXML schemas (bug 56205), depending on how much you want time you have to contribute in the name of file format support. On

Re: GSOC mentee

2017-03-02 Thread Javen O'Neal
Excel Chart support is certainly an area where help is needed, and it's pretty well sized for one summer worth of effort. I'd be happy to mentor you with Chart support. I've haven't looked into GSOC mentor or mentee requirements yet, but I imagine it includes creating a plan for what you want to

Re: [apache/poi] make line breaks consistent - always use line feeds (LF) (#20)

2017-02-27 Thread Javen O'Neal
Anyone object to a massive EOL conversion? Should we put this off to POI 4.0? doc2unix `find -name "*.java"`; svn propset svn:eol-style `find -name "*.java"`? Do we want to do an indentation whitespace conversion while we're touching all the files and potentially breaking patch files and forks?

Re: Evaluating expressions outside a cell value context

2017-02-23 Thread Javen O'Neal
wrote: > What I meant was external implementations of the Sheet interface. > Everything inside POI that I've done in my branch is fully implemented with > tests and JavaDocs. > > On Sun, Feb 12, 2017 at 7:32 PM Javen O'Neal <javenon...@gmail.com> wrote: > > Anything that

Re: Missing "Ant (latest)"

2017-02-15 Thread Javen O'Neal
t; On Wed, Feb 15, 2017 at 5:15 AM, Javen O'Neal <javenon...@gmail.com> > wrote: > > > Should we mention that if someone builds with Java 6, the highest version > > of Ant they can use is 1.9.9? > > > > https://poi.apache.org/howtobuild.html#Install+Apache+Ant > &g

Re: Missing "Ant (latest)"

2017-02-14 Thread Javen O'Neal
Should we mention that if someone builds with Java 6, the highest version of Ant they can use is 1.9.9? https://poi.apache.org/howtobuild.html#Install+Apache+Ant https://svn.apache.org/viewvc/poi/site/src/documentation/release-guide.txt?revision=1781457=markup#l44 On Feb 14, 2017 00:39,

Re: Evaluating expressions outside a cell value context

2017-02-12 Thread Javen O'Neal
nges. Returning null or false should > be fine though, as the only callers are the new evaluator classes, and > anyone using those would need the new API methods anyway. > > On Sun, Feb 12, 2017, 5:22 PM Javen O'Neal <javenon...@gmail.com> wrote: > > > I haven't read th

Re: Evaluating expressions outside a cell value context

2017-02-12 Thread Javen O'Neal
I haven't read through all your changes on GitHub yet, but all the changes so far look good. I have a few other suggestions to deduplicate some code using SheetUtil and FormulaShifter, but those changes can be made at a later date if needed. You should be able to use git-svn to push your changes.

Re: Build failed in Jenkins: POI-DSL-Maven #93

2017-02-10 Thread Javen O'Neal
I thought it was already doing that with https://svn.apache.org/viewvc/poi/trunk/build.gradle?revision=1782118=markup#l80 80 tasks.withType(JavaCompile) { 81

Re: 3.16 Beta1 vs 3.15 FINAL

2017-02-09 Thread Javen O'Neal
And might as well use 3.16-beta2 since it was just released. There were a couple new minor bugs in this beta, but we decided to release it anyways. Had it been a final release, we would have fixed the bug found from our regression testing, built another RC, gone through the testing process again,

POI 3.16 beta 2 released

2017-02-02 Thread Javen O'Neal
.txt <https://www.apache.org/dyn/closer.lua/poi/release/RELEASE-NOTES.txt> Thank you to all our contributors for making this release possible. On behalf of the Apache POI PMC, Javen O'Neal

Re: Saving modified Workbook in place

2017-02-01 Thread Javen O'Neal
https://bz.apache.org/bugzilla/show_bug.cgi?id=57919 This bug is still open as it hasn't been fully implemented for all constructors and factories yet. On Feb 1, 2017 06:50, "Murphy, Mark" wrote: > I thought that there was a way to save a workbook in place when using

RE: [VOTE] Apache POI 3.16 beta 2 release (RC1)

2017-01-31 Thread Javen O'Neal
Alright. Just a beta. I'll release it in a few hours. On Jan 31, 2017 17:49, "Allison, Timothy B." <talli...@mitre.org> wrote: Argh...sorry, no time this go around... -Original Message----- From: Javen O'Neal [mailto:one...@apache.org] Sent: Tuesday, January 31, 2017

Re: [VOTE] Apache POI 3.16 beta 2 release (RC1)

2017-01-31 Thread Javen O'Neal
Should I wait for the results of common crawl or other regression testing before proceeding with the release? On Jan 30, 2017 16:19, "Andreas Beeker" wrote: > +1 from me > > I have only done a shallow check of the - not any more - usual suspects, > as I'm quite busy with

Re: [VOTE] Apache POI 3.16 beta 2 release (RC1)

2017-01-30 Thread Javen O'Neal
t;slipped in". > > Also ran tests in various projects with the newer version, everything looks > good compared to 3.16-beta1. > > +1 from me! > > Dominik. > > On Fri, Jan 27, 2017 at 7:04 PM, Javen O'Neal <one...@apache.org> wrote: > > > Hallo,

Re: [VOTE] Apache POI 3.16-beta2 release (RC1)

2017-01-27 Thread Javen O'Neal
Please disregard this email chain and respond to the other [VOTE] 3.16 beta 2 email chain. On Jan 27, 2017 12:58 AM, "Javen O'Neal" <one...@apache.org> wrote: > Hallo, > > I have prepared artifacts for the release of Apache POI 3.16-beta2 (RC1). > > Copi

Re: Vote threads - don't reuse old threads

2017-01-27 Thread Javen O'Neal
Looks like Thunderbird was smarter than me at keeping the message headers despite changing the subject. I've resent the 3.16 beta 2 vote email in a fresh email chain. Please disregard the old one. On Jan 27, 2017 4:12 AM, "kiwiwings" wrote: > Hi, > > I've just noticed,

[VOTE] Apache POI 3.16 beta 2 release (RC1)

2017-01-27 Thread Javen O'Neal
, staying open until we have analyzed the results of common-crawl. If no issues are discovered, the planned release announcement date is Thursday, 2017-02-02. Javen O'Neal Steps to verify the build artifacts: wget https://dist.apache.org/repos/dist/dev/poi/KEYS; gpg --import KEYS gpg --import KEYS

[VOTE] Apache POI 3.16-beta2 release (RC1)

2017-01-27 Thread Javen O'Neal
, staying open until we have analyzed the results of common-crawl. If no issues are discovered, the planned release announcement date is Thursday, 2017-02-02. Javen O'Neal Steps to verify the build artifacts: wget https://dist.apache.org/repos/dist/dev/poi/KEYS; gpg --import KEYS gpg --import KEYS

Re: Evaluating expressions outside a cell value context

2017-01-26 Thread Javen O'Neal
Formulas, or at least cell references, show up in a few other places. Any field that could either be a cell reference or a list of literal values, such as specifying either A1:A2 or {1,1} for a data source can't be parsed by just CellReference. ... 3. Named Ranges 4. Pivot Table data source 5.

Re: Time for another release?

2017-01-25 Thread Javen O'Neal
I'll start the release process Fri 2017-01-27 00:00 UTC. After this time, please open feature branches for ongoing development until we have closed the vote for the the release artifacts. On Jan 24, 2017 11:57 PM, "Javen O'Neal" <one...@apache.org> wrote: > We could

Re: Time for another release?

2017-01-24 Thread Javen O'Neal
We could also fork the trunk to a release branch when we want to make a release candidate so that development can continue on the trunk. There likely wouldn't be any changes to make on the branch, so we would end up copying the release branch to a tag and deleting the release branch. This would

Re: Time for another release?

2017-01-24 Thread Javen O'Neal
I sit this one out > :) > > On Tue, Jan 24, 2017 at 8:40 AM Javen O'Neal <one...@apache.org> wrote: > > > Definitely go for a beta. Also want to check out how JCmpApi is doing to > > find API breaks. > > > > Greg, do you want to be release manager for 3.16 b

Re: Time for another release?

2017-01-24 Thread Javen O'Neal
Definitely go for a beta. Also want to check out how JCmpApi is doing to find API breaks. Greg, do you want to be release manager for 3.16 beta 2? If not, I can do it. On Jan 23, 2017 23:52, "Andreas Beeker" wrote: > I would go for another beta soon. > Who will be the

Re: EMF/WMF files from our regression corpus

2017-01-19 Thread Javen O'Neal
All the EMF/WMF code is in scratchpad, is experimental, and hasn't seen a final release yet. At least until we have released 3.16 final, there's no need to @deprecated, @Deprecated, or @Removal any of the EMF code. On Jan 19, 2017 2:28 PM, "Andreas Beeker" wrote: > Hi

Re: Using Apache Commons IO

2017-01-18 Thread Javen O'Neal
-Original Message- > > From: Nick Burch [mailto:apa...@gagravarr.org] > > Sent: Tuesday, January 17, 2017 3:35 PM > > To: POI Developers List <dev@poi.apache.org> > > Subject: Re: Using Apache Commons IO > > > > On Tue, 17 Jan 2017, Javen O'Neal wrote: &

Using Apache Commons IO

2017-01-17 Thread Javen O'Neal
In the spirit of "the best code is no code", how would you feel about replacing our endian classes and IOUtils with Apache Commons IO? The downside is that it adds a dependency. https://poi.apache.org/overview.html#components

Re: Build failed in Jenkins: POI-DSL-1.8 #44

2017-01-12 Thread Javen O'Neal
Is this a transient javadoc error? Or did the jenkins javadoc get built by a different version of Java? I didn't touch the files that are have the reported javadoc errors. On Jan 12, 2017 05:18, "Apache Jenkins Server" wrote: > See

Re: [Bug 60519] Extractor for *SSF embeddings

2017-01-05 Thread Javen O'Neal
As a side note, I suspect there are some interesting metadata items that > we can pull out of EMFs... For example, I saw some text content of the PDF in > the EMF portion of the mac EMF. I also saw some original paths for the > embedded file in the EMF. > > -Original Message-

Re: [Bug 60519] Extractor for *SSF embeddings

2017-01-04 Thread Javen O'Neal
What about an Apache incubator project for reading and writing EMF(+) files? On Jan 4, 2017 2:53 PM, "Andreas Beeker" wrote: > Hi Tim, > > every now and then I play with the idea to provide an EMF parser like the > WMF parser, to render images inside slideshows. This could

RE: [Bug 60519] Extractor for *SSF embeddings

2017-01-04 Thread Javen O'Neal
The Windows Enhanced Metafile format isn't specific to Microsoft Office documents, so it probably doesn't belong in POI. Even if we advertise this as rudimentary support only, it would likely generate bug reports for POI, detracting from the time we spend on reading and writing Office documents.

Re: [GitHub] poi pull request #44: update java doc for CellStyle#setDataFormat

2017-01-03 Thread Javen O'Neal
Thanks for the pull request, sixinli! Merged in svn r1777260. On Jan 3, 2017 23:00, "asfgit" wrote: > Github user asfgit closed the pull request at: > > https://github.com/apache/poi/pull/44 > > > --- > If your project is set up for it, you can reply to this email and

Re: Too much memory is used by a hyperlink in a spreadsheet

2016-11-24 Thread Javen O'Neal
Thanks for the submission. I have opened bug 60416 [1] to work on this and committed your patch. Discussion can take place either on the bug or on the dev@poi.apache.org mailing list. I have bcc'd u...@poi.apache.org out of the email responses. [1]

Re: svn commit: r1771220 - in /poi/site: publish/download.html src/documentation/content/xdocs/download.xml

2016-11-24 Thread Javen O'Neal
Is this sentence not enough? These builds should not be used in production: they are only intended for use by developers to help with resolving bugs and evaluating new features. http://svn.apache.org/viewvc/poi/site/publish/download.html?r1=1771220=1771219=1771220_format=l On Thu, Nov 24, 2016

Re: Interesting question on SO

2016-11-21 Thread Javen O'Neal
Looks like there is at least one other non-Apache package using the org.apache.poi namespace. [1] I would approach this from a friendly direction first. I'm assuming they needed an o.a.p namespace so they would have access to protected and package-private methods and variables. The alternative

  1   2   3   >