Re: svn commit: r1801806 - in /poi/trunk/src/ooxml: java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java java/org/apache/poi/xssf/streaming/SheetDataWriter.java testcases/org/apache/poi/xssf/streamin

2017-07-13 Thread pj.fanning
I thought that the writeAttribute made the code a bit easier to read. Also, concatenating strings before writing them to the Writer does add overhead. I did some similar work (with others) on a similar writer implementation in February and removing the string concats and using additional write call

Re: svn commit: r1801806 - in /poi/trunk/src/ooxml: java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java java/org/apache/poi/xssf/streaming/SheetDataWriter.java testcases/org/apache/poi/xssf/streamin

2017-07-13 Thread Javen O'Neal
I like the idea of using XML-specific startElement, endElement, and writeAttribute functions so that the code doesn't get littered with angle brackets, quotes, and escaping attributes that contain quotes, ampersands, and other characters. I think Java will convert "a"+"b"+"c" into StringBuilder("a