Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
@pferrel It looks to be impossible to solve in the current template
mechanism. I believe that keeping templates for the latest and default stack
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14
@hareeshmu We are progressing updating templates just now, but this
template is not updated for PredictionIO 0.12.0 yet. Some code modifications
seem
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-similar-product/pull/17
LGTM!
---
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-recommender/pull/19
LGTM!
---
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/12
LGTM!
---
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/440
[PIO-101] Document usage of Plug-in of event server and engine server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/438
[PIO-129] Move CLI document
There are links to CLI document in the deploy section and collecting data
section of the side menu, but if these links are clicked, the side menu
[
https://issues.apache.org/jira/browse/PIO-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-129:
--
Description:
There are links to CLI document in the deploy section and collecting data
section
[
https://issues.apache.org/jira/browse/PIO-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-129:
--
Description:
There are links to CLI document in the deploy section and collecting data
section
[
https://issues.apache.org/jira/browse/PIO-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-129:
--
Attachment: (was: cli_doc1.png)
> CLI document does not expand side m
[
https://issues.apache.org/jira/browse/PIO-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-129:
--
Attachment: (was: cli_doc2.png)
> CLI document does not expand side m
[
https://issues.apache.org/jira/browse/PIO-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-129:
--
Description:
There are links to CLI document in the deploy section and collecting data
section
Naoki Takezoe created PIO-129:
-
Summary: CLI document does not expand side menu
Key: PIO-129
URL: https://issues.apache.org/jira/browse/PIO-129
Project: PredictionIO
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/PIO-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190643#comment-16190643
]
Naoki Takezoe commented on PIO-101:
---
[~sasher] Sure. I will do it.
> Document usage of Plug-in of ev
t;
> * James Taylor <jtay...@apache.org>
> * Justin Yip <yipjus...@apache.org>
> * Kenneth Chan <kenn...@apache.org>
> * Lars Hofhansl <la...@apache.org>
> * Lee Moon Soo <m...@apache.org>
>
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/437
LGTM!
---
rovided at the Maven staging repo here:
>>> > > https://repository.apache.org/content/repositories/
>>> > > orgapachepredictionio-1021/
>>> > >
>>> > > All JIRAs completed for this release are tagged with 'FixVersion =
>>> > > 0.12.0-incubating'. You can view them here: https://issues.apache.or
>>> > > g/jira/secure/ReleaseNote.jspa?version=12340591=12320420
>>> > >
>>> > > The artifacts have been signed with Key: ytX8GpWv
>>> > >
>>> > > Please vote accordingly:
>>> > >
>>> > > [ ] +1, accept RC as the official 0.12.0 release
>>> > > [ ] -1, do not accept RC as the official 0.12.0 release because...
>>> > >
>>> >
>>>
--
Naoki Takezoe
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/428
Nice catch! LGTM!
---
If we are to graduate, who should we include in the list of the
>> initial
>> > PMC?
>> > 3. If we are to graduate, who should be the VP of the initial PMC?
>> >
>> > These points are relevant for graduation. Please take a look at the
>> > official graduation guide:
>> > http://incubator.apache.org/guides/graduation.html.
>> >
>> > In addition, Sara and I have been working to transfer the PredictionIO
>> > trademark to the ASF. We will keep you updated with our progress.
>> >
>> > I would also like to propose to cut a 0.12.0 release by merging JIRAs
>> that
>> > have a target version set to 0.12.0-incubating for graduation. 0.12.0
>> will
>> > contain cleanups for minor license and copyright issues that were pointed
>> > out in previous releases by IPMC.
>> >
>> > Let me know what you think.
>> >
>> > Regards,
>> > Donald
>>
>>
--
Naoki Takezoe
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/426
Fix use of case class in textclassifier example
The text-classifier example is fixed in
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14.
You can
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/421
@mars LGTM! but sorry for conflict with my previous commit:
6789dbeb71b1cc7f13a385032da6fbc3b8cf7a12
---
If your project is set up for it, you can reply to this email and have your
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14
Fix use of case class
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/takezoe/incubator-predictionio
[
https://issues.apache.org/jira/browse/PIO-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-110:
--
Affects Version/s: (was: 0.12.0-incubating)
0.11.0-incubating
> Refactor com
[
https://issues.apache.org/jira/browse/PIO-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-110:
--
Target Version/s: 0.12.0-incubating (was: 0.11.0-incubating)
> Refactor common code sha
[
https://issues.apache.org/jira/browse/PIO-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe resolved PIO-110.
---
Resolution: Fixed
Fix Version/s: 0.12.0-incubating
Target Version/s: 0.11.0-incubating
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/425
@mars Some of them I suggested are applied by this pull request. But as a
result of checking the whole codebase, I thought that I shouldn't apply some of
them to the whole
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/425#discussion_r135380673
--- Diff:
core/src/main/scala/org/apache/predictionio/controller/PAlgorithm.scala ---
@@ -115,15 +115,12 @@ abstract class PAlgorithm[PD, M
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/425
All tests are passed!
@shimamoto Could you review this request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user takezoe reopened a pull request:
https://github.com/apache/incubator-predictionio/pull/425
[PIO-110] Refactoring
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio
refactor-common-code
Github user takezoe closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/425
Closed and reopened to re-run Travis test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/421
> I addressed all your Scala style & usage suggestions.
ð
> Still need to take care of the threadsafety issue with the singleton
client.
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419406
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala
---
@@ -107,37 +107,32
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134416803
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala
---
@@ -18,27 +18,84
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134398339
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399760
--- Diff:
data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala ---
@@ -461,4 +463,11 @@ object Storage extends Logging
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134417513
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala
---
@@ -18,27 +18,84
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419379
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala
---
@@ -107,37 +107,32
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399019
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419425
--- Diff:
storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala
---
@@ -107,37 +107,32
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/423
@haginot You should merge this branch into the `livedoc` branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/405
@dszeto I confirmed that my fix has been applied. Thanks for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
builds.apache.org/job/PredictionIO-build-site/
> https://builds.apache.org/job/PredictionIO-publish-site/
>
> It looks like an upgrade of Jenkins might have broken the linkage between
> build and publish. I have fixed it by enabling Build Authorization.
>
> On Thu, Aug 3, 2017 at 8:
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/405
Merged to `livedoc` branch but the web site hasn't been updated yet.
I'm wondering how is docs deployed on the web site...
---
If your project is set up for it, you can reply
Takezoe
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/415
Update license checker configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio
license
[
https://issues.apache.org/jira/browse/PIO-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094896#comment-16094896
]
Naoki Takezoe commented on PIO-106:
---
I tried to add cleanup step to storage some time ago, but I couldn't
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio-template-similar-product/pull/16
Fix use of case class
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/takezoe/incubator-predictionio
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/412#discussion_r127852943
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/BatchPredict.scala ---
@@ -0,0 +1,228 @@
+/*
+ * Licensed
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/410
Fix use of case class in classification examples
According to this template fix:
https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/11
You
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/411
Fix use of case class in classification examples (docs)
According to this template fix:
https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/11
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio-template-attribute-based-classifier/pull/11
Fix use of case class
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/takezoe/incubator
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio-template-recommender/pull/18
Fix use of case class
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/takezoe/incubator-predictionio
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/408
Fix use of case class in recommendation examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/409
Fix use of case class in recommendation examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/407
[PIO-104] Make proper implementation of plugins
- Remove start() method of EventServerPlugin and EngineServerPlugin
- Send prediction result to outputSniffers in the engine
Naoki Takezoe created PIO-104:
-
Summary: Make proper implementation of plugins
Key: PIO-104
URL: https://issues.apache.org/jira/browse/PIO-104
Project: PredictionIO
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/PIO-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085181#comment-16085181
]
Naoki Takezoe commented on PIO-101:
---
I think we should cleanup plugins implementation before documenting
[
https://issues.apache.org/jira/browse/PIO-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079814#comment-16079814
]
Naoki Takezoe commented on PIO-62:
--
It seems that already it has been fixed in:
https://github.com/apache
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/405
I put a incubator logo and disclaimer on the footer like Impala
(http://impala.incubator.apache.org/) or Hivemail
(http://hivemall.incubator.apache.org/), but it might be enough
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/405
[PIO-63]Add incubator logo and disclaimer to web site
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/403
I checked fixed documents through test of examples in #400. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
[
https://issues.apache.org/jira/browse/PIO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075844#comment-16075844
]
Naoki Takezoe commented on PIO-88:
--
Unset a target version once.
> Scripts for Wind
[
https://issues.apache.org/jira/browse/PIO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-88:
-
Target Version/s: (was: 0.12.0-incubating)
> Scripts for Wind
[
https://issues.apache.org/jira/browse/PIO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075842#comment-16075842
]
Naoki Takezoe commented on PIO-88:
--
I requested this, but we can't start this work soon and needs a lot
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/402
[PIO-83] Replace semverfi with java-semver
Replace [semverfi](https://github.com/softprops/semverfi) with java-semver
because semverfi is no longer maintained. It stopped in Scala
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/397
@dszeto I added `tests/check_libraries.sh` to check library dependencies
and it's also available on the Travis build. It would be failed when there are
any changes in library
Github user takezoe closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
[
https://issues.apache.org/jira/browse/PIO-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe closed PIO-92.
Resolution: Won't Fix
Keep current code for now because it works with the latest version of HBase
(1.2.6) fine
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@dszeto Thanks for your support. I updated docs in
e3f8307891ae0a5b287855ad83c41379c4e1e8bc so close this pull request and
[PIO-92](https://issues.apache.org/jira/projects/PIO/issues
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@dszeto @pferrel How about keeping current code but update the
prerequisites section of installation guide to clarify supported versions?
About HBase, PIO supports 0.98.5
[
https://issues.apache.org/jira/browse/PIO-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe resolved PIO-90.
--
Resolution: Fixed
> Improve /batch/events.json endpoint performa
[
https://issues.apache.org/jira/browse/PIO-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-90:
-
Fix Version/s: 0.12.0-incubating
> Improve /batch/events.json endpoint performa
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/397
I checked the license of all non-ASL libraries and all them can be included
as binary form in the distribution. I added their license text to `LICENSE.txt`
and updated `make
Github user takezoe closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@pferrel and I found 3 versions of HBase at least in `build.sbt` and
documentation, so I'm not sure what versions are supported in the current
PredictionIIO.
- 0.98.5
Github user takezoe closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/396
Close this request because sbt-license-report plugin looks more useful to
extract license information of depended libraries.
---
If your project is set up for it, you can reply
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/396
[sbt-license-report plugin](https://github.com/sbt/sbt-license-report)
might be more suitable for this purpose than sbt-dependency-graph plugin. I'm
testing it...
---
If your
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
https://github.com/apache/incubator-predictionio/pull/395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/395
[PIO-92] Bump HBase to 1.2.6
This request upgrade only HBase dependency. Some methods have been
deprecated, but they are not fixed in this request for backward compatibility.
You
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@pferrel Following methods have been deprecated since HBase 1.0.0. Since
they are still alive in HBase 1.2.6 current code works fine with 1.2.6.
I think it's not necessary
type correctly.
Could anyone help me?
Regards,
--
Naoki Takezoe
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@dszeto Documentation updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/391
[PIO-92] Bump HBase to 1.2.6
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio hbase_upgrade
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/389
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
[
https://issues.apache.org/jira/browse/PIO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe resolved PIO-91.
--
Resolution: Fixed
> hadoop-hdfs artifact missing when creating binary version of Predictio
[
https://issues.apache.org/jira/browse/PIO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naoki Takezoe updated PIO-91:
-
Fix Version/s: 0.12.0-incubating
> hadoop-hdfs artifact missing when creating binary version of Predictio
Naoki Takezoe created PIO-92:
Summary: HBase version is too old
Key: PIO-92
URL: https://issues.apache.org/jira/browse/PIO-92
Project: PredictionIO
Issue Type: Improvement
Affects Versions
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/390
I already merged this pull request into both of `livedoc` and `develop`
branch, but it has not been closed automatically. It's strange...
---
If your project is set up for it, you
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151665
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCChannels.scala
---
@@ -0,0 +1,56
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151628
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCApps.scala
---
@@ -0,0 +1,59
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120154775
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/CreateServer.scala ---
@@ -198,7 +198,7 @@ object CreateServer extends
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151427
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCEvaluationInstances.scala
---
@@ -29,8 +29,9 @@ class
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151860
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCModels.scala
---
@@ -0,0 +1,56
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/387
@dszeto As our concern, is it possible to test with Oracle database on
Travis-CI or ASF's Jenkins? If no, it might be difficult to guarantee this
Oracle support works correctly over
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151731
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCEngineInstances.scala
---
@@ -0,0 +1,55
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151544
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCAccessKeys.scala
---
@@ -0,0 +1,45
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120153688
--- Diff:
data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala ---
@@ -306,9 +306,18 @@ object Storage extends Logging
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120150849
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCChannels.scala
---
@@ -29,14 +29,15 @@ class
1 - 100 of 147 matches
Mail list logo
