Re: PIO-20 problems

[Pat Ferrel]

With the keystore my template-based integration test passes and I’ve put the 
keystore back in. The diffs on PRs on Github seem completely wonky right now. 
Git diff is trustworthy at least.

Will try the python tests now too.

Thanks guys, working smoothly now.


On Aug 11, 2016, at 11:53 AM, Donald Szeto  wrote:

Hi all,

I went ahead and pulled Pat's branch, performed a clean build, and repeated
the quick start guide of the Scala parallel recommendation template. I
could produce the same problem, and root caused it to a missing
conf/keystore.jks file.

I think with SSL now optional, we should not be distributing a KeyStore
file. We can either quick fix it now by putting this file back, or modify
SSLConfiguration to not look for this file when SSL support is off.

Regards,
Donald

On Thu, Aug 11, 2016 at 8:03 AM, Chan Lee  wrote:

> I want to clarify some points:
> 
> 2) Deploying templates do not require SSL. If you execute
> ./make-distribution.sh using the current develop branch (provided you
> change the namespace in the template from io.prediction to
> org.apache.predictionio), you can deploy without SSL on localhost. The
> travis tests also do not use SSL and pass as can be seen in
> https://travis-ci.org/Ziemin/incubator-predictionio.
> 
> 3) You can run the tests locally the same way it is run on travis
> ('python3 ${PIO_DIR}/tests/pio_tests/tests.py'). It is documented in the
> README in the same directory, but maybe this was not clear enough. If you
> have any additional questions or run into issues executing the tests,
> please let me know.
> 
> Thanks,
> Chan
> 
> On Thu, Aug 11, 2016 at 6:07 AM, Pat Ferrel  wrote:
> 
>> I’m always disinclined to commit code that has not been tested. However
>> many things in the current state of the develop branch seem broken or at
>> least too big to address in a single commit.
>> 
>> 1) Style test fail in Travis that are not runnable or at least have not
>> been documented for local build. I have fixed these.
>> 2) SSL seems to still be required for deploying an engine, PIO-1 may not
>> have addressed this. Has anyone tried to build and test a template yet
>> without SSL? Unless someone can state otherwise I’m inclined to ignore this
>> failure for now since it is out of scope for this commit.
>> 3) the test framework has been integrated into Travis but again no
>> documented way to run it locally and some of the travis errors seem
>> spurious. I am also not inclined to wait for this to be fixed unless
>> someone can point out real problems it is discovering and send instructions
>> for how to run it locally.
>> 
>> Before the extra travis tests I was able to build and train a template,
>> which fails on deploy with an SSL config error. Since the PR does not
>> strictly touch any templates I am going to have to ignore this serious
>> issue and address it in Jira.
>> 
>> Unless someone vetos this I plan to reluctantly push the PR with these
>> non-trivial issues remaining.
>> 
>> 
>> 
> 

[GitHub] incubator-predictionio pull request #273: PIO-20 Merge ActionML fork

[dszeto]

Github user dszeto commented on a diff in the pull request:


https://github.com/apache/incubator-predictionio/pull/273#discussion_r74461039
  
--- Diff: build.sbt ---
@@ -19,7 +19,7 @@ import UnidocKeys._
 
 name := "pio"
 
-version in ThisBuild := "0.9.7-SNAPSHOT"
+version in ThisBuild := "0.10.0-snapshot"
--- End diff --

This is causing integration tests to fail. `snapshot` needs to be uppercase.

RE:

https://github.com/apache/incubator-predictionio/blob/develop/tests/docker-files/init.sh#L27

https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN401



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #273: PIO-20 Merge ActionML fork

[dszeto]

Github user dszeto commented on a diff in the pull request:


https://github.com/apache/incubator-predictionio/pull/273#discussion_r74463515
  
--- Diff: manifest.json ---
@@ -1 +1,2 @@

-{"id":"ipNrDsdxAtsDjZHRSAqfgOTL0PztjuR3","version":"b6a10c9f995426f7ee739156066bc26b577f2f09","name":"pio","description":"pio-autogen-manifest","files":[],"engineFactory":""}
\ No newline at end of file

+{"id":"ipNrDsdxAtsDjZHRSAqfgOTL0PztjuR3","version":"b6a10c9f995426f7ee739156066bc26b577f2f09","name":"pio","description":"pio-autogen-manifest","files":[],"engineFactory":""}
+
--- End diff --

I believe it is committed by accident. It has nothing to do with the main 
codebase and should be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #240: Fix spelling mistakes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/240


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #228: Update dase.html.md.erb

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/228


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PIO-20 problems

[Donald Szeto]

Hi all,

I went ahead and pulled Pat's branch, performed a clean build, and repeated
the quick start guide of the Scala parallel recommendation template. I
could produce the same problem, and root caused it to a missing
conf/keystore.jks file.

I think with SSL now optional, we should not be distributing a KeyStore
file. We can either quick fix it now by putting this file back, or modify
SSLConfiguration to not look for this file when SSL support is off.

Regards,
Donald

On Thu, Aug 11, 2016 at 8:03 AM, Chan Lee  wrote:

> I want to clarify some points:
>
> 2) Deploying templates do not require SSL. If you execute
> ./make-distribution.sh using the current develop branch (provided you
> change the namespace in the template from io.prediction to
> org.apache.predictionio), you can deploy without SSL on localhost. The
> travis tests also do not use SSL and pass as can be seen in
> https://travis-ci.org/Ziemin/incubator-predictionio.
>
> 3) You can run the tests locally the same way it is run on travis
> ('python3 ${PIO_DIR}/tests/pio_tests/tests.py'). It is documented in the
> README in the same directory, but maybe this was not clear enough. If you
> have any additional questions or run into issues executing the tests,
> please let me know.
>
> Thanks,
> Chan
>
> On Thu, Aug 11, 2016 at 6:07 AM, Pat Ferrel  wrote:
>
>> I’m always disinclined to commit code that has not been tested. However
>> many things in the current state of the develop branch seem broken or at
>> least too big to address in a single commit.
>>
>> 1) Style test fail in Travis that are not runnable or at least have not
>> been documented for local build. I have fixed these.
>> 2) SSL seems to still be required for deploying an engine, PIO-1 may not
>> have addressed this. Has anyone tried to build and test a template yet
>> without SSL? Unless someone can state otherwise I’m inclined to ignore this
>> failure for now since it is out of scope for this commit.
>> 3) the test framework has been integrated into Travis but again no
>> documented way to run it locally and some of the travis errors seem
>> spurious. I am also not inclined to wait for this to be fixed unless
>> someone can point out real problems it is discovering and send instructions
>> for how to run it locally.
>>
>> Before the extra travis tests I was able to build and train a template,
>> which fails on deploy with an SSL config error. Since the PR does not
>> strictly touch any templates I am going to have to ignore this serious
>> issue and address it in Jira.
>>
>> Unless someone vetos this I plan to reluctantly push the PR with these
>> non-trivial issues remaining.
>>
>>
>>
>

[jira] [Commented] (PIO-20) Merge ActionML fork

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417615#comment-15417615
 ] 

ASF GitHub Bot commented on PIO-20:
---

Github user dszeto commented on a diff in the pull request:


https://github.com/apache/incubator-predictionio/pull/273#discussion_r74463515
  
--- Diff: manifest.json ---
@@ -1 +1,2 @@

-{"id":"ipNrDsdxAtsDjZHRSAqfgOTL0PztjuR3","version":"b6a10c9f995426f7ee739156066bc26b577f2f09","name":"pio","description":"pio-autogen-manifest","files":[],"engineFactory":""}
\ No newline at end of file

+{"id":"ipNrDsdxAtsDjZHRSAqfgOTL0PztjuR3","version":"b6a10c9f995426f7ee739156066bc26b577f2f09","name":"pio","description":"pio-autogen-manifest","files":[],"engineFactory":""}
+
--- End diff --

I believe it is committed by accident. It has nothing to do with the main 
codebase and should be removed.


> Merge ActionML fork
> ---
>
> Key: PIO-20
> URL: https://issues.apache.org/jira/browse/PIO-20
> Project: PredictionIO
>  Issue Type: Bug
>Reporter: Pat Ferrel
>Assignee: Pat Ferrel
>
> Merge ActionML's changes since forking pio 0.9.5. This includes 2 releases 
> and the biggest feature is the SelfCleaningDatasource, which optionally trims 
> old events and compact dups and property change events. 
> Adds an optional eventWindow param to engine.json datasource params



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PIO-20) Merge ActionML fork

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417587#comment-15417587
 ] 

ASF GitHub Bot commented on PIO-20:
---

Github user dszeto commented on a diff in the pull request:


https://github.com/apache/incubator-predictionio/pull/273#discussion_r74461039
  
--- Diff: build.sbt ---
@@ -19,7 +19,7 @@ import UnidocKeys._
 
 name := "pio"
 
-version in ThisBuild := "0.9.7-SNAPSHOT"
+version in ThisBuild := "0.10.0-snapshot"
--- End diff --

This is causing integration tests to fail. `snapshot` needs to be uppercase.

RE:

https://github.com/apache/incubator-predictionio/blob/develop/tests/docker-files/init.sh#L27

https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN401



> Merge ActionML fork
> ---
>
> Key: PIO-20
> URL: https://issues.apache.org/jira/browse/PIO-20
> Project: PredictionIO
>  Issue Type: Bug
>Reporter: Pat Ferrel
>Assignee: Pat Ferrel
>
> Merge ActionML's changes since forking pio 0.9.5. This includes 2 releases 
> and the biggest feature is the SelfCleaningDatasource, which optionally trims 
> old events and compact dups and property change events. 
> Adds an optional eventWindow param to engine.json datasource params



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: PIO-20 problems

[Chan Lee]

I want to clarify some points:

2) Deploying templates do not require SSL. If you execute
./make-distribution.sh using the current develop branch (provided you
change the namespace in the template from io.prediction to
org.apache.predictionio), you can deploy without SSL on localhost. The
travis tests also do not use SSL and pass as can be seen in
https://travis-ci.org/Ziemin/incubator-predictionio.

3) You can run the tests locally the same way it is run on travis ('python3
${PIO_DIR}/tests/pio_tests/tests.py'). It is documented in the README in
the same directory, but maybe this was not clear enough. If you have any
additional questions or run into issues executing the tests, please let me
know.

Thanks,
Chan

On Thu, Aug 11, 2016 at 6:07 AM, Pat Ferrel  wrote:

> I’m always disinclined to commit code that has not been tested. However
> many things in the current state of the develop branch seem broken or at
> least too big to address in a single commit.
>
> 1) Style test fail in Travis that are not runnable or at least have not
> been documented for local build. I have fixed these.
> 2) SSL seems to still be required for deploying an engine, PIO-1 may not
> have addressed this. Has anyone tried to build and test a template yet
> without SSL? Unless someone can state otherwise I’m inclined to ignore this
> failure for now since it is out of scope for this commit.
> 3) the test framework has been integrated into Travis but again no
> documented way to run it locally and some of the travis errors seem
> spurious. I am also not inclined to wait for this to be fixed unless
> someone can point out real problems it is discovering and send instructions
> for how to run it locally.
>
> Before the extra travis tests I was able to build and train a template,
> which fails on deploy with an SSL config error. Since the PR does not
> strictly touch any templates I am going to have to ignore this serious
> issue and address it in Jira.
>
> Unless someone vetos this I plan to reluctantly push the PR with these
> non-trivial issues remaining.
>
>
>

asking about storing result

[zulkifli]

Dear ALL,

my installer by default is using Hbase as event server, and then 2 days ago
i migrate from Hbase into Mysql.

i would like ask, about :

1. where is the storage of model matrix factorization?
2. when running process pio deploy, what process happened which is taken
from HDFS or Elastic Search?
3. when im still using Hbase, the result of recommendation are many (>1).
after migrate into Mysql, the result of recommendation are (==1).
we are already store data into MySql. do you know, why the result like that
don't you?
4. why when im request recommendation to port 8000, why im getting error
*jdbc.mysql.sqlException*?
is not that mysql just as Event Storage?

according to this link http://predictionio.incubator.apache.org/system/

so many thanks,
Zul