[GitHub] incubator-predictionio pull request #426: Fix use of case class in textclass...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/426


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio-template-text-classifier pull request #14: Fix use of...

[asfgit]

Github user asfgit closed the pull request at:


https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #426: Fix use of case class in textclass...

[takezoe]

GitHub user takezoe opened a pull request:

https://github.com/apache/incubator-predictionio/pull/426

Fix use of case class in textclassifier example

The text-classifier example is fixed in 
https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/takezoe/incubator-predictionio 
fix-text-classifier-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-predictionio/pull/426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #426


commit 5a74adc38be6cdb88cca8fd1459545926e666f09
Author: Naoki Takezoe 
Date:   2017-08-29T03:02:14Z

Fix use of case class in textclassifier example




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #426: Fix use of case class in textclassifier e...

[shimamoto]

Github user shimamoto commented on the issue:

https://github.com/apache/incubator-predictionio/pull/426
  
This fix is LGTM!
But I wonder what this menu is... 🤔 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio-template-text-classifier issue #14: Fix use of case c...

[shimamoto]

Github user shimamoto commented on the issue:


https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...

[takezoe]

Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/421
  
@mars LGTM! but sorry for conflict with my previous commit: 
6789dbeb71b1cc7f13a385032da6fbc3b8cf7a12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #422: Update eventmodel.html.md.erb

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio-template-text-classifier pull request #14: Fix use of...

[takezoe]

GitHub user takezoe opened a pull request:


https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14

Fix use of case class



You can merge this pull request into a Git repository by running:

$ git pull 
https://github.com/takezoe/incubator-predictionio-template-text-classifier 
fix-caseclass

Alternatively you can review and apply these changes as the patch at:


https://github.com/apache/incubator-predictionio-template-text-classifier/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit b8748a079151f5114738c11237a5ed461f53f604
Author: Naoki Takezoe 
Date:   2017-08-29T02:48:58Z

Fix use of case class




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Graduation to TLP

[Donald Szeto]

Hi all,

Since the ASF Board meeting in May (
http://apache.org/foundation/records/minutes/2017/board_minutes_2017_05_17.txt),
PredictionIO has been considered nearing graduation and I think we are
almost there. I am kickstarting this thread so that we can discuss on these
3 things:

1. Does the development community feel ready to graduate?
2. If we are to graduate, who should we include in the list of the initial
PMC?
3. If we are to graduate, who should be the VP of the initial PMC?

These points are relevant for graduation. Please take a look at the
official graduation guide:
http://incubator.apache.org/guides/graduation.html.

In addition, Sara and I have been working to transfer the PredictionIO
trademark to the ASF. We will keep you updated with our progress.

I would also like to propose to cut a 0.12.0 release by merging JIRAs that
have a target version set to 0.12.0-incubating for graduation. 0.12.0 will
contain cleanups for minor license and copyright issues that were pointed
out in previous releases by IPMC.

Let me know what you think.

Regards,
Donald

[jira] [Updated] (PIO-106) Elasticsearch 5.x StorageClient should reuse RestClient

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-106:
-
Target Version/s: 0.12.0-incubating

> Elasticsearch 5.x StorageClient should reuse RestClient
> ---
>
> Key: PIO-106
> URL: https://issues.apache.org/jira/browse/PIO-106
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Mars Hall
>Assignee: Mars Hall
>
> When using the proposed [PIO-105 Batch 
> Predictions|https://issues.apache.org/jira/browse/PIO-105] feature with an 
> engine that queries Elasticsearch in {{Algorithm#predict}}, Elasticsearch's 
> REST interface appears to become overloaded, ending with the Spark job being 
> killed from errors like:
> {noformat}
> [ERROR] [ESChannels] Failed to access to /pio_meta/channels/_search
> [ERROR] [Utils] Aborting task
> [ERROR] [ESApps] Failed to access to /pio_meta/apps/_search
> [ERROR] [Executor] Exception in task 747.0 in stage 1.0 (TID 749)
> [ERROR] [Executor] Exception in task 735.0 in stage 1.0 (TID 737)
> [ERROR] [Common$] Invalid app name ur
> [ERROR] [Utils] Aborting task
> [ERROR] [URAlgorithm] Error when read recent events: 
> java.lang.IllegalArgumentException: Invalid app name ur
> [ERROR] [Executor] Exception in task 749.0 in stage 1.0 (TID 751)
> [ERROR] [Utils] Aborting task
> [ERROR] [Executor] Exception in task 748.0 in stage 1.0 (TID 750)
> [WARN] [TaskSetManager] Lost task 749.0 in stage 1.0 (TID 751, localhost, 
> executor driver): java.net.BindException: Can't assign requested address
>   at sun.nio.ch.Net.connect0(Native Method)
>   at sun.nio.ch.Net.connect(Net.java:454)
>   at sun.nio.ch.Net.connect(Net.java:446)
>   at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:648)
>   at 
> org.apache.http.impl.nio.reactor.DefaultConnectingIOReactor.processSessionRequests(DefaultConnectingIOReactor.java:273)
>   at 
> org.apache.http.impl.nio.reactor.DefaultConnectingIOReactor.processEvents(DefaultConnectingIOReactor.java:139)
>   at 
> org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor.execute(AbstractMultiworkerIOReactor.java:348)
>   at 
> org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager.execute(PoolingNHttpClientConnectionManager.java:192)
>   at 
> org.apache.http.impl.nio.client.CloseableHttpAsyncClientBase$1.run(CloseableHttpAsyncClientBase.java:64)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> After these errors happen & the job is killed, Elasticsearch immediately 
> recovers. It responds to queries normally. I researched what could cause this 
> and found an [old issue in the main Elasticsearch 
> repo|https://github.com/elastic/elasticsearch/issues/3647]. With the hints 
> given therein about *using keep-alive in the ES client* to avoid these 
> performance issues, I investigated how PredictionIO's [Elasticsearch 
> StorageClient|https://github.com/apache/incubator-predictionio/tree/develop/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch]
>  manages its connections.
> I found that unlike the other StorageClients (Elasticsearch1, HBase, JDBC), 
> Elasticsearch creates a new underlying connection, an Elasticsearch 
> RestClient, for 
> [every|https://github.com/apache/incubator-predictionio/blob/develop/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESApps.scala#L80]
>  
> [single|https://github.com/apache/incubator-predictionio/blob/develop/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESApps.scala#L157]
>  
> [query|https://github.com/apache/incubator-predictionio/blob/develop/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESChannels.scala#L78]
>  & 
> [interaction|https://github.com/apache/incubator-predictionio/blob/develop/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESEngineInstances.scala#L205]
>  with its API. As a result, *there is no way Elasticsearch TCP connections 
> can be reused via HTTP keep-alive*.
> High-performance workloads with Elasticsearch 5.x will suffer from these 
> issues unless we refactor Elasticsearch StorageClient to share the underlying 
> RestClient instead of [building a new one everytime the client is 
> used|https://github.com/apache/incubator-predictionio/blob/develop/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala#L31].
> There are certainly different approaches we could take to sharing a 
> RestClient so that its keep-alive behavior may work as designed:
> * maintain a singleton RestClient that is reused throughout the ES storage 
> classes
> * create a RestClient on-demand and pass it 

[jira] [Updated] (PIO-99) `pio build` exits successfully even when compilation fails

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-99:

Target Version/s: 0.12.0-incubating

> `pio build` exits successfully even when compilation fails
> --
>
> Key: PIO-99
> URL: https://issues.apache.org/jira/browse/PIO-99
> Project: PredictionIO
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 0.11.0-incubating
>Reporter: Mars Hall
>  Labels: newbie
>
> The build command does not fail as expected. While not a big deal when 
> working locally, it seems like this could be problematic for automated, 
> continuous build/integration workflows.
> {code}
> $ pio build
> …
> [ERROR] [Engine$] [error] one error found
> [ERROR] [Engine$] [error] (compile:compileIncremental) Compilation failed
> [ERROR] [Engine$] [error] Total time: 5 s, completed Jun 21, 2017 9:59:55 AM
> [ERROR] [Engine$] Return code of build command: 
> /Users/mars.hall/Projects/predictionio-engine-ur/PredictionIO-dist/sbt/sbt  
> package assemblyPackageDependency is 1. Aborting.
> [INFO] [Engine$] Looking for an engine...
> [INFO] [Engine$] Found universal-recommender-assembly-0.5.0-deps.jar
> [INFO] [Engine$] Found universal-recommender_2.11-0.5.0.jar
> [INFO] [Engine$] Build finished successfully.
> [INFO] [Pio$] Your engine is ready for training.
> {code}
> It certainly appears successful at the end, and exit code was {{0}}.
> Looking back for the error is not hard, but this behavior is problematic when 
> composing {{pio build}} command into a shell script.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PIO-105) Batch Predictions

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-105:
-
Target Version/s: 0.12.0-incubating

> Batch Predictions
> -
>
> Key: PIO-105
> URL: https://issues.apache.org/jira/browse/PIO-105
> Project: PredictionIO
>  Issue Type: New Feature
>  Components: Core
>Reporter: Mars Hall
>Assignee: Mars Hall
> Fix For: 0.12.0-incubating
>
>
> Implement a new {{pio batchpredict}} command to enable massive, fast, batch 
> predictions from a trained model. Read a multi-object JSON file as the input 
> format, with one query object per line. Similarly, write results to a 
> multi-object JSON file, with one prediction result + its original query per 
> line.
> Currently getting bulk predictions from PredictionIO is possible with either:
> * a {{pio eval}} script, which will always train a fresh, unvalidated model 
> before getting predictions
> * a custom script that hits the {{queries.json}} HTTP API, which is a serious 
> bottleneck when requesting hundreds-of-thousands or millions of predictions
> Neither of these existing bulk-prediction hacks are adequate for the reasons 
> mentioned.
> It's time for this use-case to be a firstclass command :D
> Pull request https://github.com/apache/incubator-predictionio/pull/412



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PIO-102) ESEngineInstances `getAll` results out of order (Elasticsearch 5.x)

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-102:
-
Target Version/s: 0.12.0-incubating

> ESEngineInstances `getAll` results out of order (Elasticsearch 5.x)
> ---
>
> Key: PIO-102
> URL: https://issues.apache.org/jira/browse/PIO-102
> Project: PredictionIO
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Mars Hall
>Assignee: Mars Hall
> Fix For: 0.12.0-incubating
>
>
> Using the new Elasticsearch 5.x REST storage client as the meta storage 
> source (`PIO_STORAGE_REPOSITORIES_METADATA_SOURCE=ELASTICSEARCH` setup in 
> conf/pio-env.sh), I found that once an engine has been trained a certain 
> number of times, that the most recent engine instance is no longer retrieved. 
> So, I tracked down where those Elasticsearch queries originate.
> In the original Elasticsearch 1.x storage client, [the "scroll" pagination 
> responses are collected by 
> *appending*|https://github.com/apache/incubator-predictionio/blob/release/0.11.0/storage/elasticsearch1/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESUtils.scala#L44]
>  them to one another.
> In the new Elasticsearch 5.x client, [the "scroll" responses are collected by 
> *prepending*|https://github.com/apache/incubator-predictionio/blob/release/0.11.0/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESUtils.scala#L152]
>  them to one another.
> This out-of-order concatenation breaks [ESEngineInstances 
> `getLatestCompleted`|https://github.com/apache/incubator-predictionio/blob/release/0.11.0/storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESEngineInstances.scala#L192]
>  by erroneously replacing the head of the results with an older engine 
> instance, when there are enough engine instances to overflow a single page of 
> Elasticsearch hits.
> I've observed this buggy behavior after ten trainings, when enough engine 
> instances are stored to trigger Elasticsearch's scroll feature.
> Pull request: https://github.com/apache/incubator-predictionio/pull/406



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PIO-100) Remove SLF4J warning messages on pio command

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-100:
-
Target Version/s: 0.12.0-incubating

> Remove SLF4J warning messages on pio command 
> -
>
> Key: PIO-100
> URL: https://issues.apache.org/jira/browse/PIO-100
> Project: PredictionIO
>  Issue Type: Improvement
>Reporter: Shinsuke Sugaya
>Assignee: Shinsuke Sugaya
>Priority: Minor
>
> pio command prints SLF4J warning as below:
> {code}
> $ /usr/share/predictionio/bin/pio status
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in 
> [jar:file:/usr/share/predictionio/lib/spark/pio-data-hdfs-assembly-0.11.1-v1-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in 
> [jar:file:/usr/share/predictionio/lib/pio-assembly-0.11.1-v1-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> ...
> {code}
> The cause is that pio-data-hdfs contains slf4j-log4j12 jar file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PIO-115) Cache name-to-ID lookups for Storage app & channel

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-115:
-
Target Version/s: 0.12.0-incubating

> Cache name-to-ID lookups for Storage app & channel
> --
>
> Key: PIO-115
> URL: https://issues.apache.org/jira/browse/PIO-115
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Mars Hall
>Assignee: Mars Hall
>
> When stress testing the Universal Recommender with high-concurrency HTTP/REST 
> queries, we observed that Elasticsearch traffic was majority composed of 
> requests resolving the Storage app's name & channel, over and over and over 
> again! In this case, [each per-query call to 
> `LEventStore.findByEntity`|https://github.com/heroku/predictionio-engine-ur/blob/master/src/main/scala/URAlgorithm.scala#L694]
>  re-resolves the app name to an ID.
> Implement memoization for the function that performs these name-to-ID 
> lookups, so that only one set of lookups is performed per process for each 
> app+channel combination.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PIO-111) Document pio batchpredict

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-111:
-
Target Version/s: 0.12.0-incubating

> Document pio batchpredict
> -
>
> Key: PIO-111
> URL: https://issues.apache.org/jira/browse/PIO-111
> Project: PredictionIO
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.12.0-incubating
>Reporter: Donald Szeto
>Assignee: Mars Hall
>  Labels: newbie
> Fix For: 0.12.0-incubating
>
>
> {{pio batchpredict}} is a new feature created in PIO-105. It needs to be 
> documented.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PIO-114) Elasticsearch 5.x StorageClient basic HTTP authentication

[Donald Szeto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Szeto updated PIO-114:
-
Target Version/s: 0.12.0-incubating

> Elasticsearch 5.x StorageClient basic HTTP authentication
> -
>
> Key: PIO-114
> URL: https://issues.apache.org/jira/browse/PIO-114
> Project: PredictionIO
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Mars Hall
>Assignee: Mars Hall
>
> Add optional username-password configuration for the new Elasticsearch 5 
> client; in {{conf/pio-env.sh}} config:
> {code}
> # Optional basic HTTP auth
> PIO_STORAGE_SOURCES_ELASTICSEARCH_USERNAME=my-name
> PIO_STORAGE_SOURCES_ELASTICSEARCH_PASSWORD=my-secret
> {code}
> These credentials are sent in each Elasticsearch request as an HTTP Basic 
> Authorization header.
> Enables use of public-cloud, hosted Elasticsearch clusters, such as [Bonsai 
> on Heroku](https://elements.heroku.com/addons/bonsai).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/425


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (PIO-110) Refactor common code shared by CreateServer and BatchPredict

[Naoki Takezoe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naoki Takezoe updated PIO-110:
--
Affects Version/s: (was: 0.12.0-incubating)
   0.11.0-incubating

> Refactor common code shared by CreateServer and BatchPredict
> 
>
> Key: PIO-110
> URL: https://issues.apache.org/jira/browse/PIO-110
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Donald Szeto
>Assignee: Naoki Takezoe
>  Labels: newbie
> Fix For: 0.12.0-incubating
>
>
> {{BatchPredict}} was created in PIO-105 and has a substantial amount of 
> shared code with {{CreateServer}}. It would be beneficial to refactor both of 
> them to share as much common code as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (PIO-110) Refactor common code shared by CreateServer and BatchPredict

[Naoki Takezoe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naoki Takezoe updated PIO-110:
--
Target Version/s: 0.12.0-incubating  (was: 0.11.0-incubating)

> Refactor common code shared by CreateServer and BatchPredict
> 
>
> Key: PIO-110
> URL: https://issues.apache.org/jira/browse/PIO-110
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Donald Szeto
>Assignee: Naoki Takezoe
>  Labels: newbie
> Fix For: 0.12.0-incubating
>
>
> {{BatchPredict}} was created in PIO-105 and has a substantial amount of 
> shared code with {{CreateServer}}. It would be beneficial to refactor both of 
> them to share as much common code as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (PIO-110) Refactor common code shared by CreateServer and BatchPredict

[Naoki Takezoe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PIO-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naoki Takezoe resolved PIO-110.
---
  Resolution: Fixed
   Fix Version/s: 0.12.0-incubating
Target Version/s: 0.11.0-incubating

> Refactor common code shared by CreateServer and BatchPredict
> 
>
> Key: PIO-110
> URL: https://issues.apache.org/jira/browse/PIO-110
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.12.0-incubating
>Reporter: Donald Szeto
>Assignee: Naoki Takezoe
>  Labels: newbie
> Fix For: 0.12.0-incubating
>
>
> {{BatchPredict}} was created in PIO-105 and has a substantial amount of 
> shared code with {{CreateServer}}. It would be beneficial to refactor both of 
> them to share as much common code as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)