[VOTE] Pulsar Release 2.11.0 Candidate-3

2022-12-16 Thread guo jiwei
This is the third release candidate for Apache Pulsar, version 2.11.0. This release contains 1605 commits by 62 contributors. https://github.com/apache/pulsar/compare/v2.10.2...v2.11.0-candidate-3 CI for this release candidate https://github.com/Technoboy-/pulsar/pull/21 *** Please download,

Re: [VOTE] Pulsar Client Python Release 3.0.0 Candidate 3

2022-12-16 Thread Matteo Merli
+1 * From candidate-2 I checked the source tarball for licenses, notice and no binaries included. -- Matteo Merli On Thu, Dec 15, 2022 at 11:30 PM Yunze Xu wrote: > > This is the third release candidate for Apache Pulsar Client Python, > version 3.0.0. > > It fixes the following issues: >

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-16 Thread PengHui Li
I have pushed out a PR to update the PR template and PIP for metrics changes https://github.com/apache/pulsar/pull/18961 PTAL. Thanks, Penghui On Wed, Dec 7, 2022 at 4:17 PM Haiting Jiang wrote: > +1 for enforcing the PIP procedures. > > > And the CI can try to add labels `doc required` or

Re: [DISCUSS] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-16 Thread 丛搏
Abstraction based on MessageIdData is a good solution. I don't have any discussion context. Why don't we put the topic name in it? All I can think of is PulsarApiMessageId extend TopicMessageId(PIP-224[1]) right? Thanks, Bo [1] https://github.com/apache/pulsar/issues/18616 Yunze Xu

Re: [DISCUSS] PIP-230: Modify MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method

2022-12-16 Thread 丛搏
> +1, LGTM but it should only be applied in 2.12.0 or later. Yes, I agree with you. Thanks, Bo Yunze Xu 于2022年12月16日周五 19:02写道: > > +1, LGTM but it should only be applied in 2.12.0 or later. > > Thanks, > Yunze > > On Fri, Dec 16, 2022 at 6:26 PM Enrico Olivelli wrote: > > > > I support this

Re: [DISCUSS] PIP-230: Modify MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method

2022-12-16 Thread Yunze Xu
+1, LGTM but it should only be applied in 2.12.0 or later. Thanks, Yunze On Fri, Dec 16, 2022 at 6:26 PM Enrico Olivelli wrote: > > I support this solution. > > Unfortunately it is better to not port this to the previous versions > because it is a behaviour change. > > Thanks for driving this

Re: [DISCUSS] PIP-230: Modify MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method

2022-12-16 Thread 丛搏
> Unfortunately it is better to not port this to the previous versions > because it is a behaviour change. yes, It only is included in the new release. and add this change to the new release blog. Thanks, Bo Enrico Olivelli 于2022年12月16日周五 18:26写道: > > I support this solution. > > Unfortunately

Re: [DISCUSS] PIP-230: Modify MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method

2022-12-16 Thread Enrico Olivelli
I support this solution. Unfortunately it is better to not port this to the previous versions because it is a behaviour change. Thanks for driving this effort Enrico Il giorno ven 16 dic 2022 alle ore 10:31 丛搏 ha scritto: > > Hi, pulsar community: > > I start a PIP about modifying

[DISCUSS] PIP-230: Modify MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method

2022-12-16 Thread 丛搏
Hi, pulsar community: I start a PIP about modifying MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method original discussion thread: https://lists.apache.org/thread/8n3oyk2hdsskkotnj4lnlvfnndctpqbg PIP: https://github.com/apache/pulsar/issues/18957 Thanks, Bo

Re: [DISCUSS] Release Pulsar 2.10.3

2022-12-16 Thread Lari Hotari
There's at least one very important PR that wasn't marked for 2.10.3 . For performance, addressing https://github.com/apache/pulsar/pull/17273 is crucial. The broker cache is currently partially broken in all released versions of Pulsar until that fix is out. I tagged it as 2.10.3 now. I tried