Hello,
I recently came across PR 12600 [0]. It was merged in November and
cherry picked to branch-2.8 and branch-2.9. It fixes a bug and adds a
public method to the AuthorizationProvider interface. I am pretty sure
the method is an unnecessary expansion of the interface and it could
lead to a
> On Dec 3, 2021, at 11:45 AM, Michael Marshall wrote:
>
>> Automated checks are useful because we are human and we usually miss to
>> validate this kind of boring stuff.
>
> +1 I think it sounds appropriate to add an automated check. If a use
> case arises where we need to add compiled
> Automated checks are useful because we are human and we usually miss to
> validate this kind of boring stuff.
+1 I think it sounds appropriate to add an automated check. If a use
case arises where we need to add compiled files, we'll also need a way
to bypass/override this check.
Michael
On
Agreed.
I don't think I understand tison's objection to closing very stale PRs
automatically -- if it's gone that long without attention the situation
isn't likely to change. And the submitter can always reopen it if it's
still relevant.
On Fri, Dec 3, 2021 at 1:17 PM Dave Fisher wrote:
> I
I think that any Pulsar committer ought to close any PR that is more than one
year old. That would clear about 75 from the backlog. The OP should be informed
and if they are still interested then they can discuss it here.
So when a stale PR is closed we should suggest that the OP subscribe to
>From my experience, any process won't work. The only way is to inspire more
reviewers act on PRs.
Instead of talking about how to do it, reviewing one PR now can help the
case.
Also, it's reasonable to close inactive PR if there is a successor. But do
not let
a bot do it, which will create many
Thank you, everyone! I am very excited to contribute in a new way to
our great project!
- Michael
On Fri, Dec 3, 2021 at 10:47 AM Aaron Williams
wrote:
>
> Congratulations Michael! Thank you for all of your hard work.
>
> On Fri, Dec 3, 2021 at 7:54 AM Lari Hotari wrote:
>
> > Woot! Congrats
Hi Pulsar Community,
I am excited to start contributing as a committer! I have a question
about our process for closing stale PRs.
We have ~300 open PRs right now. Do we have any guidelines on closing
stale PRs? Of course we don't want to ignore important bug fixes, but
we also don't want to
Congratulations Michael! Thank you for all of your hard work.
On Fri, Dec 3, 2021 at 7:54 AM Lari Hotari wrote:
> Woot! Congrats Michael!
>
> On Fri, Dec 3, 2021 at 9:32 AM Enrico Olivelli
> wrote:
>
> > The Project Management Committee (PMC) for Apache Pulsar
> > has invited Michael Marshal
Woot! Congrats Michael!
On Fri, Dec 3, 2021 at 9:32 AM Enrico Olivelli wrote:
> The Project Management Committee (PMC) for Apache Pulsar
> has invited Michael Marshal to become a committer and we are pleased to
> announce that he has accepted.
>
> Michael contributed a lot of interesting
Il giorno ven 3 dic 2021 alle ore 10:36 ZhangJian He
ha scritto:
> I agree. I mean that the situation can be easily judged during the review
> process. So I think the automated check sames not so valuable.
> If you prefer, I have no objection.
>
Automated checks are useful because we are human
Anonymitaet,
Il giorno ven 3 dic 2021 alle ore 12:50 Anonymitaet _ <
anonymita...@hotmail.com> ha scritto:
> Hi Pulsarers,
>
> Thanks for your suggestions.
>
> I think we need to make consensus on the following issues:
>
> #1
> What should be included in the RN (release note)?
>
> Only include
Hi Pulsarerers,
Today is a great plus one news day. Our community is growing since Dave Duggins
joins us!
Dave is a senior technical writer with a lot of crazy skill sets. He will work
on the redesign work (information architecture) for Pulsar.
In his spare time, Dave nerds out on Star Wars,
Congrats Micheal!
And thanks for your continuous doc contribution! :-D
On 2021/12/3, 19:22, "Jack Vanlightly" wrote:
Congratulations Michael, great findings recently!
On Fri, Dec 3, 2021 at 11:49 AM Aloys Zhang wrote:
> [ External sender. Exercise caution. ]
>
Hi Pulsarers,
Thanks for your suggestions.
I think we need to make consensus on the following issues:
#1
What should be included in the RN (release note)?
Only include major changes (important features/enhancements/bug fixes) in list
form rather than a raw dump of PRs.
Reason:
- The
Congratulations Michael, great findings recently!
On Fri, Dec 3, 2021 at 11:49 AM Aloys Zhang wrote:
> [ External sender. Exercise caution. ]
>
> Congrats Micheal !
>
> Lan Liang 于2021年12月3日周五 18:47写道：
>
> > Congrats :)
> >
> >
> >
> >
> >
> >
> >
> > Best Regards,
> > Lan Liang
> > On
Congrats Micheal !
Lan Liang 于2021年12月3日周五 18:47写道：
> Congrats :)
>
>
>
>
>
>
>
> Best Regards,
> Lan Liang
> On 12/3/2021 18:45，Haiting Jiang wrote：
> Congrats!
>
> Haiting Jiang
>
> On 2021/12/03 07:32:00 Enrico Olivelli wrote:
> The Project Management Committee (PMC) for Apache Pulsar
> has
Congrats :)
Best Regards,
Lan Liang
On 12/3/2021 18:45，Haiting Jiang wrote：
Congrats!
Haiting Jiang
On 2021/12/03 07:32:00 Enrico Olivelli wrote:
The Project Management Committee (PMC) for Apache Pulsar
has invited Michael Marshal to become a committer and we are pleased to
announce that
Congrats!
Haiting Jiang
On 2021/12/03 07:32:00 Enrico Olivelli wrote:
> The Project Management Committee (PMC) for Apache Pulsar
> has invited Michael Marshal to become a committer and we are pleased to
> announce that he has accepted.
>
> Michael contributed a lot of interesting additions to
Congrats Micheal!
Ruguo Yu
On 2021/12/03 07:32:00 Enrico Olivelli wrote:
> The Project Management Committee (PMC) for Apache Pulsar
> has invited Michael Marshal to become a committer and we are pleased to
> announce that he has accepted.
>
> Michael contributed a lot of interesting
Congrats Micheal!
tom lee 于2021年12月3日周五 17:32写道：
> Congrats Michael!
>
> Christophe Bornet 于2021年12月3日周五 17:22写道：
>
> > Awesome ! Congrats Michael !
> >
> > Le ven. 3 déc. 2021 à 08:32, Enrico Olivelli a
> > écrit :
> >
> > > The Project Management Committee (PMC) for Apache Pulsar
> > > has
Hello Enrico:
I am releasing 2.8.2, and I wrote a small tool to help me generate the 2.8.2
release notes, I found that I need several tags to identify:
1) Component, used to identify which type of PR this PR belongs to. I think we
can discuss which components to keep in the future. There are a
I agree. I mean that the situation can be easily judged during the review
process. So I think the automated check sames not so valuable.
If you prefer, I have no objection.
Thanks
ZhangJian He
Enrico Olivelli 于2021年12月3日周五 17:22写道：
> Il giorno ven 3 dic 2021 alle ore 10:20 ZhangJian He
> ha
Congrats Michael!
Christophe Bornet 于2021年12月3日周五 17:22写道：
> Awesome ! Congrats Michael !
>
> Le ven. 3 déc. 2021 à 08:32, Enrico Olivelli a
> écrit :
>
> > The Project Management Committee (PMC) for Apache Pulsar
> > has invited Michael Marshal to become a committer and we are pleased to
> >
Awesome ! Congrats Michael !
Le ven. 3 déc. 2021 à 08:32, Enrico Olivelli a écrit :
> The Project Management Committee (PMC) for Apache Pulsar
> has invited Michael Marshal to become a committer and we are pleased to
> announce that he has accepted.
>
> Michael contributed a lot of interesting
Il giorno ven 3 dic 2021 alle ore 10:20 ZhangJian He
ha scritto:
> Gradle has `gradle-wrapper.jar` too. I think we don't need an automated
> check, the reviewers can find if it's reasonable.
>
For some files there are specific acceptance rules.
But we cannot commit other files that are not
Gradle has `gradle-wrapper.jar` too. I think we don't need an automated
check, the reviewers can find if it's reasonable.
Enrico Olivelli 于2021年11月10日周三 16:47写道：
> ping
>
>
> Il giorno ven 5 nov 2021 alle ore 09:23 Enrico Olivelli <
> eolive...@gmail.com>
> ha scritto:
>
> > Hello,
> > This
Congrats Micheal !
PengHui Li 于2021年12月3日周五 17:13写道：
> Congrats Micheal!
>
> Penghui
>
> On Fri, Dec 3, 2021 at 3:32 PM Enrico Olivelli
> wrote:
>
> > The Project Management Committee (PMC) for Apache Pulsar
> > has invited Michael Marshal to become a committer and we are pleased to
> >
Congrats Micheal!
Penghui
On Fri, Dec 3, 2021 at 3:32 PM Enrico Olivelli wrote:
> The Project Management Committee (PMC) for Apache Pulsar
> has invited Michael Marshal to become a committer and we are pleased to
> announce that he has accepted.
>
> Michael contributed a lot of interesting
29 matches
Mail list logo
