Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

Hi Yunze, > It's a good idea to use `ProtocolVersion` to control. But adding a > negative schema type still looks weird. negative schema type is a history problem(include `NONE` schema type). I don't think it is a good implementation, It adds too much complexity. the broker can control any

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

Hi Bo, > the old server compatibility can add `ProtocolVersion` to control. It's a good idea to use `ProtocolVersion` to control. But adding a negative schema type still looks weird. You can find the following description in SchemaType.java, which was added in

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

> Instead, we can add an optional field into CommandSubscribe to > indicate the schema compatibility check is skipped. > ```protobuf > optional bool check_schema_compatibility = 20 [default = true] > ``` `check_ schema_ Compatibility 'contains too many meanings. I think this change will make the

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

You only need to describe what's added to the PulsarApi.proto, i.e. you don't need to paste all definitions of `CommandSubscribe` in the proposal. Take PIP-54 [1] for example, it only pastes the new field `ack_set` and does not paste the whole `MessageIdData` definition. The implementations

Re: [DISCUSS] PIP-232: Introduce thread monitor to check if thread is blocked for long time.

Hi, This is a great idea. This will significantly help to debug production issues caused by long-waiting threads. I agree with Lari that we could start with the basic metrics. Like Lari shared in the reference, we could simply collect the current thread pool queue size like the following.

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

I just updated the PIP issue and title, you guys can have a look. issue19113 I added `check_schema_compatibility` in CommandSubscribe, and I also made many other changes. Yunze Xu 于2023年1月5日周四 14:33写道： > It's not related to the schema itself. When

Re: [Vote] PIP-231: Add metric for topic load failed

+1 (non-binding) Best, Max Xu On Tue, Dec 27, 2022 at 4:27 PM Jiuming Tao wrote: > Hello pulsar community, > > I'm starting the VOTE for PIP-231: Add metric for topic load failed. > > Motivation: > Currently, we have a `topic_load_times` metric to track how long a topic > load succeeds. > But

Re: [Vote] PIP-231: Add metric for topic load failed

+1 Yike Xiao From: Jiuming Tao Sent: Tuesday, December 27, 2022 16:27 To: dev@pulsar.apache.org Subject: [Vote] PIP-231: Add metric for topic load failed Hello pulsar community, I'm starting the VOTE for PIP-231: Add metric for topic load failed. Motivation:

Re: [Vote] PIP-231: Add metric for topic load failed

+1 Best Xiaoyu Hou Yunze Xu 于2023年1月5日周四 18:32写道： > +1 (binding) > > Thanks, > Yunze > > On Thu, Jan 5, 2023 at 5:45 PM Jiuming Tao > wrote: > > > > bump > > > > Jiuming Tao 于2022年12月27日周二 16:27写道： > > > > > Hello pulsar community, > > > > > > I'm starting the VOTE for PIP-231: Add metric

Re: [Vote] PIP-231: Add metric for topic load failed

+1 (binding) Thanks, Yunze On Thu, Jan 5, 2023 at 5:45 PM Jiuming Tao wrote: > > bump > > Jiuming Tao 于2022年12月27日周二 16:27写道： > > > Hello pulsar community, > > > > I'm starting the VOTE for PIP-231: Add metric for topic load failed. > > > > Motivation: > > Currently, we have a

Re: [VOTE] Pulsar Node.js Client Release 1.8.0 Candidate 2

Hi Nozomi, AFAIK, the napi-xxx.tar.gz will be uploaded to SVN so that `npm install` can download these pre-built binaries directly. I didn't look deeper into the `npm install` process, it might also download the pre-built binaries from the temporary download links from the candidate directory.

Re: [VOTE] Pulsar Node.js Client Release 1.8.0 Candidate 2

Hi Zike, Thank you for managing this release. > However, doing so also creates some inconvenience for the release process. I was wondering if we could put these files(napi-xxx.tar.gz) in the npm package file. I'm sorry I don't get the point of your suggestion yet... Could you explain * What is

Re: [Vote] PIP-231: Add metric for topic load failed

bump Jiuming Tao 于2022年12月27日周二 16:27写道： > Hello pulsar community, > > I'm starting the VOTE for PIP-231: Add metric for topic load failed. > > Motivation: > Currently, we have a `topic_load_times` metric to track how long a topic > load succeeds. > But when loading a topic, there may be some