[jira] [Commented] (DISPATCH-1567) Compilation errors on s390x platform

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036540#comment-17036540 ] ASF GitHub Bot commented on DISPATCH-1567: -- kgiusti commented on pull request #685:

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #685: DISPATCH-1567: fix compilation errors on s390x platform

2020-02-13 Thread GitBox
kgiusti opened a new pull request #685: DISPATCH-1567: fix compilation errors on s390x platform URL: https://github.com/apache/qpid-dispatch/pull/685 Work in progress - do not merge yet! This is an automated message from the

[jira] [Commented] (DISPATCH-1566) safe_snpritf is not safe.

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036506#comment-17036506 ] ASF GitHub Bot commented on DISPATCH-1566: -- nicob87 commented on pull request #679:

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036505#comment-17036505 ] ASF GitHub Bot commented on DISPATCH-1564: -- ganeshmurthy commented on pull request #682:

[GitHub] [qpid-dispatch] nicob87 commented on a change in pull request #679: DISPATCH-1566: fix safe_snptrintf

2020-02-13 Thread GitBox
nicob87 commented on a change in pull request #679: DISPATCH-1566: fix safe_snptrintf URL: https://github.com/apache/qpid-dispatch/pull/679#discussion_r379122619 ## File path: src/router_core/terminus.c ## @@ -75,24 +76,34 @@ void qdr_terminus_free(qdr_terminus_t *term)

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379122198 ## File path: python/qpid_dispatch_internal/tools/display.py ## @@

[GitHub] [qpid-dispatch] nicob87 opened a new pull request #684: WIP: (Work In Progress) DISPATCH-1568: using doctest

2020-02-13 Thread GitBox
nicob87 opened a new pull request #684: WIP: (Work In Progress) DISPATCH-1568: using doctest URL: https://github.com/apache/qpid-dispatch/pull/684 - Demo using the library that Jiri Daněk suggested in the issue, it seems to be a very nice option for several reasons, it is an evolution of

[jira] [Commented] (DISPATCH-1568) add c-unittest support

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036495#comment-17036495 ] ASF GitHub Bot commented on DISPATCH-1568: -- nicob87 commented on pull request #684: WIP:

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379110703 ## File path: tests/system_tests_console.py ## @@ -51,7 +51,7 @@ def

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036491#comment-17036491 ] ASF GitHub Bot commented on DISPATCH-1564: -- ganeshmurthy commented on pull request #682:

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036490#comment-17036490 ] ASF GitHub Bot commented on DISPATCH-1564: -- ganeshmurthy commented on pull request #682:

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036489#comment-17036489 ] ASF GitHub Bot commented on DISPATCH-1564: -- ganeshmurthy commented on pull request #682:

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379109701 ## File path: python/qpid_dispatch_internal/tools/display.py ## @@

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379109840 ## File path: python/qpid_dispatch_internal/tools/display.py ## @@

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036488#comment-17036488 ] ASF GitHub Bot commented on DISPATCH-1564: -- ganeshmurthy commented on pull request #682:

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
ganeshmurthy commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379109272 ## File path: python/qpid_dispatch_internal/tools/display.py ## @@

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036479#comment-17036479 ] ASF GitHub Bot commented on DISPATCH-1564: -- kgiusti commented on pull request #682:

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379099545 ## File path: python/qpid_dispatch_internal/tools/display.py ## @@ -138,6

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379102344 ## File path: python/qpid_dispatch_internal/tools/display.py ## @@ -138,6

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036480#comment-17036480 ] ASF GitHub Bot commented on DISPATCH-1564: -- kgiusti commented on pull request #682:

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379101275 ## File path: python/qpid_dispatch_internal/tools/display.py ## @@ -138,6

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036481#comment-17036481 ] ASF GitHub Bot commented on DISPATCH-1564: -- kgiusti commented on pull request #682:

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
kgiusti commented on a change in pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379099722 ## File path: tests/system_tests_console.py ## @@ -51,7 +51,7 @@ def

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036482#comment-17036482 ] ASF GitHub Bot commented on DISPATCH-1564: -- kgiusti commented on pull request #682:

[jira] [Commented] (DISPATCH-1566) safe_snpritf is not safe.

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036477#comment-17036477 ] ASF GitHub Bot commented on DISPATCH-1566: -- kgiusti commented on pull request #679:

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #679: DISPATCH-1566: fix safe_snptrintf

2020-02-13 Thread GitBox
kgiusti commented on a change in pull request #679: DISPATCH-1566: fix safe_snptrintf URL: https://github.com/apache/qpid-dispatch/pull/679#discussion_r379086687 ## File path: src/router_core/terminus.c ## @@ -75,24 +76,34 @@ void qdr_terminus_free(qdr_terminus_t *term)

[jira] [Assigned] (DISPATCH-1567) Compilation errors on s390x platform

2020-02-13 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-1567: Assignee: Ken Giusti > Compilation errors on s390x platform >

[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036447#comment-17036447 ] ASF GitHub Bot commented on DISPATCH-1415: -- codecov-io commented on issue #680:

[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

2020-02-13 Thread GitBox
codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr=h1) Report > Merging

[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #683: DISPATCH-1562: Changed the names of prometheus metrics to be in line …

2020-02-13 Thread GitBox
ganeshmurthy commented on issue #683: DISPATCH-1562: Changed the names of prometheus metrics to be in line … URL: https://github.com/apache/qpid-dispatch/pull/683#issuecomment-585927652 Naming rules are here - https://prometheus.io/docs/practices/naming/ Please take a look and let

[jira] [Commented] (DISPATCH-1562) Make attribute names provided to Prometheus more router specific

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036446#comment-17036446 ] ASF GitHub Bot commented on DISPATCH-1562: -- ganeshmurthy commented on issue #683:

[jira] [Commented] (DISPATCH-1562) Make attribute names provided to Prometheus more router specific

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036445#comment-17036445 ] ASF GitHub Bot commented on DISPATCH-1562: -- ganeshmurthy commented on pull request #683:

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #683: DISPATCH-1562: Changed the names of prometheus metrics to be in line …

2020-02-13 Thread GitBox
ganeshmurthy opened a new pull request #683: DISPATCH-1562: Changed the names of prometheus metrics to be in line … URL: https://github.com/apache/qpid-dispatch/pull/683 …with prometheus recommendation This is an automated

[jira] [Commented] (DISPATCH-1562) Make attribute names provided to Prometheus more router specific

2020-02-13 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036434#comment-17036434 ] Ganesh Murthy commented on DISPATCH-1562: - This shows how to name the prometheus metrics -

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036424#comment-17036424 ] ASF GitHub Bot commented on DISPATCH-1564: -- codecov-io commented on issue #682: DISPATCH-1564

[GitHub] [qpid-dispatch] codecov-io commented on issue #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
codecov-io commented on issue #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682#issuecomment-585914982 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/682?src=pr=h1) Report > Merging

[jira] [Commented] (DISPATCH-1518) Add ability to turn on router trace logging for a specific connection

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036364#comment-17036364 ] ASF GitHub Bot commented on DISPATCH-1518: -- ganeshmurthy commented on pull request #676:

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging …

2020-02-13 Thread GitBox
ganeshmurthy commented on a change in pull request #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging … URL: https://github.com/apache/qpid-dispatch/pull/676#discussion_r377746563 ## File path: python/qpid_dispatch/management/client.py ## @@ -76,6

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of …

2020-02-13 Thread GitBox
ganeshmurthy opened a new pull request #682: DISPATCH-1564 - Modified the way ulong is displayed on the output of … URL: https://github.com/apache/qpid-dispatch/pull/682 …qdstat This is an automated message from the Apache

[jira] [Commented] (DISPATCH-1564) Two system tests fail on Fedora 32(fedora:rawhide)

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036362#comment-17036362 ] ASF GitHub Bot commented on DISPATCH-1564: -- ganeshmurthy commented on pull request #682:

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

2020-02-13 Thread GitBox
kgiusti commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378899864 ## File path: src/dispatch.c ## @@ -379,3 +379,50 @@ void

[jira] [Commented] (DISPATCH-1415) qdstat does not show process memory usage

2020-02-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036276#comment-17036276 ] ASF GitHub Bot commented on DISPATCH-1415: -- kgiusti commented on pull request #680: