[jira] [Commented] (PROTON-2231) Assertion fail on macOS with libuv in c-threaderciser test

2020-10-16 Thread Roddie Kieley (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215708#comment-17215708 ] Roddie Kieley commented on PROTON-2231: --- While I have not yet attempted to reproduce using libuv

[GitHub] [qpid-proton] codecov-io edited a comment on pull request #274: PROTON-2169 Require distutils to build Python binding

2020-10-16 Thread GitBox
codecov-io edited a comment on pull request #274: URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-709989354 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr=h1) Report > Merging [#274](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr=desc)

[jira] [Commented] (PROTON-2169) Build fails with ModuleNotFoundError when python3-distutils is missing

2020-10-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215349#comment-17215349 ] ASF GitHub Bot commented on PROTON-2169: codecov-io commented on pull request #274: URL:

[jira] [Commented] (PROTON-2169) Build fails with ModuleNotFoundError when python3-distutils is missing

2020-10-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215350#comment-17215350 ] ASF GitHub Bot commented on PROTON-2169: codecov-io edited a comment on pull request #274: URL:

[GitHub] [qpid-proton] codecov-io commented on pull request #274: PROTON-2169 Require distutils to build Python binding

2020-10-16 Thread GitBox
codecov-io commented on pull request #274: URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-709989354 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr=h1) Report > Merging [#274](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr=desc) into

[jira] [Commented] (QPID-8469) [Broker-J][Message Store] The message is already cleaned when the delete listener is called

2020-10-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215292#comment-17215292 ] ASF GitHub Bot commented on QPID-8469: -- overmeulen commented on pull request #60: URL:

[GitHub] [qpid-broker-j] overmeulen commented on pull request #60: QPID-8469: [Broker-J][Message Store] The message is already cleaned when the delete listener is called

2020-10-16 Thread GitBox
overmeulen commented on pull request #60: URL: https://github.com/apache/qpid-broker-j/pull/60#issuecomment-709939584 If I'm not mistaken, this fix has been merged in master, should we close this PR ? This is an automated

[jira] [Commented] (PROTON-2169) Build fails with ModuleNotFoundError when python3-distutils is missing

2020-10-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215280#comment-17215280 ] ASF GitHub Bot commented on PROTON-2169: jiridanek opened a new pull request #274: URL:

[GitHub] [qpid-proton] jiridanek opened a new pull request #274: PROTON-2169 Require distutils to build Python binding

2020-10-16 Thread GitBox
jiridanek opened a new pull request #274: URL: https://github.com/apache/qpid-proton/pull/274 Without the module present, the build would fail with a somewhat cryptic final error saying ``` CMake Error at python/CMakeLists.txt:139 (install): install FILES given no

[jira] [Assigned] (PROTON-2170) cmake -DBUILD_TESTING=OFF does not disable building all tests

2020-10-16 Thread Jira
[ https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reassigned PROTON-2170: -- Assignee: Jiri Daněk > cmake -DBUILD_TESTING=OFF does not disable building all tests >

[jira] [Resolved] (PROTON-2170) cmake -DBUILD_TESTING=OFF does not disable building all tests

2020-10-16 Thread Jira
[ https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved PROTON-2170. Fix Version/s: proton-c-0.33.0 Resolution: Fixed > cmake -DBUILD_TESTING=OFF does not

[GitHub] [qpid-proton] jiridanek merged pull request #271: PROTON-2170: Respect the BUILD_TESTING option to allow the user to disable tests

2020-10-16 Thread GitBox
jiridanek merged pull request #271: URL: https://github.com/apache/qpid-proton/pull/271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PROTON-2170) cmake -DBUILD_TESTING=OFF does not disable building all tests

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215261#comment-17215261 ] ASF subversion and git services commented on PROTON-2170: - Commit

[jira] [Commented] (PROTON-2170) cmake -DBUILD_TESTING=OFF does not disable building all tests

2020-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215260#comment-17215260 ] ASF subversion and git services commented on PROTON-2170: - Commit

[jira] [Commented] (PROTON-2170) cmake -DBUILD_TESTING=OFF does not disable building all tests

2020-10-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215262#comment-17215262 ] ASF GitHub Bot commented on PROTON-2170: jiridanek merged pull request #271: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #271: PROTON-2170: Respect the BUILD_TESTING option to allow the user to disable tests

2020-10-16 Thread GitBox
jiridanek commented on pull request #271: URL: https://github.com/apache/qpid-proton/pull/271#issuecomment-709900061 With this patch, `-DBUILD_TESTING=OFF` is to have implicit effects in CTests, that is, `enable_testing()` is not called, and all `add_test` calls in CMake become noops.

[jira] [Commented] (PROTON-2170) cmake -DBUILD_TESTING=OFF does not disable building all tests

2020-10-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215255#comment-17215255 ] ASF GitHub Bot commented on PROTON-2170: jiridanek commented on pull request #271: URL: