[jira] [Commented] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314129#comment-17314129 ] ASF GitHub Bot commented on PROTON-2344: cliffjansen closed pull request #304: URL:

[jira] [Commented] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314128#comment-17314128 ] ASF GitHub Bot commented on PROTON-2344: cliffjansen commented on pull request #304: URL:

[GitHub] [qpid-proton] cliffjansen closed pull request #304: PROTON-2344: fix Python BlockingConnection resource leaks, memory and…

2021-04-02 Thread GitBox
cliffjansen closed pull request #304: URL: https://github.com/apache/qpid-proton/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [qpid-proton] cliffjansen commented on pull request #304: PROTON-2344: fix Python BlockingConnection resource leaks, memory and…

2021-04-02 Thread GitBox
cliffjansen commented on pull request #304: URL: https://github.com/apache/qpid-proton/pull/304#issuecomment-812768807 Fixes applied, including Andrew's suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread Clifford Jansen (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clifford Jansen resolved PROTON-2344. - Fix Version/s: proton-c-0.35.0 Assignee: Clifford Jansen Resolution:

[jira] [Commented] (PROTON-2355) Build failure with -DPROACTOR=none

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314118#comment-17314118 ] ASF GitHub Bot commented on PROTON-2355: jiridanek merged pull request #306: URL:

[jira] [Commented] (PROTON-2355) Build failure with -DPROACTOR=none

2021-04-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314117#comment-17314117 ] ASF subversion and git services commented on PROTON-2355: - Commit

[GitHub] [qpid-proton] jiridanek merged pull request #306: PROTON-2355: Definitively fix CMake 2.8.12 incompatibility w/ generexp in add_library

2021-04-02 Thread GitBox
jiridanek merged pull request #306: URL: https://github.com/apache/qpid-proton/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (PROTON-2355) Build failure with -DPROACTOR=none

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314109#comment-17314109 ] ASF GitHub Bot commented on PROTON-2355: jiridanek opened a new pull request #306: URL:

[GitHub] [qpid-proton] jiridanek opened a new pull request #306: PROTON-2355: Definitively fix CMake 2.8.12 incompatibility w/ generexp in add_library

2021-04-02 Thread GitBox
jiridanek opened a new pull request #306: URL: https://github.com/apache/qpid-proton/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Closed] (PROTON-2365) Build failure without C++

2021-04-02 Thread Fabrice Fontaine (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabrice Fontaine closed PROTON-2365. Resolution: Invalid > Build failure without C++ > - > >

[jira] [Commented] (PROTON-2365) Build failure without C++

2021-04-02 Thread Fabrice Fontaine (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314104#comment-17314104 ] Fabrice Fontaine commented on PROTON-2365: -- Patches have been merged in buildroot:

[jira] [Commented] (DISPATCH-2025) Compile using C11 language version

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314102#comment-17314102 ] ASF GitHub Bot commented on DISPATCH-2025: -- jiridanek merged pull request #1090: URL:

[jira] [Commented] (DISPATCH-2025) Compile using C11 language version

2021-04-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314101#comment-17314101 ] ASF subversion and git services commented on DISPATCH-2025: --- Commit

[GitHub] [qpid-dispatch] jiridanek merged pull request #1090: DISPATCH-2025 Compile using C11 language version

2021-04-02 Thread GitBox
jiridanek merged pull request #1090: URL: https://github.com/apache/qpid-dispatch/pull/1090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (DISPATCH-2011) Support hwasan variant of address sanitizer on Aarch64 in CMake

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314087#comment-17314087 ] ASF GitHub Bot commented on DISPATCH-2011: -- codecov-io commented on pull request #1099: URL:

[GitHub] [qpid-dispatch] codecov-io commented on pull request #1099: DISPATCH-2011 Install grpc on AArch64 in Travis CI

2021-04-02 Thread GitBox
codecov-io commented on pull request #1099: URL: https://github.com/apache/qpid-dispatch/pull/1099#issuecomment-812720560 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1099?src=pr=h1) Report > Merging

[jira] [Commented] (PROTON-2355) Build failure with -DPROACTOR=none

2021-04-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314072#comment-17314072 ] ASF subversion and git services commented on PROTON-2355: - Commit

[jira] [Commented] (PROTON-2355) Build failure with -DPROACTOR=none

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314073#comment-17314073 ] ASF GitHub Bot commented on PROTON-2355: jiridanek merged pull request #305: URL:

[GitHub] [qpid-proton] jiridanek merged pull request #305: PROTON-2355: Fix CMake 2.8.12 incompatibility in the original fix

2021-04-02 Thread GitBox
jiridanek merged pull request #305: URL: https://github.com/apache/qpid-proton/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (DISPATCH-2011) Support hwasan variant of address sanitizer on Aarch64 in CMake

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314056#comment-17314056 ] ASF GitHub Bot commented on DISPATCH-2011: -- jiridanek opened a new pull request #1099: URL:

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1099: DISPATCH-2011 Install grpc on AArch64 in Travis CI

2021-04-02 Thread GitBox
jiridanek opened a new pull request #1099: URL: https://github.com/apache/qpid-dispatch/pull/1099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314032#comment-17314032 ] ASF subversion and git services commented on PROTON-2344: - Commit

[jira] [Commented] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314031#comment-17314031 ] ASF subversion and git services commented on PROTON-2344: - Commit

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313980#comment-17313980 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on a change in pull request #303:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606334049 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1",

[jira] [Commented] (DISPATCH-836) Source file organization suffers from include hell

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313972#comment-17313972 ] Jiri Daněk commented on DISPATCH-836: - clang-format actually does not work all that well, because

[jira] [Assigned] (DISPATCH-782) [unit-tests] SIGSEGV in qd_python_finalize

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reassigned DISPATCH-782: --- Assignee: Jiri Daněk > [unit-tests] SIGSEGV in qd_python_finalize >

[jira] [Updated] (DISPATCH-836) Source file organization suffers from include hell

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-836: Fix Version/s: (was: Backlog) 1.16.0 > Source file organization suffers

[jira] [Assigned] (DISPATCH-836) Source file organization suffers from include hell

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reassigned DISPATCH-836: --- Assignee: Jiri Daněk > Source file organization suffers from include hell >

[jira] [Commented] (DISPATCH-836) Source file organization suffers from include hell

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313951#comment-17313951 ] Jiri Daněk commented on DISPATCH-836: - [~chug] What do you think about this? The example does not

[jira] [Commented] (DISPATCH-2025) Compile using C11 language version

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313945#comment-17313945 ] ASF GitHub Bot commented on DISPATCH-2025: -- codecov-io edited a comment on pull request

[GitHub] [qpid-dispatch] codecov-io edited a comment on pull request #1090: DISPATCH-2025 Compile using C11 language version

2021-04-02 Thread GitBox
codecov-io edited a comment on pull request #1090: URL: https://github.com/apache/qpid-dispatch/pull/1090#issuecomment-808764808 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr=h1) Report > Merging

[jira] [Commented] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313943#comment-17313943 ] ASF GitHub Bot commented on PROTON-2344: astitcher commented on a change in pull request #304:

[GitHub] [qpid-proton] astitcher commented on a change in pull request #304: PROTON-2344: fix Python BlockingConnection resource leaks, memory and…

2021-04-02 Thread GitBox
astitcher commented on a change in pull request #304: URL: https://github.com/apache/qpid-proton/pull/304#discussion_r606305168 ## File path: python/proton/_utils.py ## @@ -440,11 +440,16 @@ def close(self): self.conn.close() self.wait(lambda:

[jira] [Commented] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313935#comment-17313935 ] ASF GitHub Bot commented on PROTON-2344: cliffjansen commented on pull request #304: URL:

[GitHub] [qpid-proton] cliffjansen commented on pull request #304: PROTON-2344: fix Python BlockingConnection resource leaks, memory and…

2021-04-02 Thread GitBox
cliffjansen commented on pull request #304: URL: https://github.com/apache/qpid-proton/pull/304#issuecomment-812582546 BlockingConnection.close() must ensure eventual cleanup of all resources by the time it returns and be resilient against exceptions. The strategy under the old C

[jira] [Commented] (DISPATCH-2025) Compile using C11 language version

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313930#comment-17313930 ] ASF GitHub Bot commented on DISPATCH-2025: -- jiridanek commented on a change in pull request

[jira] [Commented] (DISPATCH-2025) Compile using C11 language version

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313931#comment-17313931 ] ASF GitHub Bot commented on DISPATCH-2025: -- jiridanek commented on a change in pull request

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1090: DISPATCH-2025 Compile using C11 language version

2021-04-02 Thread GitBox
jiridanek commented on a change in pull request #1090: URL: https://github.com/apache/qpid-dispatch/pull/1090#discussion_r606289113 ## File path: CMakeLists.txt ## @@ -20,11 +20,46 @@ cmake_minimum_required(VERSION 2.8.12) project(qpid-dispatch C CXX) +# This effectively

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1090: DISPATCH-2025 Compile using C11 language version

2021-04-02 Thread GitBox
jiridanek commented on a change in pull request #1090: URL: https://github.com/apache/qpid-dispatch/pull/1090#discussion_r606289032 ## File path: CMakeLists.txt ## @@ -20,11 +20,46 @@ cmake_minimum_required(VERSION 2.8.12) project(qpid-dispatch C CXX) +# This effectively

[jira] [Commented] (PROTON-2355) Build failure with -DPROACTOR=none

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313928#comment-17313928 ] ASF GitHub Bot commented on PROTON-2355: jiridanek opened a new pull request #305: URL:

[GitHub] [qpid-proton] jiridanek opened a new pull request #305: PROTON-2355: Fix CMake 2.8.12 incompatibility in the original fix

2021-04-02 Thread GitBox
jiridanek opened a new pull request #305: URL: https://github.com/apache/qpid-proton/pull/305 This goes back to `$https://cmake.org/cmake/help/v2.8.12/cmake.html#command:add_compile_options. Unless there are better ideas? -- This is an automated message from the Apache Git Service. To

[jira] [Reopened] (PROTON-2355) Build failure with -DPROACTOR=none

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reopened PROTON-2355: This fix fails on CMake 2.8.12 with {noformat} -- Building the epoll proactor CMake Error at

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313914#comment-17313914 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on pull request #303: URL:

[GitHub] [qpid-proton] DreamPearl commented on pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#issuecomment-812563434 > Thanks, Rakhi. This looks good. I agree about the "empty" side. I think we should either drop that logic from url.cpp or change it to an assertion. > > I added a

[jira] [Commented] (PROTON-2344) memory leak and close_waits in qpid-proton-c / python2-qpid-proton when dropping timeouted connection

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313911#comment-17313911 ] ASF GitHub Bot commented on PROTON-2344: cliffjansen opened a new pull request #304: URL:

[GitHub] [qpid-proton] cliffjansen opened a new pull request #304: PROTON-2344: fix Python BlockingConnection resource leaks, memory and…

2021-04-02 Thread GitBox
cliffjansen opened a new pull request #304: URL: https://github.com/apache/qpid-proton/pull/304 … socket fds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313906#comment-17313906 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on a change in pull request #303:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606263196 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1",

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313905#comment-17313905 ] ASF GitHub Bot commented on PROTON-2357: jiridanek commented on pull request #303: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
jiridanek commented on pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#issuecomment-812554756 > Now I wonder if there is any way to run make coverage for a single file too? Here's the finest-grain way of running tests that is available (that I know of): Use

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313904#comment-17313904 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on a change in pull request #303:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606262167 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1",

[jira] [Commented] (PROTON-2365) Build failure without C++

2021-04-02 Thread Fabrice Fontaine (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313901#comment-17313901 ] Fabrice Fontaine commented on PROTON-2365: -- Thanks for investigating this issue, indeed

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313900#comment-17313900 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on a change in pull request #303:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606257138 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1",

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313899#comment-17313899 ] ASF GitHub Bot commented on PROTON-2357: jiridanek commented on a change in pull request #303:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
jiridanek commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606256771 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1", "1234",

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313898#comment-17313898 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on a change in pull request #303:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606256566 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1",

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313896#comment-17313896 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on pull request #303: URL:

[GitHub] [qpid-proton] DreamPearl commented on pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#issuecomment-812548973 > Just a quick question. Do you know how to run a single test? I hope you are not forced to run the entire testsuite every time you make a change here... Thanks,

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313891#comment-17313891 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on a change in pull request #303:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606251392 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1",

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313889#comment-17313889 ] ASF GitHub Bot commented on PROTON-2357: DreamPearl commented on a change in pull request #303:

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
DreamPearl commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606250828 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1",

[jira] [Closed] (DISPATCH-782) [unit-tests] SIGSEGV in qd_python_finalize

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk closed DISPATCH-782. --- Resolution: Cannot Reproduce I tried current Debian Testing, where this was failing previously

[jira] [Comment Edited] (PROTON-2365) Build failure without C++

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/PROTON-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313862#comment-17313862 ] Jiri Daněk edited comment on PROTON-2365 at 4/2/21, 1:07 PM: - Any way to

[jira] [Commented] (PROTON-2365) Build failure without C++

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/PROTON-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313862#comment-17313862 ] Jiri Daněk commented on PROTON-2365: Any way to look into the file

[jira] [Commented] (DISPATCH-782) [unit-tests] SIGSEGV in qd_python_finalize

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313844#comment-17313844 ] Jiri Daněk commented on DISPATCH-782: - I was unable to reproduce this in Fedora container (same as

[jira] [Updated] (DISPATCH-385) Router crashes when on-demand host is no longer reachable

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-385: Description: Router will crash if the host for an on-demand connector is unreachable. To

[jira] [Commented] (DISPATCH-836) Source file organization suffers from include hell

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313819#comment-17313819 ] Jiri Daněk commented on DISPATCH-836: - So in other words, it's the Google ordering,

[jira] [Commented] (DISPATCH-1088) Add OpenTracing support

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313807#comment-17313807 ] Jiri Daněk commented on DISPATCH-1088: -- In the meantime as this ticket is open, OpenTracing has

[jira] [Comment Edited] (DISPATCH-899) 0.8.0 Release issues on Fedora 27

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313800#comment-17313800 ] Jiri Daněk edited comment on DISPATCH-899 at 4/2/21, 11:02 AM: --- This

[jira] [Commented] (DISPATCH-899) 0.8.0 Release issues on Fedora 27

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313800#comment-17313800 ] Jiri Daněk commented on DISPATCH-899: - This issue sounds to me like it is ~3 years out of date. I'd

[jira] [Commented] (DISPATCH-347) Negative SASL outome when "requireEncryption" isn't satisfied

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313786#comment-17313786 ] Jiri Daněk commented on DISPATCH-347: - This sounds related to DISPATCH-1040, DISPATCH-1028. I am

[jira] [Updated] (DISPATCH-213) Qpid dispatch management tools need explanation of hidden SASL conventions

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-213: Component/s: Tools > Qpid dispatch management tools need explanation of hidden SASL conventions

[jira] [Updated] (DISPATCH-1835) double free detected with tcp adapter

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1835: - Labels: memory-bug (was: ) > double free detected with tcp adapter >

[jira] [Updated] (DISPATCH-929) dangling connection pointer in epoll proactor(?)

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-929: Labels: memory-bug (was: ) > dangling connection pointer in epoll proactor(?) >

[jira] [Updated] (DISPATCH-1259) delivery->link_work race condition

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1259: - Labels: memory-bug (was: ) > delivery->link_work race condition >

[jira] [Updated] (DISPATCH-2025) Compile using C11 language version

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-2025: - Description: All supported platforms of Dispatch can compile using C11 (or gnu11) language

[jira] [Updated] (DISPATCH-2025) Compile using C11 language version

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-2025: - Description: All supported platforms of Dispatch can compile using C11 (or gnu11) language

[jira] [Commented] (DISPATCH-1456) Create a periodic CI job that runs system tests using the thread sanitizer

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313768#comment-17313768 ] Jiri Daněk commented on DISPATCH-1456: -- The job ended up on Travis CI. Currently it is "allowed

[jira] [Comment Edited] (DISPATCH-1464) [test] Python triggers proton assert in system_tests_delivery_abort test

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313767#comment-17313767 ] Jiri Daněk edited comment on DISPATCH-1464 at 4/2/21, 9:54 AM: --- The

[jira] [Commented] (DISPATCH-1464) [test] Python triggers proton assert in system_tests_delivery_abort test

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313767#comment-17313767 ] Jiri Daněk commented on DISPATCH-1464: -- The assertion has been removed from Proton in

[jira] [Updated] (DISPATCH-1464) [test] Python triggers proton assert in system_tests_delivery_abort test

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1464: - Description: Running the test in a loop quickly (<20 passes) fails with: {noformat} 41:

[jira] [Updated] (DISPATCH-415) Allow variable substitution in Dispatch config values (with env vars or options given on startup)

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-415: Summary: Allow variable substitution in Dispatch config values (with env vars or options given

[jira] [Updated] (DISPATCH-1989) [libuv] ASAN use after free in connection close

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1989: - Summary: [libuv] ASAN use after free in connection close (was: ASAN use after free in

[jira] [Updated] (DISPATCH-1989) [libuv] ASAN use after free in connection close

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-1989: - Labels: libuv (was: ) > [libuv] ASAN use after free in connection close >

[jira] [Commented] (DISPATCH-1969) Create CI job that renders Dispatch documentation

2021-04-02 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313746#comment-17313746 ] Jiri Daněk commented on DISPATCH-1969: -- [~pwright-redhat], [~bhardesty] do you know how do I

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313723#comment-17313723 ] ASF GitHub Bot commented on PROTON-2357: jiridanek commented on a change in pull request #303:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
jiridanek commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606149268 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1", "1234",

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313722#comment-17313722 ] ASF GitHub Bot commented on PROTON-2357: jiridanek commented on a change in pull request #303:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
jiridanek commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606148135 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1", "1234",

[jira] [Commented] (PROTON-2357) [cpp] Improve test coverage in url.cpp

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313712#comment-17313712 ] ASF GitHub Bot commented on PROTON-2357: jiridanek commented on a change in pull request #303:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #303: PROTON-2357: Improve test coverage in url.cpp

2021-04-02 Thread GitBox
jiridanek commented on a change in pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#discussion_r606137671 ## File path: cpp/src/url_test.cpp ## @@ -111,6 +116,54 @@ TEST_CASE("parse URL","[url]") { "amqp", "user", "pass", "::1", "1234",