[GitHub] [qpid-broker-j] deepyaraj commented on pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-07 Thread GitBox
deepyaraj commented on pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#issuecomment-856452068 > The changes look good to me. Though, some further improvements could be made to tests, for example, refactoring of duplicate blocks, superfluous exception annotations,

[jira] [Resolved] (DISPATCH-1896) [http2] GOAWAY frame received from server not propagated to client

2021-06-07 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1896. - Resolution: Fixed > [http2] GOAWAY frame received from server not propagated to

[jira] [Commented] (DISPATCH-1896) [http2] GOAWAY frame received from server not propagated to client

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358847#comment-17358847 ] ASF GitHub Bot commented on DISPATCH-1896: -- asfgit closed pull request #1242: URL:

[jira] [Commented] (DISPATCH-1896) [http2] GOAWAY frame received from server not propagated to client

2021-06-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358846#comment-17358846 ] ASF subversion and git services commented on DISPATCH-1896: --- Commit

[GitHub] [qpid-dispatch] asfgit closed pull request #1242: DISPATCH-1896 - Propagate the GOAWAY frame received from the http2 se…

2021-06-07 Thread GitBox
asfgit closed pull request #1242: URL: https://github.com/apache/qpid-dispatch/pull/1242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (DISPATCH-1896) [http2] GOAWAY frame received from server not propagated to client

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358836#comment-17358836 ] ASF GitHub Bot commented on DISPATCH-1896: -- kgiusti commented on a change in pull request

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1242: DISPATCH-1896 - Propagate the GOAWAY frame received from the http2 se…

2021-06-07 Thread GitBox
kgiusti commented on a change in pull request #1242: URL: https://github.com/apache/qpid-dispatch/pull/1242#discussion_r646896652 ## File path: README ## @@ -90,6 +88,7 @@ Test Suite Code Coverage (GNU tools only) Use coverage analysis to ensure that all code paths are

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-06-07 Thread Charles E. Rolke (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358831#comment-17358831 ] Charles E. Rolke commented on DISPATCH-1878: >From a 4-router linear test failure. The

[jira] [Commented] (DISPATCH-2161) HTTP/1.x server connection hangs if client disconnects during response message

2021-06-07 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358750#comment-17358750 ] Ken Giusti commented on DISPATCH-2161: -- Not exactly the same failure, but similar failure to

[jira] [Updated] (DISPATCH-2161) HTTP/1.x server connection hangs if client disconnects during response message

2021-06-07 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-2161: - Summary: HTTP/1.x server connection hangs if client disconnects during response message

[jira] [Created] (DISPATCH-2167) HTTP/1.x server connection hangs if client request is aborted

2021-06-07 Thread Ken Giusti (Jira)
Ken Giusti created DISPATCH-2167: Summary: HTTP/1.x server connection hangs if client request is aborted Key: DISPATCH-2167 URL: https://issues.apache.org/jira/browse/DISPATCH-2167 Project: Qpid

[jira] [Commented] (DISPATCH-2108) TCP adaptor should aggregate statistics for listener and connector

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358720#comment-17358720 ] ASF GitHub Bot commented on DISPATCH-2108: -- codecov-commenter commented on pull request

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1244: DISPATCH-2108: Aggregate statistics for TCP listeners and connectors

2021-06-07 Thread GitBox
codecov-commenter commented on pull request #1244: URL: https://github.com/apache/qpid-dispatch/pull/1244#issuecomment-856104407 #

[jira] [Commented] (DISPATCH-1956) Potential deadlock: logging lock vs entity cache lock

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358642#comment-17358642 ] ASF GitHub Bot commented on DISPATCH-1956: -- kgiusti commented on a change in pull request

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1243: DISPATCH-1956: reduce locking around log src lookup

2021-06-07 Thread GitBox
kgiusti commented on a change in pull request #1243: URL: https://github.com/apache/qpid-dispatch/pull/1243#discussion_r646634535 ## File path: src/log.c ## @@ -592,24 +601,22 @@ qd_error_t qd_log_entity(qd_entity_t *entity) QD_ERROR_BREAK(); } -

[jira] [Commented] (DISPATCH-2166) Race accessing message send_complete flag

2021-06-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358639#comment-17358639 ] ASF subversion and git services commented on DISPATCH-2166: --- Commit

[jira] [Created] (DISPATCH-2166) Race accessing message send_complete flag

2021-06-07 Thread Charles E. Rolke (Jira)
Charles E. Rolke created DISPATCH-2166: -- Summary: Race accessing message send_complete flag Key: DISPATCH-2166 URL: https://issues.apache.org/jira/browse/DISPATCH-2166 Project: Qpid Dispatch

[jira] [Commented] (PROTON-2095) Move away from SWIG to CFFI

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358623#comment-17358623 ] ASF GitHub Bot commented on PROTON-2095: astitcher commented on pull request #318: URL:

[GitHub] [qpid-proton] astitcher commented on pull request #318: PROTON-2095 Move away from SWIG to CFFI

2021-06-07 Thread GitBox
astitcher commented on pull request #318: URL: https://github.com/apache/qpid-proton/pull/318#issuecomment-855955069 > > I think that the cffi binding should be a drop in replacement for import cproton as there a number of places where this is used. > > My thinking was that the

[jira] [Commented] (PROTON-2095) Move away from SWIG to CFFI

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358614#comment-17358614 ] ASF GitHub Bot commented on PROTON-2095: jiridanek edited a comment on pull request #318: URL:

[GitHub] [qpid-proton] jiridanek edited a comment on pull request #318: PROTON-2095 Move away from SWIG to CFFI

2021-06-07 Thread GitBox
jiridanek edited a comment on pull request #318: URL: https://github.com/apache/qpid-proton/pull/318#issuecomment-855913484 ``` # cproton.py import lib from lib import pn_unchanged_function def pn_str(a): return ffi.string(lib.pn_str(a)).decode()

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-06-07 Thread Fernando Giorgetti (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358603#comment-17358603 ] Fernando Giorgetti commented on DISPATCH-1878: -- [~chug] I have observed that issue

[jira] [Commented] (PROTON-2095) Move away from SWIG to CFFI

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358584#comment-17358584 ] ASF GitHub Bot commented on PROTON-2095: jiridanek commented on pull request #318: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #318: PROTON-2095 Move away from SWIG to CFFI

2021-06-07 Thread GitBox
jiridanek commented on pull request #318: URL: https://github.com/apache/qpid-proton/pull/318#issuecomment-855913484 ``` # cproton.py import lib import lib.pn_unchanged_function def pn_str(a): return ffi.string(lib.pn_str(a)).decode() __all__ = [

[jira] [Commented] (PROTON-2095) Move away from SWIG to CFFI

2021-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358459#comment-17358459 ] ASF GitHub Bot commented on PROTON-2095: jiridanek commented on pull request #318: URL:

[GitHub] [qpid-proton] jiridanek commented on pull request #318: PROTON-2095 Move away from SWIG to CFFI

2021-06-07 Thread GitBox
jiridanek commented on pull request #318: URL: https://github.com/apache/qpid-proton/pull/318#issuecomment-855754737 > I think that the cffi binding should be a drop in replacement for import cproton as there a number of places where this is used. My thinking was that the `cproton`

[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1245: Bump prettier from 2.2.1 to 2.3.1 in /console/react

2021-06-07 Thread GitBox
codecov-commenter edited a comment on pull request #1245: URL: https://github.com/apache/qpid-dispatch/pull/1245#issuecomment-855647245 #

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1245: Bump prettier from 2.2.1 to 2.3.1 in /console/react

2021-06-07 Thread GitBox
codecov-commenter commented on pull request #1245: URL: https://github.com/apache/qpid-dispatch/pull/1245#issuecomment-855647245 #

[GitHub] [qpid-broker-j] deepyaraj commented on a change in pull request #88: QPID:8525:[Broker-J]Fixed child deletion issue in group providers

2021-06-07 Thread GitBox
deepyaraj commented on a change in pull request #88: URL: https://github.com/apache/qpid-broker-j/pull/88#discussion_r646308117 ## File path: broker-core/src/main/java/org/apache/qpid/server/security/group/FileGroupDatabase.java ## @@ -104,25 +105,31 @@ public synchronized

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1204: Bump prettier from 2.2.1 to 2.3.0 in /console/react

2021-06-07 Thread GitBox
dependabot[bot] closed pull request #1204: URL: https://github.com/apache/qpid-dispatch/pull/1204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1204: Bump prettier from 2.2.1 to 2.3.0 in /console/react

2021-06-07 Thread GitBox
dependabot[bot] commented on pull request #1204: URL: https://github.com/apache/qpid-dispatch/pull/1204#issuecomment-855607990 Superseded by #1245. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1245: Bump prettier from 2.2.1 to 2.3.1 in /console/react

2021-06-07 Thread GitBox
dependabot[bot] opened a new pull request #1245: URL: https://github.com/apache/qpid-dispatch/pull/1245 Bumps [prettier](https://github.com/prettier/prettier) from 2.2.1 to 2.3.1. Release notes Sourced from https://github.com/prettier/prettier/releases;>prettier's releases.