[jira] [Commented] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445599#comment-17445599 ] ASF GitHub Bot commented on PROTON-2441: astitcher commented on pull request #338: URL:

[GitHub] [qpid-proton] astitcher commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault

2021-11-17 Thread GitBox
astitcher commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-972459810 @DreamPearl also note that I subsequently modified your new test in commit 56520fbaa00ab1d64b9672b072f7b8b2e88c1916 to deduplicate the code and also to use more C++11

[jira] [Commented] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445595#comment-17445595 ] ASF GitHub Bot commented on PROTON-2441: astitcher commented on pull request #338: URL:

[jira] [Commented] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445596#comment-17445596 ] ASF GitHub Bot commented on PROTON-2441: astitcher closed pull request #338: URL:

[GitHub] [qpid-proton] astitcher commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault

2021-11-17 Thread GitBox
astitcher commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-972457403 I've merged this PR with a bug fix to an connection leak in the new reconnect test - this leak can be seen in the failing Travis CI job - I think it's unfortunate that the

[GitHub] [qpid-proton] astitcher closed pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault

2021-11-17 Thread GitBox
astitcher closed pull request #338: URL: https://github.com/apache/qpid-proton/pull/338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PROTON-2467) Tidy up C++ reconnect test

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445594#comment-17445594 ] ASF subversion and git services commented on PROTON-2467: - Commit

[jira] [Commented] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls

2021-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445593#comment-17445593 ] ASF subversion and git services commented on PROTON-2441: - Commit

[jira] [Created] (PROTON-2467) Tidy up C++ reconnect test

2021-11-17 Thread Andrew Stitcher (Jira)
Andrew Stitcher created PROTON-2467: --- Summary: Tidy up C++ reconnect test Key: PROTON-2467 URL: https://issues.apache.org/jira/browse/PROTON-2467 Project: Qpid Proton Issue Type:

[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445442#comment-17445442 ] ASF GitHub Bot commented on PROTON-2396: jiridanek commented on a change in pull request #340:

[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445443#comment-17445443 ] ASF GitHub Bot commented on PROTON-2396: jiridanek commented on a change in pull request #340:

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #340: PROTON-2396: Use random_device for seed initialization in uuid.cpp

2021-11-17 Thread GitBox
jiridanek commented on a change in pull request #340: URL: https://github.com/apache/qpid-proton/pull/340#discussion_r751541924 ## File path: cpp/include/proton/uuid.hpp ## @@ -35,13 +38,20 @@ namespace proton { /// A 16-byte universally unique identifier. class uuid :

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #340: PROTON-2396: Use random_device for seed initialization in uuid.cpp

2021-11-17 Thread GitBox
jiridanek commented on a change in pull request #340: URL: https://github.com/apache/qpid-proton/pull/340#discussion_r751541523 ## File path: cpp/include/proton/uuid.hpp ## @@ -35,13 +38,20 @@ namespace proton { /// A 16-byte universally unique identifier. class uuid :

[jira] [Commented] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/QPID-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445379#comment-17445379 ] ASF GitHub Bot commented on QPID-8569: -- pjfawcett opened a new pull request #28: URL:

[GitHub] [qpid-cpp] pjfawcett opened a new pull request #28: QPID-8569 Illegal selector results in undeletable queue

2021-11-17 Thread GitBox
pjfawcett opened a new pull request #28: URL: https://github.com/apache/qpid-cpp/pull/28 Queue creation - don't update QMF until all validation done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread Pete Fawcett (Jira)
[ https://issues.apache.org/jira/browse/QPID-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pete Fawcett updated QPID-8569: --- Description: Using AMQP 1.0 and creating a receiver, with an exchange as a source, and specifying a

[jira] [Updated] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread Pete Fawcett (Jira)
[ https://issues.apache.org/jira/browse/QPID-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pete Fawcett updated QPID-8569: --- Description: Using AMQP 1.0 and creating a receiver, with an exchange as a source, and specifying a

[jira] [Updated] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread Pete Fawcett (Jira)
[ https://issues.apache.org/jira/browse/QPID-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pete Fawcett updated QPID-8569: --- Description: Using AMQP 1.0 and creating a receiver, with an exchange as a source, and specifying a

[jira] [Updated] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread Pete Fawcett (Jira)
[ https://issues.apache.org/jira/browse/QPID-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pete Fawcett updated QPID-8569: --- Description: Using AMQP 1.0 and creating a receiver, with an exchange as a source, and specifying a

[jira] [Assigned] (DISPATCH-2258) test_25_parallel_waypoint_test failing in system_tests_distribution

2021-11-17 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-2258: --- Assignee: Ken Giusti (was: Ganesh Murthy) > test_25_parallel_waypoint_test

[jira] [Commented] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread Pete Fawcett (Jira)
[ https://issues.apache.org/jira/browse/QPID-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445323#comment-17445323 ] Pete Fawcett commented on QPID-8569: I believe the problem is due to an error in the Queue

[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445320#comment-17445320 ] ASF GitHub Bot commented on PROTON-2396: astitcher commented on a change in pull request #340:

[GitHub] [qpid-proton] astitcher commented on a change in pull request #340: PROTON-2396: Use random_device for seed initialization in uuid.cpp

2021-11-17 Thread GitBox
astitcher commented on a change in pull request #340: URL: https://github.com/apache/qpid-proton/pull/340#discussion_r751379226 ## File path: cpp/include/proton/uuid.hpp ## @@ -35,13 +38,20 @@ namespace proton { /// A 16-byte universally unique identifier. class uuid :

[jira] [Commented] (DISPATCH-2258) test_25_parallel_waypoint_test failing in system_tests_distribution

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445311#comment-17445311 ] ASF GitHub Bot commented on DISPATCH-2258: -- kgiusti commented on a change in pull request

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1441: DISPATCH-2258: Cleaned up log messages, created senders after receive…

2021-11-17 Thread GitBox
kgiusti commented on a change in pull request #1441: URL: https://github.com/apache/qpid-dispatch/pull/1441#discussion_r751355815 ## File path: tests/system_tests_distribution.py ## @@ -3884,7 +3882,7 @@ def __init__(self, n_links_per_message = 4

[jira] [Updated] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread Pete Fawcett (Jira)
[ https://issues.apache.org/jira/browse/QPID-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pete Fawcett updated QPID-8569: --- Description: Using AMQP 1.0 and creating a receiver, with an exchange as a source, and specifying a

[jira] [Created] (QPID-8569) Illegal selector results in undeletable queue

2021-11-17 Thread Pete Fawcett (Jira)
Pete Fawcett created QPID-8569: -- Summary: Illegal selector results in undeletable queue Key: QPID-8569 URL: https://issues.apache.org/jira/browse/QPID-8569 Project: Qpid Issue Type: Bug

[jira] [Commented] (PROTON-2466) raw connection posts wake events after disconnect event is handled

2021-11-17 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445250#comment-17445250 ] Ken Giusti commented on PROTON-2466: This is a difficult issue to reproduce.  In my experience it

[jira] [Updated] (PROTON-2466) raw connection posts wake events after disconnect event is handled

2021-11-17 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated PROTON-2466: --- Description: While running tcp stress tests against qdrouterd a crash occurred.  The crash was due

[jira] [Updated] (PROTON-2466) raw connection posts wake events after disconnect event is handled

2021-11-17 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated PROTON-2466: --- Attachment: qdrouterd-B.conf > raw connection posts wake events after disconnect event is handled >

[jira] [Updated] (PROTON-2466) raw connection posts wake events after disconnect event is handled

2021-11-17 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated PROTON-2466: --- Attachment: qdrouterd-A.conf > raw connection posts wake events after disconnect event is handled >

[jira] [Updated] (PROTON-2466) raw connection posts wake events after disconnect event is handled

2021-11-17 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated PROTON-2466: --- Attachment: (was: qdrouterd-A.conf) > raw connection posts wake events after disconnect event

[jira] [Created] (PROTON-2466) raw connection posts wake events after disconnect event is handled

2021-11-17 Thread Ken Giusti (Jira)
Ken Giusti created PROTON-2466: -- Summary: raw connection posts wake events after disconnect event is handled Key: PROTON-2466 URL: https://issues.apache.org/jira/browse/PROTON-2466 Project: Qpid Proton

[jira] [Updated] (PROTON-2466) raw connection posts wake events after disconnect event is handled

2021-11-17 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated PROTON-2466: --- Attachment: qdrouterd-A.conf > raw connection posts wake events after disconnect event is handled >

[jira] [Commented] (DISPATCH-2267) Add a core-thread facility to allow IO modules to subscribe to address-reachability data

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445173#comment-17445173 ] ASF GitHub Bot commented on DISPATCH-2267: -- ted-ross commented on a change in pull request

[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #1435: DISPATCH-2267 - IO-thread facility to watch for changes to address reachability

2021-11-17 Thread GitBox
ted-ross commented on a change in pull request #1435: URL: https://github.com/apache/qpid-dispatch/pull/1435#discussion_r751254686 ## File path: include/qpid/dispatch/router_core.h ## @@ -160,6 +169,64 @@ void qdr_send_to2(qdr_core_t *core, qd_message_t *msg, const char

[jira] [Commented] (DISPATCH-2267) Add a core-thread facility to allow IO modules to subscribe to address-reachability data

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445172#comment-17445172 ] ASF GitHub Bot commented on DISPATCH-2267: -- ted-ross commented on a change in pull request

[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #1435: DISPATCH-2267 - IO-thread facility to watch for changes to address reachability

2021-11-17 Thread GitBox
ted-ross commented on a change in pull request #1435: URL: https://github.com/apache/qpid-dispatch/pull/1435#discussion_r751250679 ## File path: src/router_core/address_watch.c ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (PROTON-2396) [cpp] Seed in uuid.cpp can lead to duplicates

2021-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445148#comment-17445148 ] ASF GitHub Bot commented on PROTON-2396: DreamPearl commented on pull request #340: URL:

[GitHub] [qpid-proton] DreamPearl commented on pull request #340: PROTON-2396: Use random_device for seed initialization in uuid.cpp

2021-11-17 Thread GitBox
DreamPearl commented on pull request #340: URL: https://github.com/apache/qpid-proton/pull/340#issuecomment-971547101 Now the build is passing. @astitcher Can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to