[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1540: Bump browserslist from 4.20.0 to 4.20.2 in /console/react

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #1540: URL: https://github.com/apache/qpid-dispatch/pull/1540 Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.20.0 to 4.20.2. Changelog Sourced from https://github.com/browserslist/browserslist/blob/main/CHANGELOG

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1539: Bump prettier from 2.5.1 to 2.6.0 in /console/react

2022-03-16 Thread GitBox
dependabot[bot] opened a new pull request #1539: URL: https://github.com/apache/qpid-dispatch/pull/1539 Bumps [prettier](https://github.com/prettier/prettier) from 2.5.1 to 2.6.0. Release notes Sourced from https://github.com/prettier/prettier/releases";>prettier's releases.

[GitHub] [qpid-dispatch] jiridanek merged pull request #1536: DISPATCH-2336: Fix Dockerfiles in the dockerfile folder

2022-03-16 Thread GitBox
jiridanek merged pull request #1536: URL: https://github.com/apache/qpid-dispatch/pull/1536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1536: DISPATCH-2336: Fix Dockerfiles in the dockerfile folder

2022-03-16 Thread GitBox
jiridanek commented on a change in pull request #1536: URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r828049522 ## File path: dockerfiles/Dockerfile-ubuntu ## @@ -16,14 +16,17 @@ # specific language governing permissions and limitations # under the License

[GitHub] [qpid-jms] asfgit merged pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-16 Thread GitBox
asfgit merged pull request #45: URL: https://github.com/apache/qpid-jms/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qp

[GitHub] [qpid-jms] tabish121 commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-15 Thread GitBox
tabish121 commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1068426854 Gave it a once over and it looks okay, much simpler than the initial versions I looked at. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [qpid-proton] asfgit closed pull request #362: PROTON-2517: rewind all pn_data about to be used in emitters.h

2022-03-14 Thread GitBox
asfgit closed pull request #362: URL: https://github.com/apache/qpid-proton/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1533: Bump browserslist from 4.19.1 to 4.20.0 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] closed pull request #1533: URL: https://github.com/apache/qpid-dispatch/pull/1533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1535: Bump @patternfly/react-core from 4.192.15 to 4.198.19 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] closed pull request #1535: URL: https://github.com/apache/qpid-dispatch/pull/1535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1533: Bump browserslist from 4.19.1 to 4.20.0 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] commented on pull request #1533: URL: https://github.com/apache/qpid-dispatch/pull/1533#issuecomment-1067194801 Looks like browserslist is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1522: Bump express from 4.17.2 to 4.17.3 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] closed pull request #1522: URL: https://github.com/apache/qpid-dispatch/pull/1522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1522: Bump express from 4.17.2 to 4.17.3 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] commented on pull request #1522: URL: https://github.com/apache/qpid-dispatch/pull/1522#issuecomment-1067194627 Looks like express is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1535: Bump @patternfly/react-core from 4.192.15 to 4.198.19 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] commented on pull request #1535: URL: https://github.com/apache/qpid-dispatch/pull/1535#issuecomment-1067194740 Looks like @patternfly/react-core is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1534: Bump @patternfly/react-topology from 4.39.15 to 4.45.19 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] closed pull request #1534: URL: https://github.com/apache/qpid-dispatch/pull/1534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1522: Bump express from 4.17.2 to 4.17.3 in /console/react

2022-03-14 Thread GitBox
jiridanek commented on pull request #1522: URL: https://github.com/apache/qpid-dispatch/pull/1522#issuecomment-1067194264 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1534: Bump @patternfly/react-topology from 4.39.15 to 4.45.19 in /console/react

2022-03-14 Thread GitBox
dependabot[bot] commented on pull request #1534: URL: https://github.com/apache/qpid-dispatch/pull/1534#issuecomment-1067194398 Looks like @patternfly/react-topology is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1533: Bump browserslist from 4.19.1 to 4.20.0 in /console/react

2022-03-14 Thread GitBox
jiridanek commented on pull request #1533: URL: https://github.com/apache/qpid-dispatch/pull/1533#issuecomment-1067194053 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1535: Bump @patternfly/react-core from 4.192.15 to 4.198.19 in /console/react

2022-03-14 Thread GitBox
jiridanek commented on pull request #1535: URL: https://github.com/apache/qpid-dispatch/pull/1535#issuecomment-1067193796 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1534: Bump @patternfly/react-topology from 4.39.15 to 4.45.19 in /console/react

2022-03-14 Thread GitBox
jiridanek commented on pull request #1534: URL: https://github.com/apache/qpid-dispatch/pull/1534#issuecomment-1067193928 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [qpid-dispatch] jiridanek merged pull request #1537: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release (round 2)

2022-03-14 Thread GitBox
jiridanek merged pull request #1537: URL: https://github.com/apache/qpid-dispatch/pull/1537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1537: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release (round 2)

2022-03-14 Thread GitBox
jiridanek commented on pull request #1537: URL: https://github.com/apache/qpid-dispatch/pull/1537#issuecomment-1067193012 Works for me, lets merge, to get rid of dependabot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [qpid-proton] astitcher commented on a change in pull request #362: PROTON-2517: rewind all pn_data about to be used in emitters.h

2022-03-14 Thread GitBox
astitcher commented on a change in pull request #362: URL: https://github.com/apache/qpid-proton/pull/362#discussion_r826180173 ## File path: c/src/core/emitters.h ## @@ -543,22 +544,27 @@ static inline void emit_multiple(pni_emitter_t* emitter, pni_compound_context* c emit

[GitHub] [qpid-jms] franz1981 commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-14 Thread GitBox
franz1981 commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1067061460 @gemmellr done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [qpid-proton] astitcher commented on pull request #362: PROTON-2517: rewind all pn_data about to be used in emitters.h

2022-03-14 Thread GitBox
astitcher commented on pull request #362: URL: https://github.com/apache/qpid-proton/pull/362#issuecomment-1067058621 The save and restore state is needed here because (at least some of) the pn_data_t values used here come from the user and are not internal to the proton implementation. An

[GitHub] [qpid-proton] cliffjansen opened a new pull request #362: PROTON-2517: rewind all pn_data about to be used in emitters.h

2022-03-14 Thread GitBox
cliffjansen opened a new pull request #362: URL: https://github.com/apache/qpid-proton/pull/362 Intercepts all pn_data_t emitter functions and does rewind. In array case, also points to first node so that pn_data_type and pn_data_get_array work properly. These are consistent w

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1536: DISPATCH-2336 Fix Dockerfile Ubuntu build

2022-03-14 Thread GitBox
ganeshmurthy commented on a change in pull request #1536: URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r826045500 ## File path: dockerfiles/Dockerfile-ubuntu ## @@ -16,14 +16,17 @@ # specific language governing permissions and limitations # under the Lice

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1536: DISPATCH-2336 Fix Dockerfile Ubuntu build

2022-03-14 Thread GitBox
jiridanek commented on a change in pull request #1536: URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r825969556 ## File path: dockerfiles/Dockerfile-ubuntu ## @@ -16,14 +16,17 @@ # specific language governing permissions and limitations # under the License

[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1536: DISPATCH-2336 Fix Dockerfile Ubuntu build

2022-03-14 Thread GitBox
ganeshmurthy commented on a change in pull request #1536: URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r825964266 ## File path: dockerfiles/Dockerfile-ubuntu ## @@ -16,14 +16,17 @@ # specific language governing permissions and limitations # under the Lice

[GitHub] [qpid-jms] gemmellr commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-14 Thread GitBox
gemmellr commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1066620327 Can you rebase it against main also please. Then I'd like @tabish121 to give it another skim. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1537: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release (round 2)

2022-03-13 Thread GitBox
codecov-commenter commented on pull request #1537: URL: https://github.com/apache/qpid-dispatch/pull/1537#issuecomment-1066160970 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #361: NO-JIRA: Add ClusterFuzzLite PR fuzzing

2022-03-13 Thread GitBox
codecov-commenter edited a comment on pull request #361: URL: https://github.com/apache/qpid-proton/pull/361#issuecomment-1066154855 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/361?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[GitHub] [qpid-proton] codecov-commenter commented on pull request #361: NO-JIRA: Add ClusterFuzzLite PR fuzzing

2022-03-13 Thread GitBox
codecov-commenter commented on pull request #361: URL: https://github.com/apache/qpid-proton/pull/361#issuecomment-1066154855 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/361?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [qpid-proton] jiridanek merged pull request #358: PROTON-2453 fix socket.socket type annotations and add more types

2022-03-13 Thread GitBox
jiridanek merged pull request #358: URL: https://github.com/apache/qpid-proton/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1536: DISPATCH-2336 Fix Dockerfile Ubuntu build

2022-03-13 Thread GitBox
codecov-commenter edited a comment on pull request #1536: URL: https://github.com/apache/qpid-dispatch/pull/1536#issuecomment-1066103408 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1536?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1536: DISPATCH-2336 Fix Dockerfile Ubuntu build

2022-03-13 Thread GitBox
codecov-commenter commented on pull request #1536: URL: https://github.com/apache/qpid-dispatch/pull/1536#issuecomment-1066103408 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1536?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[GitHub] [qpid-jms] franz1981 commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-12 Thread GitBox
franz1981 commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1065906992 Thanks @gemmellr for the suggestions and fixes: now squashed and ready to go -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1529: Bump @patternfly/react-core from 4.192.15 to 4.198.5 in /console/react

2022-03-11 Thread GitBox
dependabot[bot] closed pull request #1529: URL: https://github.com/apache/qpid-dispatch/pull/1529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1529: Bump @patternfly/react-core from 4.192.15 to 4.198.5 in /console/react

2022-03-11 Thread GitBox
dependabot[bot] commented on pull request #1529: URL: https://github.com/apache/qpid-dispatch/pull/1529#issuecomment-1065309368 Superseded by #1535. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1535: Bump @patternfly/react-core from 4.192.15 to 4.198.19 in /console/react

2022-03-11 Thread GitBox
dependabot[bot] opened a new pull request #1535: URL: https://github.com/apache/qpid-dispatch/pull/1535 Bumps [@patternfly/react-core](https://github.com/patternfly/patternfly-react) from 4.192.15 to 4.198.19. Release notes Sourced from https://github.com/patternfly/patternfly-re

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1530: Bump @patternfly/react-topology from 4.39.15 to 4.45.5 in /console/react

2022-03-11 Thread GitBox
dependabot[bot] closed pull request #1530: URL: https://github.com/apache/qpid-dispatch/pull/1530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1530: Bump @patternfly/react-topology from 4.39.15 to 4.45.5 in /console/react

2022-03-11 Thread GitBox
dependabot[bot] commented on pull request #1530: URL: https://github.com/apache/qpid-dispatch/pull/1530#issuecomment-1065308683 Superseded by #1534. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1534: Bump @patternfly/react-topology from 4.39.15 to 4.45.19 in /console/react

2022-03-11 Thread GitBox
dependabot[bot] opened a new pull request #1534: URL: https://github.com/apache/qpid-dispatch/pull/1534 Bumps [@patternfly/react-topology](https://github.com/patternfly/patternfly-react) from 4.39.15 to 4.45.19. Release notes Sourced from https://github.com/patternfly/patternfly-

[GitHub] [qpid-broker-j] vavrtom merged pull request #119: QPID-8578: [Broker-J] ACL firewall predicates should be applied to HTTP(S) connections

2022-03-10 Thread GitBox
vavrtom merged pull request #119: URL: https://github.com/apache/qpid-broker-j/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r823825417 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupFactory.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r823824688 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java ## @@ -213,6 +215,14 @@ public void setTcpKeepAlive(boole

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r823714637 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java ## @@ -213,6 +215,14 @@ public void setTcpKeepAlive(boolea

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r823714637 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java ## @@ -213,6 +215,14 @@ public void setTcpKeepAlive(boolea

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r823569330 ## File path: qpid-jms-client/src/test/java/org/apache/qpid/jms/transports/netty/NettyTcpTransportTest.java ## @@ -394,6 +399,123 @@ public void testZeroSi

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r823559298 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupFactory.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
franz1981 edited a comment on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1063833632 FYI I've run this PR with the shiny new benchmarking tool in Artemis: - using 200 producers/200 consumers with `transport.sharedEventLoopThreads=-1` at the rate of 1000

[GitHub] [qpid-jms] franz1981 commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-10 Thread GitBox
franz1981 commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1063833632 FYI I've run this PR with the shiny new benchmarking tool in Artemis: - using 100 producers/100 consumers with `transport.sharedEventLoopThreads=-1` at the rate of 1000 msg/se

[GitHub] [qpid-jms] franz1981 commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-09 Thread GitBox
franz1981 commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1063687172 @gemmellr I've further simplified things here by moving some of the bootstrap setup logic and event loop group creation logic into `EventLoopType`: this will save leaking enum i

[GitHub] [qpid-jms] gemmellr commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-09 Thread GitBox
gemmellr commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1062882201 Your latest version is a bit simpler, but for reference I banged together the 'trivial synchronized map' version I was thinking of and some other simplifications and changes from

[GitHub] [qpid-broker-j] vavrtom merged pull request #118: QPID-8566: [Broker-J] Implement composite authentication provider

2022-03-08 Thread GitBox
vavrtom merged pull request #118: URL: https://github.com/apache/qpid-broker-j/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-08 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r821733009 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyTcpTransport.java ## @@ -233,15 +228,13 @@ public void close() throw

[GitHub] [qpid-broker-j] dakirily closed pull request #105: QPID-8557 - [Broker-J] Batching mode for CoalescingCommitter

2022-03-08 Thread GitBox
dakirily closed pull request #105: URL: https://github.com/apache/qpid-broker-j/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [qpid-broker-j] dakirily opened a new pull request #119: QPID-8578: [Broker-J] ACL firewall predicates should be applied to HTTP(S) connections

2022-03-07 Thread GitBox
dakirily opened a new pull request #119: URL: https://github.com/apache/qpid-broker-j/pull/119 This PR is supposed to solve issue described in JIRA [QPID-8578](https://issues.apache.org/jira/browse/QPID-8578). -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-07 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r820939473 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyTcpTransport.java ## @@ -233,15 +228,13 @@ public void close() throws

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1533: Bump browserslist from 4.19.1 to 4.20.0 in /console/react

2022-03-07 Thread GitBox
dependabot[bot] opened a new pull request #1533: URL: https://github.com/apache/qpid-dispatch/pull/1533 Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.19.1 to 4.20.0. Changelog Sourced from https://github.com/browserslist/browserslist/blob/main/CHANGELOG

[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1526: Bump browserslist from 4.19.1 to 4.19.3 in /console/react

2022-03-07 Thread GitBox
dependabot[bot] closed pull request #1526: URL: https://github.com/apache/qpid-dispatch/pull/1526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1526: Bump browserslist from 4.19.1 to 4.19.3 in /console/react

2022-03-07 Thread GitBox
dependabot[bot] commented on pull request #1526: URL: https://github.com/apache/qpid-dispatch/pull/1526#issuecomment-1060916791 Superseded by #1533. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-07 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r820867326 ## File path: qpid-jms-client/src/test/java/org/apache/qpid/jms/transports/netty/NettyTcpTransportTest.java ## @@ -730,14 +821,30 @@ private void assertEp

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-07 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r820863114 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyTcpTransport.java ## @@ -233,15 +228,13 @@ public void close() throw

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-07 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r820861231 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupFactory.java ## @@ -0,0 +1,288 @@ +/* + * Licensed to

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-07 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r820860187 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupFactory.java ## @@ -0,0 +1,288 @@ +/* + * Licensed to

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-07 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r820801073 ## File path: qpid-jms-client/src/test/java/org/apache/qpid/jms/transports/netty/NettyTcpTransportTest.java ## @@ -394,6 +403,88 @@ public void testZeroSiz

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-03 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r818514513 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-03 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r818501543 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-03 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r818479923 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry

2022-03-03 Thread GitBox
codecov-commenter edited a comment on pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#issuecomment-1016557338 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/355?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry

2022-03-03 Thread GitBox
DreamPearl commented on a change in pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#discussion_r818468401 ## File path: cpp/src/sender.cpp ## @@ -70,6 +71,10 @@ tracker sender::send(const message &message, const binary &tag) { pn_delivery_t *dlv = p

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry

2022-03-03 Thread GitBox
DreamPearl commented on a change in pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#discussion_r818466429 ## File path: cpp/src/tracing_dummy.cpp ## @@ -0,0 +1,36 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-03 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r818465913 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPool.java ## @@ -0,0 +1,175 @@ +/* + * Licensed to the

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1532: Bump actions/checkout from 2 to 3

2022-03-02 Thread GitBox
dependabot[bot] opened a new pull request #1532: URL: https://github.com/apache/qpid-dispatch/pull/1532 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases.

[GitHub] [qpid-proton] jiridanek merged pull request #360: PROTON-2511: Fix Fatal Python error: deallocating None

2022-03-02 Thread GitBox
jiridanek merged pull request #360: URL: https://github.com/apache/qpid-proton/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [qpid-proton] astitcher commented on pull request #360: Update Bug: Fatal Python error: deallocating None

2022-03-02 Thread GitBox
astitcher commented on pull request #360: URL: https://github.com/apache/qpid-proton/pull/360#issuecomment-1056955245 Oops, this is a potentially nasty bug! I should check that we don't make this mistake anywhere else. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r817678907 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r817678907 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r817678907 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 edited a comment on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1056916847 > The same 'this seems overly complex' comment would seem to apply around the pooling of the group, which seems like a large amount of complex handling for what is essent

[GitHub] [qpid-jms] franz1981 commented on pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 commented on pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1056916847 > The same 'this seems overly complex' comment would seem to apply around the pooling of the group, which seems like a large amount of complex handling for what is essentially a

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r817671598 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r817671598 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] franz1981 commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
franz1981 commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r817671598 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r817649209 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-jms] gemmellr commented on a change in pull request #45: QPIDJMS-553 Shared Netty event loop group

2022-03-02 Thread GitBox
gemmellr commented on a change in pull request #45: URL: https://github.com/apache/qpid-jms/pull/45#discussion_r816735224 ## File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/netty/NettyEventLoopGroupPoolFactory.java ## @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] [qpid-proton] tanzhiying commented on pull request #360: Update Bug: Fatal Python error: deallocating None

2022-03-02 Thread GitBox
tanzhiying commented on pull request #360: URL: https://github.com/apache/qpid-proton/pull/360#issuecomment-1056743278 你好,我已收到您的邮箱,尽快回复                                      -谭志颖 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [qpid-proton] jiridanek commented on pull request #360: Update Bug: Fatal Python error: deallocating None

2022-03-02 Thread GitBox
jiridanek commented on pull request #360: URL: https://github.com/apache/qpid-proton/pull/360#issuecomment-1056742835 @astitcher I think that this is useful fix and I saw a similar problem in Dispatch as well, https://issues.apache.org/jira/browse/DISPATCH-2316. I am not sure if 0.37.0 sho

[GitHub] [qpid-proton] tanzhiying opened a new pull request #360: Update Bug: Fatal Python error: deallocating None

2022-03-01 Thread GitBox
tanzhiying opened a new pull request #360: URL: https://github.com/apache/qpid-proton/pull/360 Fatal Python error: deallocating None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [qpid-dispatch] jiridanek merged pull request #1521: DISPATCH-2144 Remove Python lock on the router's side; use the lock Python itself created

2022-03-01 Thread GitBox
jiridanek merged pull request #1521: URL: https://github.com/apache/qpid-dispatch/pull/1521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [qpid-jms] gemmellr commented on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2022-03-01 Thread GitBox
gemmellr commented on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-1055436409 Having just read them all, the existing feedback and questions (e.g impact on default case) on the code and in the discussion essentially all still seems to apply now (even some

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1531: Bump actions/setup-python from 2 to 3

2022-02-28 Thread GitBox
codecov-commenter commented on pull request #1531: URL: https://github.com/apache/qpid-dispatch/pull/1531#issuecomment-1054538980 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1531?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1531: Bump actions/setup-python from 2 to 3

2022-02-28 Thread GitBox
dependabot[bot] opened a new pull request #1531: URL: https://github.com/apache/qpid-dispatch/pull/1531 Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 3. Release notes Sourced from https://github.com/actions/setup-python/releases";>actions/setup-py

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry

2022-02-24 Thread GitBox
DreamPearl commented on a change in pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#discussion_r813864011 ## File path: cpp/src/sender.cpp ## @@ -70,6 +71,10 @@ tracker sender::send(const message &message, const binary &tag) { pn_delivery_t *dlv = p

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry

2022-02-24 Thread GitBox
DreamPearl commented on a change in pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#discussion_r813856498 ## File path: cpp/src/sender.cpp ## @@ -67,11 +68,20 @@ tracker sender::send(const message &message) { } tracker sender::send(const message &mess

[GitHub] [qpid-proton] kpvdr commented on pull request #354: PROTON-2060: Proposed doc changes to clarify auto-settle usage

2022-02-23 Thread GitBox
kpvdr commented on pull request #354: URL: https://github.com/apache/qpid-proton/pull/354#issuecomment-1049055205 Squashed and merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [qpid-proton] kpvdr closed pull request #354: PROTON-2060: Proposed doc changes to clarify auto-settle usage

2022-02-23 Thread GitBox
kpvdr closed pull request #354: URL: https://github.com/apache/qpid-proton/pull/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1530: Bump @patternfly/react-topology from 4.39.15 to 4.45.5 in /console/react

2022-02-23 Thread GitBox
dependabot[bot] opened a new pull request #1530: URL: https://github.com/apache/qpid-dispatch/pull/1530 Bumps [@patternfly/react-topology](https://github.com/patternfly/patternfly-react) from 4.39.15 to 4.45.5. Release notes Sourced from https://github.com/patternfly/patternfly-r

[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1529: Bump @patternfly/react-core from 4.192.15 to 4.198.5 in /console/react

2022-02-23 Thread GitBox
dependabot[bot] opened a new pull request #1529: URL: https://github.com/apache/qpid-dispatch/pull/1529 Bumps [@patternfly/react-core](https://github.com/patternfly/patternfly-react) from 4.192.15 to 4.198.5. Release notes Sourced from https://github.com/patternfly/patternfly-rea

[GitHub] [qpid-proton] astitcher commented on a change in pull request #355: PROTON-2487: [cpp] Implement distributed tracing using OpenTelemetry

2022-02-23 Thread GitBox
astitcher commented on a change in pull request #355: URL: https://github.com/apache/qpid-proton/pull/355#discussion_r812535421 ## File path: cpp/examples/tracing_demo.cpp ## @@ -0,0 +1,91 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

<    2   3   4   5   6   7   8   9   10   11   >