[GitHub] qpid-cpp pull request #18: QPID-8188 Invalid type qualifiers causes build fa...

2018-05-10 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/18 QPID-8188 Invalid type qualifiers causes build failure on GCC 8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/fourceu/qpid-cpp

[GitHub] qpid-cpp pull request #17: QPID-8187 Allow incompatible function casts for S...

2018-05-10 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/17 QPID-8187 Allow incompatible function casts for SASL compatibility (GCC 8 onwards) You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] qpid-cpp pull request #16: QPID-8187 Allow incompatible function casts for S...

2018-05-10 Thread chrisrichardson77
Github user chrisrichardson77 closed the pull request at: https://github.com/apache/qpid-cpp/pull/16 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp pull request #16: QPID-8187 Allow incompatible function casts for S...

2018-05-10 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/16 QPID-8187 Allow incompatible function casts for SASL compatibility (GCC 8 onwards) You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] qpid-cpp issue #15: QPID-8187 Allow incompatible function casts for SASL com...

2018-05-10 Thread chrisrichardson77
Github user chrisrichardson77 commented on the issue: https://github.com/apache/qpid-cpp/pull/15 -1, fails on older compiler versions. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional

[GitHub] qpid-cpp pull request #15: QPID-8187 Allow incompatible function casts for S...

2018-05-10 Thread chrisrichardson77
Github user chrisrichardson77 closed the pull request at: https://github.com/apache/qpid-cpp/pull/15 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp pull request #15: QPID-8187 Allow incompatible function casts for S...

2018-05-10 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/15 QPID-8187 Allow incompatible function casts for SASL compatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/fourceu/qpid-cpp

[GitHub] qpid-cpp pull request #14: QPID-8186 Use const ref when catching exceptions

2018-05-10 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/14 QPID-8186 Use const ref when catching exceptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/fourceu/qpid-cpp QPID-8186

[GitHub] qpid-cpp issue #10: Assorted C++ build fixes for review

2017-10-12 Thread chrisrichardson77
Github user chrisrichardson77 commented on the issue: https://github.com/apache/qpid-cpp/pull/10 There is a third option as mentioned in the stackoverflow article you linked - that of #pragma directives ... arguably even more ugly than the 's("")' syntax so we might ha

[GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review

2017-10-11 Thread chrisrichardson77
Github user chrisrichardson77 commented on a diff in the pull request: https://github.com/apache/qpid-cpp/pull/10#discussion_r143968869 --- Diff: src/qpid/broker/Selector.cpp --- @@ -108,7 +108,7 @@ MessageSelectorEnv::MessageSelectorEnv(const Message& m) : const V

[GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review

2017-10-11 Thread chrisrichardson77
Github user chrisrichardson77 commented on a diff in the pull request: https://github.com/apache/qpid-cpp/pull/10#discussion_r143973175 --- Diff: src/qpid/broker/SelectorToken.h --- @@ -69,7 +69,8 @@ struct Token { std::string val; std::string::const_iterator

[GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review

2017-10-11 Thread chrisrichardson77
Github user chrisrichardson77 commented on a diff in the pull request: https://github.com/apache/qpid-cpp/pull/10#discussion_r143969360 --- Diff: src/qpid/broker/SelectorExpression.cpp --- @@ -1036,7 +1036,7 @@ Expression* unaryArithExpression(Tokeniser& tokeniser) Expres

[GitHub] qpid-cpp pull request #10: Assorted C++ build fixes for review

2017-10-11 Thread chrisrichardson77
Github user chrisrichardson77 commented on a diff in the pull request: https://github.com/apache/qpid-cpp/pull/10#discussion_r143969055 --- Diff: src/qpid/broker/Selector.cpp --- @@ -165,8 +165,6 @@ const Value MessageSelectorEnv::specialValue(const string& id) c

[GitHub] qpid-cpp issue #10: Assorted C++ build fixes for review

2017-10-11 Thread chrisrichardson77
Github user chrisrichardson77 commented on the issue: https://github.com/apache/qpid-cpp/pull/10 I previous wrote some rather verbose comments about the initialisation warning, then deleted them thinking I was perhaps stating the obvious. Since there hasn't really been any other

[GitHub] qpid-cpp pull request #6: QPID-7875 qpid-route fetches links multiple times ...

2017-09-29 Thread chrisrichardson77
Github user chrisrichardson77 closed the pull request at: https://github.com/apache/qpid-cpp/pull/6 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #6: QPID-7875 qpid-route fetches links multiple times when de...

2017-09-29 Thread chrisrichardson77
Github user chrisrichardson77 commented on the issue: https://github.com/apache/qpid-cpp/pull/6 Merged, closing. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h

[GitHub] qpid-cpp pull request #8: QPID-7874 Use qpid-route quiet option to suppress ...

2017-09-29 Thread chrisrichardson77
Github user chrisrichardson77 closed the pull request at: https://github.com/apache/qpid-cpp/pull/8 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #8: QPID-7874 Use qpid-route quiet option to suppress extra l...

2017-09-29 Thread chrisrichardson77
Github user chrisrichardson77 commented on the issue: https://github.com/apache/qpid-cpp/pull/8 Merged, closing. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h

[GitHub] qpid-cpp pull request #7: QPID-7876 qpid-route does not properly consider sr...

2017-09-29 Thread chrisrichardson77
Github user chrisrichardson77 closed the pull request at: https://github.com/apache/qpid-cpp/pull/7 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-cpp issue #7: QPID-7876 qpid-route does not properly consider src-local...

2017-09-29 Thread chrisrichardson77
Github user chrisrichardson77 commented on the issue: https://github.com/apache/qpid-cpp/pull/7 Merged, closing. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h

[GitHub] qpid-cpp issue #5: QPID-7874 Remove unnecessary link check when adding route...

2017-08-02 Thread chrisrichardson77
Github user chrisrichardson77 commented on the issue: https://github.com/apache/qpid-cpp/pull/5 Better fix proposed with use of config flag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] qpid-cpp pull request #5: QPID-7874 Remove unnecessary link check when addin...

2017-08-02 Thread chrisrichardson77
Github user chrisrichardson77 closed the pull request at: https://github.com/apache/qpid-cpp/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] qpid-cpp pull request #8: QPID-7874 Use qpid-route quiet option to suppress ...

2017-08-02 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/8 QPID-7874 Use qpid-route quiet option to suppress extra link checks You can merge this pull request into a Git repository by running: $ git pull https://github.com/fourceu/qpid-cpp

[GitHub] qpid-cpp pull request #7: QPID-7876 qpid-route does not properly consider sr...

2017-08-01 Thread chrisrichardson77
Github user chrisrichardson77 commented on a diff in the pull request: https://github.com/apache/qpid-cpp/pull/7#discussion_r130713409 --- Diff: management/python/bin/qpid-route --- @@ -331,53 +337,63 @@ class RouteManager: if b[0] != self.local.name

[GitHub] qpid-cpp pull request #7: QPID-7876 qpid-route does not properly consider sr...

2017-08-01 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/7 QPID-7876 qpid-route does not properly consider src-local when matchi… See QPID-7876 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] qpid-cpp pull request #6: QPID-7875 qpid-route fetches links multiple times ...

2017-08-01 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/6 QPID-7875 qpid-route fetches links multiple times when deleting routes See https://issues.apache.org/jira/browse/QPID-7875 You can merge this pull request into a Git repository by running

[GitHub] qpid-cpp pull request #5: QPID-7874 Remove unnecessary link check when addin...

2017-08-01 Thread chrisrichardson77
GitHub user chrisrichardson77 opened a pull request: https://github.com/apache/qpid-cpp/pull/5 QPID-7874 Remove unnecessary link check when adding routes with qpid-… See https://issues.apache.org/jira/browse/QPID-7874 You can merge this pull request into a Git repository