[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-11-02 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-11-02 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-11-02 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435 I've sent a change that it's introducing `HolderSuppliers` (bad name, so happy to receive feedbacks/suggestions) and `SharedDisposable` as a util that could be used on

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-11-02 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-957253435 I've sent a change that it's introducing `HolderSuppliers` (bad name, so happy to receive feedbacks/suggestions) and `SharedDisposable` as a util that could be used on

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-954006068 Yep, but if people decide to use 100 connections, why they should have 100 separate completion thread pools? I was thinking about a proper shared approach really that

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953989682 > Ok. It seemed like you wanted to make it the default. I didn't said it clearly on the PR, but I don't want to break existing users code :)

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953989682 > Ok. It seemed like you wanted to make it the default. I didn't said it clearly on the PR, but I don't want to break existing users code :)

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953977356 > I do specifically want to avoid a default case where users need to end up tweaking thread counts because an entirely legitimate blocking workload is drowning out other

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953977356 > I do specifically want to avoid a default case where users need to end up tweaking thread counts because an entirely legitimate blocking workload is drowning out other

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953921514 @gemmellr I'm going to send a separate commit that handle this same issue in a different way, similar to what https://github.com/apache/qpid-jms/pull/45 has done ie

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953876427 @gemmellr I've pushed a change that allow using a single connection executor to handle all the sessions completions, although the processing algorithm has been

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953645864 > I dont believe it will ever work the way you want with a simple queue of any size. You have to add hoops to manipulate it into behaving that way A synchrnous

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953645864 > I dont believe it will ever work the way you want with a simple queue of any size. You have to add hoops to manipulate it into behaving that way A synchrnous

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953645864 > I dont believe it will ever work the way you want with a simple queue of any size. You have to add hoops to manipulate it into behaving that way A synchrnous

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953645864 > I dont believe it will ever work the way you want with a simple queue of any size. You have to add hoops to manipulate it into behaving that way A synchrnous

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-28 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953645864 > I dont believe it will ever work the way you want with a simple queue of any size. You have to add hoops to manipulate it into behaving that way A synchrnous

[GitHub] [qpid-jms] franz1981 edited a comment on pull request #44: QPIDJMS-552 JMS 2 Completion threads shouldn't scale with the number of sessions

2021-10-27 Thread GitBox
franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953048652 Oops my bad, I should have used a synchronous queue instead of a linked blocking queue and it should behave as expected I would run the bench again to be sure it