gemmellr commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-956139968
The change itself seems reasonable to me, it looks similar to what the other bit a little above it is doing. I know Jiri thought, and I agree, that ensuring a test of some kind covers this would be good since obviously nothing existing covered this except the example, and so still doesnt with this as-is. Plus that it might also be good to protect the spot where the segfault actually occurred, rather than just the outer segment where the option is passed through to it, so no other routes can hit similar issue in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
