[GitHub] qpid-proton-j pull request #18: NO-JIRA Minor code improvements (e.g. semico...

2018-11-06 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton-j/pull/18#discussion_r231105833 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/message/impl/MessageImpl.java --- @@ -49,11 +49,7 @@ } } -pr

[GitHub] qpid-proton-j pull request #18: NO-JIRA Minor code improvements (e.g. semico...

2018-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton-j/pull/18 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton-j pull request #18: NO-JIRA Minor code improvements (e.g. semico...

2018-11-06 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-proton-j/pull/18#discussion_r231104760 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/message/impl/MessageImpl.java --- @@ -49,11 +49,7 @@ } } -pr

[GitHub] qpid-proton-j pull request #18: NO-JIRA Minor code improvements (e.g. semico...

2018-10-16 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-proton-j/pull/18#discussion_r225562577 --- Diff: examples/reactor/src/main/java/org/apache/qpid/proton/example/reactor/EchoInputStreamWrapper.java --- @@ -31,11 +31,12 @@ public