Re: Review Request: QPID-4760: Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-25 Thread Fraser Adams
Robbie/All I've attached an update of this work incorporating Robbie's suggestions for improving the getSessionAdapter() helper method. Does that cover what you were thinking? Frase On 23/04/13 21:13, Robbie Gemmell wrote: On 23 April 2013 18:59, Fraser Adams fraser.ad...@blueyonder.co.uk

Re: Review Request: QPID-4760: Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-23 Thread Fraser Adams
On 22/04/13 22:26, Robbie Gemmell wrote: Looking this over it seems like it would work, but I can't say I am a big fan of inspecting potentially every connection during every consumer creation and removal. Yeah I have to agree with you there, I wasn't wildly keen on it myself but I couldn't

Re: Review Request: QPID-4760: Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-23 Thread Robbie Gemmell
On 23 April 2013 18:59, Fraser Adams fraser.ad...@blueyonder.co.uk wrote: On 22/04/13 22:26, Robbie Gemmell wrote: Looking this over it seems like it would work, but I can't say I am a big fan of inspecting potentially every connection during every consumer creation and removal. Yeah I

Re: Review Request: QPID-4760: Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-22 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10686/#review19545 --- Sorry for the delayed response, you picked possibly the second time

Review Request: QPID-4760: Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-20 Thread Fraser Adams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10686/ --- Review request for qpid, Gordon Sim, Robbie Gemmell, and Rob Godfrey.