Re: Review Request: part 2 of gcc flags for C++ compatibility

2013-01-28 Thread Cliff Jansen
On Jan. 25, 2013, 7:01 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c, line 717 https://reviews.apache.org/r/9085/diff/1/?file=251495#file251495line717 If/when possible, I'd prefer declaring these as pointer-to-const,

Re: Review Request: part 2 of gcc flags for C++ compatibility

2013-01-28 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9085/#review15775 --- Ship it! Ship It! - Rafael Schloming On Jan. 24, 2013, 8:24

Re: Review Request: part 2 of gcc flags for C++ compatibility

2013-01-25 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9085/#review15700 ---

Review Request: part 2 of gcc flags for C++ compatibility

2013-01-24 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9085/ --- Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and

Re: Review Request: part 2 of gcc flags for C++ compatibility

2013-01-24 Thread Mary Hinton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9085/#review15666 --- Ship it! Ship It! - Mary Hinton On Jan. 24, 2013, 8:24 a.m.,