Re: Review Request: receiver/session locking changes

2013-04-26 Thread Gordon Sim
On April 25, 2013, 10:13 p.m., Alan Conway wrote: /trunk/qpid/cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp, line 205 https://reviews.apache.org/r/10704/diff/1/?file=283074#file283074line205 It's not immediately obvious that this is safe - could there be code that depends on the

Re: Review Request: receiver/session locking changes

2013-04-26 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10704/#review19769 --- Ship it! Ship It! - Alan Conway On April 22, 2013, 3:52 p.m.,

Re: Review Request: receiver/session locking changes

2013-04-25 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10704/#review19736 --- I don't see anything wrong but on fetchImpl I'm not familiar enough

Review Request: receiver/session locking changes

2013-04-22 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10704/ --- Review request for qpid and Alan Conway. Description --- The changes