Re: Review Request 12289: QPID-4327: TransactionObserver interface

2013-07-12 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/ --- (Updated July 12, 2013, 4:19 p.m.) Review request for qpid, Andrew Stitcher

Re: Review Request 12289: QPID-4327: TransactionObserver interface.

2013-07-08 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/#review22810 --- /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h

Re: Review Request 12289: QPID-4327: TransactionObserver interface.

2013-07-08 Thread Alan Conway
On July 8, 2013, 12:10 p.m., Gordon Sim wrote: /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h, line 48 https://reviews.apache.org/r/12289/diff/1/?file=318402#file318402line48 It's really the enqueue and dequeue operations that are transactional. It might be better to

Re: Review Request 12289: QPID-4327: TransactionObserver interface.

2013-07-08 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/ --- (Updated July 8, 2013, 8:40 p.m.) Review request for qpid, Andrew Stitcher and

Re: Review Request 12289: QPID-4327: TransactionObserver interface.

2013-07-08 Thread Gordon Sim
On July 8, 2013, 12:10 p.m., Gordon Sim wrote: /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h, line 48 https://reviews.apache.org/r/12289/diff/1/?file=318402#file318402line48 It's really the enqueue and dequeue operations that are transactional. It might be better to

Review Request 12289: QPID-4327: TransactionObserver interface.

2013-07-05 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/ --- Review request for qpid, Andrew Stitcher and Gordon Sim. Repository: qpid